Re: [dev] structural regular expression support for vis

2017-02-10 Thread Marc André Tanner
On Mon, Feb 06, 2017 at 10:25:35AM +, Raphaël Proust wrote: > On 3 February 2017 at 20:30, Marc André Tanner wrote: > > On Fri, Feb 03, 2017 at 10:00:37AM +, Raphaël Proust wrote: > > […] > >> :x/pattern/ t h c/replacement/ > > > > Not sure this is flexible enough? How would you generalize

Re: [dev] structural regular expression support for vis

2017-02-06 Thread Raphaël Proust
On 3 February 2017 at 20:30, Marc André Tanner wrote: > On Fri, Feb 03, 2017 at 10:00:37AM +, Raphaël Proust wrote: > […] >> :x/pattern/ t h c/replacement/ > > Not sure this is flexible enough? How would you generalize this to > operate on the n-th dot in a convenient way? :x/pattern/ t5 h c/

Re: [dev] structural regular expression support for vis

2017-02-03 Thread Marc André Tanner
On Fri, Feb 03, 2017 at 10:00:37AM +, Raphaël Proust wrote: > On 2 February 2017 at 17:46, Marc André Tanner wrote: > >Sam supports a count specifier: s2/pattern/replacement/ only replaces > >the second occurrence of pattern. This is currently not supported but > >can be mimicked u

Re: [dev] structural regular expression support for vis

2017-02-03 Thread Connor Lane Smith
On 3 February 2017 at 10:00, Raphaël Proust wrote: > One thing that always bothers me with regexes is that the same syntax > (parens) is used for both overriding precedence (e.g., `(foo)*` to > specify that star operates on the sequence `foo`) and groups (to be > recalled with `\1`–`\9`). > > Anyo

Re: [dev] structural regular expression support for vis

2017-02-03 Thread Raphaël Proust
On 3 February 2017 at 10:00, Raphaël Proust wrote: > On 2 February 2017 at 17:46, Marc André Tanner wrote: >> […] >> * Multi file support is not really well supported: >> >> - The X and Y commands currently operate on windows, not files. >> Meaning that if a file is being displayed in

Re: [dev] structural regular expression support for vis

2017-02-03 Thread Raphaël Proust
On 2 February 2017 at 17:46, Marc André Tanner wrote: > […] > In the meantime lots of bugs have been fixed. I would like to encourage > all sam/acme users who are also somewhat familiar with vi(m) to try out > current master of vis and report back on their experience: > > https://github.com/mart

Re: [dev] structural regular expression support for vis

2017-02-02 Thread Marc André Tanner
On Fri, Mar 11, 2016 at 08:08:38PM +0100, Marc André Tanner wrote: > On Tue, Mar 01, 2016 at 05:23:11PM +, Connor Lane Smith wrote: > > On 1 March 2016 at 17:12, Marc André Tanner wrote: > > > I think structural regexp will integrate nicely with multiple selections. > > > > > > Basically if yo

Re: [dev] structural regular expression support for vis

2016-05-05 Thread Marc André Tanner
Hi all, While there are still some bugs left, I'm quite happy how structural regexp support for vis is progressing. Known issues include: - relative line specifiers are in some cases wrongly interpreted, as a consequence -0+,+0- rounds dot up instead of down to whole lines - s (substitut

Re: [dev] structural regular expression support for vis

2016-05-05 Thread Marc André Tanner
On Wed, Apr 06, 2016 at 01:07:10PM -0500, Joshua Haase wrote: > - When using sam commands, calling undo once does not restore the > previous state. > > One can restore previous state by calling undo several times, but > expected behavior is to call it once, as it is logically one > operati

Re: [dev] structural regular expression support for vis

2016-04-13 Thread Marc André Tanner
On Wed, Apr 06, 2016 at 06:40:44PM -0500, Joshua Haase wrote: > > - `!` operator only works when visual selection is active (visual mode). It can be used like any other operator. It will create a selection for the range it was applied to, switch to visual mode and open a command prompt defaulting

Re: [dev] structural regular expression support for vis

2016-04-13 Thread Marc André Tanner
On Tue, Apr 12, 2016 at 11:29:08AM -0700, Suraj N. Kurapati wrote: > On Wed, 06 Apr 2016 18:45:57 -0500, Joshua Haase wrote: > > Marc André Tanner writes: > > > you do not have to prefix your sam command with `ggvG` because > > > in normal mode it will by default be applied to the whole file. >

Re: [dev] structural regular expression support for vis

2016-04-12 Thread Suraj N. Kurapati
On Wed, 06 Apr 2016 18:45:57 -0500, Joshua Haase wrote: > Marc André Tanner writes: > > you do not have to prefix your sam command with `ggvG` because > > in normal mode it will by default be applied to the whole file. > > Or you could use `:,` to mean the whole file (i. e. `:,y/\n/i/FOO`). Or

Re: [dev] structural regular expression support for vis

2016-04-06 Thread Joshua Haase
Marc André Tanner writes: > On Sun, Mar 13, 2016 at 11:07:49AM +, Raphaël Proust wrote: >> `ggvG:sam y/\n/i/FOO` only inserts "FOO" at the start of the first >> line. It should do it on every line. >> Same when using `x/^.*$/` instead of `y/\n/` > > These should now also work. By the way you

Re: [dev] structural regular expression support for vis

2016-04-06 Thread Joshua Haase
Marc André Tanner writes: > On Wed, Apr 06, 2016 at 01:07:10PM -0500, Joshua Haase wrote: > We have to be somewhat careful with the nomenclature here. There currently > exists both a vi operator `!` (filter) and a sam command `!` (launch > interactive program). The former is implemented in terms

Re: [dev] structural regular expression support for vis

2016-04-06 Thread Marc André Tanner
On Wed, Apr 06, 2016 at 01:07:10PM -0500, Joshua Haase wrote: > sam features work generally fine, just a few notes: > > - Since commit ab2d1ddd0 the `!` command stopped working (did bisect), > but the command is still in the documentation and default config file. > > > The commit f47ecc3518e2

Re: [dev] structural regular expression support for vis

2016-04-06 Thread Joshua Haase
Marc André Tanner writes: > On Mon, Apr 04, 2016 at 01:32:01PM +0200, Marc André Tanner wrote: >> Hence it would probably be a good time to get some more testing feedback > > I merged the sam branch into master, hope this facilitates testing > and encourages more people to give it a try ... > >

Re: [dev] structural regular expression support for vis

2016-04-05 Thread Marc André Tanner
On Mon, Apr 04, 2016 at 01:32:01PM +0200, Marc André Tanner wrote: > Hence it would probably be a good time to get some more testing feedback I merged the sam branch into master, hope this facilitates testing and encourages more people to give it a try ... http://repo.or.cz/w/vis.git https://gi

Re: [dev] structural regular expression support for vis

2016-04-04 Thread Marc André Tanner
On Mon, Mar 28, 2016 at 06:46:40PM +0100, Connor Lane Smith wrote: > Just a config issue I suppose, but I kept quitting the editor by > accident, having typed 'x/foo/' without ':sam' in front of it. Over the last couple of days I integrated the existing vis commands into sam's command language. Me

Re: [dev] structural regular expression support for vis

2016-03-28 Thread Marc André Tanner
On Mon, Mar 28, 2016 at 06:46:40PM +0100, Connor Lane Smith wrote: > On 27 March 2016 at 17:10, Marc André Tanner wrote: > > You could also try `make local` which might or might not work ... > > It didn't. Anyway, today I unfortunately found myself with nowt but a > Mac, though I did manage to ge

Re: [dev] structural regular expression support for vis

2016-03-28 Thread Connor Lane Smith
On 28 March 2016 at 18:47, Connor Lane Smith wrote: > On 28 March 2016 at 18:46, Connor Lane Smith wrote: >> Diff attached, if you're interested. > > For real this time. I also just discovered that it does manage to compile without those changes if you run ./configure first. Sorry for the noise,

Re: [dev] structural regular expression support for vis

2016-03-28 Thread Connor Lane Smith
On 28 March 2016 at 18:46, Connor Lane Smith wrote: > Diff attached, if you're interested. For real this time. diff --git a/Makefile b/Makefile index 97adf0d..7b7d4cb 100644 --- a/Makefile +++ b/Makefile @@ -12,8 +12,8 @@ CONFIG_LUA ?= 1 CONFIG_ACL ?= 0 CONFIG_SELINUX ?= 0 -CFLAGS_STD ?= -std

Re: [dev] structural regular expression support for vis

2016-03-28 Thread Connor Lane Smith
On 27 March 2016 at 17:10, Marc André Tanner wrote: > You could also try `make local` which might or might not work ... It didn't. Anyway, today I unfortunately found myself with nowt but a Mac, though I did manage to get vis to compile. I had to make a couple of changes to get it to work. Diff a

Re: [dev] structural regular expression support for vis

2016-03-27 Thread Marc André Tanner
On Sun, Mar 27, 2016 at 01:37:02PM +0100, Connor Lane Smith wrote: > Hi Marc, > > On 27 March 2016 at 09:16, Marc André Tanner wrote: > > Did anyone else participating in this thread (Connor?, Greg?) bother > > to give it a try? > > Sorry, it's on my to-do list, but I had some trouble compiling

Re: [dev] structural regular expression support for vis

2016-03-27 Thread Greg Reagle
> On 27 March 2016 at 09:16, Marc André Tanner wrote: > > Did anyone else participating in this thread (Connor?, Greg?) bother > > to give it a try? I did not because I don't know vi. I usually use Emacs and sometimes nano. I learned sam recently. Well, I've looked at vi before but I just don'

Re: [dev] structural regular expression support for vis

2016-03-27 Thread Connor Lane Smith
Hi Marc, On 27 March 2016 at 09:16, Marc André Tanner wrote: > Did anyone else participating in this thread (Connor?, Greg?) bother > to give it a try? Sorry, it's on my to-do list, but I had some trouble compiling and haven't got around to giving it another go. It seems there's a new dependency

Re: [dev] structural regular expression support for vis

2016-03-27 Thread Marc André Tanner
On Sun, Mar 13, 2016 at 01:55:06PM +0100, Marc André Tanner wrote: > On Sun, Mar 13, 2016 at 11:07:49AM +, Raphaël Proust wrote: > > There are many bugs related to addressing and such. > > Please report more examples of the bugs you encountered. So which are the most annoying ones? Did anyon

Re: [dev] structural regular expression support for vis

2016-03-13 Thread Marc André Tanner
On Sun, Mar 13, 2016 at 11:07:49AM +, Raphaël Proust wrote: > `ggvG:sam y/\n/i/FOO` only inserts "FOO" at the start of the first > line. It should do it on every line. > Same when using `x/^.*$/` instead of `y/\n/` These should now also work. By the way you do not have to prefix your sam comma

Re: [dev] structural regular expression support for vis

2016-03-13 Thread Marc André Tanner
First of all, thanks for giving it a try! On Sun, Mar 13, 2016 at 11:07:49AM +, Raphaël Proust wrote: > On 12 March 2016 at 17:44, Marc André Tanner wrote: > > On Fri, Mar 11, 2016 at 08:08:38PM +0100, Marc André Tanner wrote: > >> - There will likely be bugs, memory leaks, crashes, infinite

Re: [dev] structural regular expression support for vis

2016-03-13 Thread Raphaël Proust
On 12 March 2016 at 17:44, Marc André Tanner wrote: > On Fri, Mar 11, 2016 at 08:08:38PM +0100, Marc André Tanner wrote: >> - There will likely be bugs, memory leaks, crashes, infinite loops etc. >>YOU are supposed to fix them and submit patches ;) When typing `:sam` the editor segfaults. I'

Re: [dev] structural regular expression support for vis

2016-03-13 Thread Jan Christoph Ebersbach
Not yet, I have it on my agenda for May. On Sat 12-03-2016 18:44 +0100, Marc André Tanner wrote: > On Fri, Mar 11, 2016 at 08:08:38PM +0100, Marc André Tanner wrote: > > > - There will likely be bugs, memory leaks, crashes, infinite loops > > etc. YOU are supposed to fix them and submit patches

Re: [dev] structural regular expression support for vis

2016-03-12 Thread Marc André Tanner
On Fri, Mar 11, 2016 at 08:08:38PM +0100, Marc André Tanner wrote: > - There will likely be bugs, memory leaks, crashes, infinite loops etc. >YOU are supposed to fix them and submit patches ;) A particularly embarrassing one, preventing the use of multiple regular expressions in the same comm

[dev] structural regular expression support for vis

2016-03-11 Thread Marc André Tanner
On Tue, Mar 01, 2016 at 05:23:11PM +, Connor Lane Smith wrote: > On 1 March 2016 at 17:12, Marc André Tanner wrote: > > I think structural regexp will integrate nicely with multiple selections. > > > > Basically if you omit the command of a structural regexp the editor > > would switch to visu