Re: [dev] [st] Use after free in font cache

2017-08-28 Thread Laslo Hunhold
On Sun, 27 Aug 2017 21:58:39 -0300 dequis wrote: Hey dequis, > Hi, got some crashes. Looks like st is calling XftFontClose in the > last member of the font cache array when it runs out of space in it, > but that xft font is still used somewhere else. maybe this is the issue that we get so many

[dev] [st] Use after free in font cache

2017-08-27 Thread dequis
Hi, got some crashes. Looks like st is calling XftFontClose in the last member of the font cache array when it runs out of space in it, but that xft font is still used somewhere else. To reproduce: 1. Make the font cache array smaller, in x.c "static Fontcache frc[1];" 2. wget https://www.cl.cam.

Re: [dev] st: Use after free

2017-01-22 Thread moosotc
Hiltjo Posthuma writes: > On Sun, Jan 22, 2017 at 11:00:28PM +0300, moos...@gmail.com wrote: >> Martin Kühne writes: >> >> > On Sun, Jan 22, 2017 at 5:17 PM, wrote: >> >> >> >> `valgrind st -f mono-2 cat full-bmp.txt' [1] >> >> >> >> Yields quite a few invalid reads from freed blocks, the iss

Re: [dev] st: Use after free

2017-01-22 Thread Hiltjo Posthuma
On Sun, Jan 22, 2017 at 11:00:28PM +0300, moos...@gmail.com wrote: > Martin Kühne writes: > > > On Sun, Jan 22, 2017 at 5:17 PM, wrote: > >> > >> `valgrind st -f mono-2 cat full-bmp.txt' [1] > >> > >> Yields quite a few invalid reads from freed blocks, the issue is related > >> to cache managem

Re: [dev] st: Use after free

2017-01-22 Thread moosotc
Martin Kühne writes: > On Sun, Jan 22, 2017 at 5:17 PM, wrote: >> >> `valgrind st -f mono-2 cat full-bmp.txt' [1] >> >> Yields quite a few invalid reads from freed blocks, the issue is related >> to cache management. In the real world those dangling pointer issues >> lead to segfaults or X11 er

Re: [dev] st: Use after free

2017-01-22 Thread Martin Kühne
On Sun, Jan 22, 2017 at 5:17 PM, wrote: > > `valgrind st -f mono-2 cat full-bmp.txt' [1] > > Yields quite a few invalid reads from freed blocks, the issue is related > to cache management. In the real world those dangling pointer issues > lead to segfaults or X11 errors (eventually) > I think y

[dev] st: Use after free

2017-01-22 Thread moosotc
`valgrind st -f mono-2 cat full-bmp.txt' [1] Yields quite a few invalid reads from freed blocks, the issue is related to cache management. In the real world those dangling pointer issues lead to segfaults or X11 errors (eventually) [1] http://www.cl.cam.ac.uk/~mgk25/ucs/full-bmp.txt -- mailto: