Re: [dev] Re: [st] multibyte patch

2010-11-20 Thread Aurélien Aptel
On Sat, Nov 20, 2010 at 6:24 PM, Damian Okrasa wrote: > I forgot to hg diff, here's the correct one. Ok. > I've attached changed version, it looks simpler. There are some other > changes too, font loading code. I'm not sure if the line drawing is > needed in xdraws() since unicode has some box d

Re: [dev] Re: [st] multibyte patch

2010-11-20 Thread Damian Okrasa
I forgot to hg diff, here's the correct one. st-fix.diff Description: Binary data

Re: [dev] Re: [st] multibyte patch

2010-11-20 Thread Damian Okrasa
2010/11/19, Hiltjo Posthuma : > I noticed in canstou(): > >329 /* use this if your buffer is less than UTF_SIZ, it returns 1 > if you can decode >330UTF-8 otherwise return 0 */ >331 static int canstou(char *s, int b) { >332unsigned char c = *s; >333int n; >

Re: [dev] Re: [st] multibyte patch

2010-11-19 Thread Aurélien Aptel
On Fri, Nov 19, 2010 at 2:38 PM, Hiltjo Posthuma wrote: > Offtopic and not specificly aimed at you: > I noticed the coding style of st is quite ugly. Lots of > non-descriptive variable names, recurring logic which could be grouped > in a function. Inconsistent. One can take an example to look at d

Re: [dev] Re: [st] multibyte patch

2010-11-19 Thread Hiltjo Posthuma
On Sat, Nov 13, 2010 at 10:53 PM, Damian Okrasa wrote: > I removed the wchar_t completely, added some UTF-8  parsing functions. > No support for combining, bidi, doublecolumn etc. Markus Kuhn's UTF-8 > stress test file is not working 100% correctly (the decoder works > however, even when reading b

Re: [dev] Re: [st] multibyte patch

2010-11-14 Thread cryptix
Hi, On 13.11.2010, at 22:53, Damian Okrasa wrote: > I removed the wchar_t completely, ... great! After a small adaption it seems to work flawlessly. In the form you posted, my compiler doesn't like the first constant B0. st.c:65:8: error: expected identifier before numeric constant Once I chang

Re: [dev] Re: [st] multibyte patch

2010-11-13 Thread Uriel
On Sat, Nov 13, 2010 at 10:53 PM, Damian Okrasa wrote: > I removed the wchar_t completely, added some UTF-8  parsing functions. Cool! > No support for combining, bidi, doublecolumn etc. I hope it stays that way, all those things are truly insane and do not belong on any terminal. uriel

[dev] Re: [st] multibyte patch

2010-11-13 Thread Damian Okrasa
I removed the wchar_t completely, added some UTF-8 parsing functions. No support for combining, bidi, doublecolumn etc. Markus Kuhn's UTF-8 stress test file is not working 100% correctly (the decoder works however, even when reading bytes one by one). diff -r 288747c60bc1 config.def.h --- a/config