Re: [dev] Re: [dvtm] buffered text on resize

2010-10-08 Thread Niki Yoshiuchi
I've been using your patch pretty heavily and everything seems to be working. On Fri, Oct 8, 2010 at 7:09 AM, Marc Andre Tanner wrote: > Niki Yoshiuchi wrote: > >> Thanks! I just installed the patch and I will let you know if I still see >> any garbage data. >> > > Have you already tested it? It

Re: [dev] Re: [dvtm] buffered text on resize

2010-10-08 Thread Marc Andre Tanner
Niki Yoshiuchi wrote: Thanks! I just installed the patch and I will let you know if I still see any garbage data. Have you already tested it? It seems ok, here. If there are no complaints I will push out a release sometime this weekend. Thanks, Marc -- Marc Andre Tanner >< http://www.brain-

Re: [dev] Re: [dvtm] buffered text on resize

2010-10-01 Thread Niki Yoshiuchi
Thanks! I just installed the patch and I will let you know if I still see any garbage data. On Fri, Oct 1, 2010 at 11:42 AM, Marc Andre Tanner wrote: > On Sun, Sep 26, 2010 at 02:22:50AM -0400, Niki Yoshiuchi wrote: > > I would absolutely love to see text reflowing but I think that would be > >

Re: [dev] Re: [dvtm] buffered text on resize

2010-10-01 Thread Marc Andre Tanner
On Sun, Sep 26, 2010 at 02:22:50AM -0400, Niki Yoshiuchi wrote: > I would absolutely love to see text reflowing but I think that would be > pretty difficult with the way that text is currently handled by dvtm. Yeah probably isn't trivial to implement, but to be honest I don't really need it. $EDIT

Re: [dev] Re: [dvtm] buffered text on resize

2010-09-25 Thread Niki Yoshiuchi
I would absolutely love to see text reflowing but I think that would be pretty difficult with the way that text is currently handled by dvtm. By the way, there is a small bug (feature?) in my patch. It will sometimes show old bits of text after a resize, since the extra buffer space hasn't been z

Re: [dev] Re: [dvtm] buffered text on resize

2010-09-25 Thread Marc Andre Tanner
On Fri, Sep 10, 2010 at 12:57:09AM -0400, Niki Yoshiuchi wrote: > There is a serious bug in my patch that can cause dvtm to crash which > I have fixed. After the calls to realloc there are calls to calloc > which were still using the cols field instead of maxcols, so there was > a potential buffer

Re: [dev] Re: [dvtm] buffered text on resize

2010-09-09 Thread Niki Yoshiuchi
There is a serious bug in my patch that can cause dvtm to crash which I have fixed. After the calls to realloc there are calls to calloc which were still using the cols field instead of maxcols, so there was a potential buffer overflow (if you only used the tile and monocle modes you wouldn't run

Re: [dev] Re: [dvtm] buffered text on resize

2010-09-09 Thread Niki Yoshiuchi
Thanks! :) And I realized that my patch is fine. I couldn't compile it at work, but then I remembered that I couldn't compile dvtm using c99 at work because our Linux box has an outdated version of glibc. I had to switch to c89 and edit all the for loops. On Thu, Sep 9, 2010 at 5:20 PM, Nikhile

Re: [dev] Re: [dvtm] buffered text on resize

2010-09-09 Thread Nikhilesh S
On Thu, Sep 09, 2010 at 02:02:10PM -0700, Suraj Kurapati wrote: > On 9/8/10, Niki Yoshiuchi wrote: > > even a Gnome user should be able to figure out how to fix it. > > Haha, well said, that quote is an instant classic! :-) I have witnessed a classic in the making. :O -- Nikhilesh S http://www

Re: [dev] Re: [dvtm] buffered text on resize

2010-09-09 Thread Suraj Kurapati
On 9/8/10, Niki Yoshiuchi wrote: > even a Gnome user should be able to figure out how to fix it. Haha, well said, that quote is an instant classic! :-)

[dev] Re: [dvtm] buffered text on resize

2010-09-08 Thread Niki Yoshiuchi
Whoops, looks like my patch won't compile if you are using strict C - I declared an int in a for loop (forced habit, I work in C++ all day). When I get home from work tonight I'll update the patch but even a Gnome user should be able to figure out how to fix it. On Wed, Sep 8, 2010 at 12:41 AM, N