Re: [dev] [st PATCH 3/4] Use != instead of ^ for logical values.

2014-04-25 Thread Roberto E. Vargas Caballero
> - if(sel.alt ^ IS_SET(MODE_ALTSCREEN)) > + if(sel.alt != IS_SET(MODE_ALTSCREEN)) This bit logical operation comes from another age when IS_SET had not a comparision operator. It does not make sense anymore, so this change is good. Regards, -- Roberto E. Vargas Caballero

[dev] [st PATCH 3/4] Use != instead of ^ for logical values.

2014-04-23 Thread noname
sel.alt is only changed by sel.alt = IS_SET(MODE_ALTSCREEN); --- st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st.c b/st.c index 07f408c..e61ee68 100644 --- a/st.c +++ b/st.c @@ -3449,7 +3449,7 @@ drawregion(int x1, int y1, int x2, int y2) { bool ena_sel