Re: [dev] [st PATCH] Simplify tputtab.

2014-04-28 Thread koneu
Roberto E. Vargas Caballero wrote: > But I feel that the patch is a bit confusing. I use sometime this kind > of expressions (for example (!(p = f()) || p != q), and I get confussed > here, so maybe it is not a good idea. If another suckless developers think > the patch should be applied then I wil

Re: [dev] [st PATCH] Simplify tputtab.

2014-04-28 Thread Roberto E. Vargas Caballero
Upss, you are rigth. > && is a sequence point > > According to ISO IEC 9899:1999: > """ > The following are the sequence points described in 5.1.2.3: > ... > - The end of the first operand of the following operators: logical AND > && (6.5.13); logical OR || (6.5.14); conditional ? (6.5.15); co

Re: [dev] [st PATCH] Simplify tputtab.

2014-04-28 Thread noname
On Mon, Apr 28, 2014 at 10:54:21AM +0200, Roberto E. Vargas Caballero wrote: > > - for(++x; x < term.col && !term.tabs[x]; ++x) > > + while(++x < term.col && !term.tabs[x]) > ... > > - for(--x; x > 0 && !term.tabs[x]; --x) > > +

Re: [dev] [st PATCH] Simplify tputtab.

2014-04-28 Thread Roberto E. Vargas Caballero
> - for(++x; x < term.col && !term.tabs[x]; ++x) > + while(++x < term.col && !term.tabs[x]) ... > - for(--x; x > 0 && !term.tabs[x]; --x) > + while(--x > 0 && !term.tabs[x]) I'm sorry, but this patch is incorrect, beca

[dev] [st PATCH] Simplify tputtab.

2014-04-27 Thread noname
--- st.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/st.c b/st.c index 2750bfa..689dce0 100644 --- a/st.c +++ b/st.c @@ -2267,11 +2267,11 @@ tputtab(int n) { if(n > 0) { while(x < term.col && n--) - for(++x; x < term.col &