Re: [dev] [st PATCH] Simplify tdeftran.

2014-06-02 Thread Roberto E. Vargas Caballero
This patch (and anothers from nonamed) is waiting a reply from nonamed. If in the next days there is not a reply I will apply the modifications that I considerer better. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH] Simplify tdeftran.

2014-05-02 Thread Roberto E. Vargas Caballero
Idea behind tdeftran is allowing to users create new charsets if they want, and it is the reason why it is built as a data driven function. I don't think is a good idea implement a lookup table using a switch statement, but it is true that it can be written better. What do you think about this imp

[dev] [st PATCH] Simplify tdeftran.

2014-04-30 Thread noname
--- st.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/st.c b/st.c index d0c4595..3f248f3 100644 --- a/st.c +++ b/st.c @@ -2305,19 +2305,17 @@ techo(char *buf, int len) { void tdeftran(char ascii) { - char c, (*bp)[2]; - static char tb