Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-15 Thread Roberto E. Vargas Caballero
On Fri, Jun 12, 2015 at 09:43:41PM +0200, Quentin Rameau wrote: > > The font size is actually a double and can have non-integer values when > > fonts are specified in point size instead of pixel size. Update zoom > > functions to preserve the fractional component in a float. Some small > > precisio

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Eric Pruitt
On Fri, Jun 12, 2015 at 10:00:45PM +0200, FRIGN wrote: > On Fri, 12 Jun 2015 11:34:26 -0700 > > Added Google to the LICENSE to the copyright list to meet our legal > > requirements. > > we had this discussion before and the reasons have already been told. > Adding a company to a license is a risk w

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Matthew Wesley
On Fri, Jun 12, 2015 at 2:20 PM, Dimitris Papastamos wrote: > Can you not get an exemption from your employer so you can freely contribute > to this project under your own name? It's possible, but does require more review. Given the trivial nature of my patch, and the fact that Quentin already pr

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Dimitris Papastamos
On Fri, Jun 12, 2015 at 01:22:08PM -0700, Matthew Wesley wrote: > On Fri, Jun 12, 2015 at 1:00 PM, FRIGN wrote: > > we had this discussion before and the reasons have already been told. > > Adding a company to a license is a risk we won't take. > > We prefer to deny these patches in favor of stayi

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Matthew Wesley
On Fri, Jun 12, 2015 at 1:00 PM, FRIGN wrote: > we had this discussion before and the reasons have already been told. > Adding a company to a license is a risk we won't take. > We prefer to deny these patches in favor of staying away from possible > risks of this nature, so please either commit th

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread FRIGN
On Fri, 12 Jun 2015 11:34:26 -0700 Matthew Wesley wrote: Hey Matthew, > Added Google to the LICENSE to the copyright list to meet our legal > requirements. we had this discussion before and the reasons have already been told. Adding a company to a license is a risk we won't take. We prefer to d

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Matthew Wesley
On Fri, Jun 12, 2015 at 11:58 AM, Evan Gates wrote: > In most cases authors of small patches are not added to the LICENSE of > suckless projects. > -emg Understandable, given the number of contributors of 3-line changes. I've confirmed the corporate requirement for such a copyright line, however.

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Evan Gates
On Fri, Jun 12, 2015 at 11:56 AM, Matthew Wesley wrote: > Can you provide some of the history? Nothing in the st commit history > showed a previous Google contribution. If previous patches were able > to get through without a Google entry in LICENSE, I may be able to > take that precedent to our o

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Matthew Wesley
Can you provide some of the history? Nothing in the st commit history showed a previous Google contribution. If previous patches were able to get through without a Google entry in LICENSE, I may be able to take that precedent to our open source team. On Fri, Jun 12, 2015 at 11:51 AM, Lee Fallat w

Re: [dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Lee Fallat
On Fri, Jun 12, 2015 at 2:34 PM, Matthew Wesley wrote: > > Added Google to the LICENSE to the copyright list to meet our legal > requirements. > --- > LICENSE | 1 + > st.c| 6 +++--- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/LICENSE b/LICENSE > index 1be82da..69ede9

[dev] [st][PATCH] Preserve pixelsize fractions in font defaultsize.

2015-06-12 Thread Matthew Wesley
The font size is actually a double and can have non-integer values when fonts are specified in point size instead of pixel size. Update zoom functions to preserve the fractional component in a float. Some small precision is lost, but the zoom reset function gets very close to the original size and