Re: [dev] [slock] [PATCH] Ctrl-u now resets the input

2016-06-10 Thread Troy Sankey
On 2016-06-08 03:55:38 -0400, Anselm R Garbe wrote: > Hi Troy, > > I'm not sure if this feature is really required. Typing a wrong > password can be corrected on second attempt anyways. True, and I know this well. However, muscle memory trumps logic, and I end up typing Ctrl-u every day a couple

Re: [dev] [slock] [PATCH] Ctrl-u now resets the input

2016-06-08 Thread Hugo Peixoto
On Wed, Jun 8, 2016 at 8:55 AM, Anselm R Garbe wrote: > Hi Troy, > > I'm not sure if this feature is really required. Typing a wrong > password can be corrected on second attempt anyways. > > What is the opinion of other users to this change? Usually I press some random keys just to wake up the s

Re: [dev] [slock] [PATCH] Ctrl-u now resets the input

2016-06-08 Thread Markus Teich
Anselm R Garbe wrote: > I'm not sure if this feature is really required. Typing a wrong password can > be corrected on second attempt anyways. > > What is the opinion of other users to this change? Heyho, I also don't think adding this patch to mainline is neccessary. You can still put it on the

Re: [dev] [slock] [PATCH] Ctrl-u now resets the input

2016-06-08 Thread Dimitris Papastamos
On Wed, Jun 08, 2016 at 09:55:38AM +0200, Anselm R Garbe wrote: > Hi Troy, > > I'm not sure if this feature is really required. Typing a wrong > password can be corrected on second attempt anyways. > > What is the opinion of other users to this change? I don't think it is necessary for slock. I

Re: [dev] [slock] [PATCH] Ctrl-u now resets the input

2016-06-08 Thread David Phillips
On Wed, Jun 08, 2016 at 09:55:38AM +0200, Anselm R Garbe wrote: > Hi Troy, > > I'm not sure if this feature is really required. Typing a wrong > password can be corrected on second attempt anyways. > > What is the opinion of other users to this change? > > BR, > Anselm Personally speaking, I wo

Re: [dev] [slock] [PATCH] Ctrl-u now resets the input

2016-06-08 Thread Anselm R Garbe
Hi Troy, I'm not sure if this feature is really required. Typing a wrong password can be corrected on second attempt anyways. What is the opinion of other users to this change? BR, Anselm On 5 June 2016 at 23:22, Troy Sankey wrote: > Before this commit, only pressing Escape would reset the inp

[dev] [slock] [PATCH] Ctrl-u now resets the input

2016-06-05 Thread Troy Sankey
Before this commit, only pressing Escape would reset the input. This commit makes Ctrl-u do the same. Rationale: it more closely mimics behavior of login(1)/getpass(3). --- slock.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/slock.c b/slock.c index c9cdee2..c3c3ebc 1