Re: [dev] [sbase] [test] [patch] fix specific 3 argument case

2014-10-16 Thread Dimitris Papastamos
Applied thanks! Can you use git format-patch in the future? Also make sure that you use tabs instead of spaces for indentation. Generally speaking we use tabs for indentation and spaces for alignment. Cheers, sin

[dev] [sbase] [test] [patch] fix specific 3 argument case

2014-10-15 Thread Evan Gates
After writing my own test[0] I checked and sbase already has test. I'm including a patch to remove test from the TODO. I also noticed that sbase's test handles a few specific cases incorrectly (documentation at [1]). test ! = foo When there are 3 arguments and the second is a valid binary primary