Re: [dev] [sbase] [patch v3] Add sum.[ch] and update md5sum and sha1sum

2013-07-12 Thread sin
On Fri, Jul 12, 2013 at 09:56:21AM -0500, Galos, David wrote: > > Renamed from crypt to sum. > I think crypt was a good name. cryptsum made sense as a function, > I think that printing should be removed from cryptsum, though. > Another function, cryptprint (or mdprint) could take a digest, and > a

Re: [dev] [sbase] [patch v3] Add sum.[ch] and update md5sum and sha1sum

2013-07-12 Thread Galos, David
> Renamed from crypt to sum. I think crypt was a good name. cryptsum made sense as a function, I think that printing should be removed from cryptsum, though. Another function, cryptprint (or mdprint) could take a digest, and a length. I believe this is a better separation of concerns. v2 was good

[dev] [sbase] [patch v3] Add sum.[ch] and update md5sum and sha1sum

2013-07-12 Thread sin
Hi, Renamed from crypt to sum. Thanks, stateless >From be2fbf8c8cb6ec434ad2d65ac3eeaf8882c60d77 Mon Sep 17 00:00:00 2001 From: sin Date: Sun, 7 Jul 2013 15:29:45 +0100 Subject: [PATCH] Add sum.[ch] and update md5sum and sha1sum Factor out the code from md5sum and sha1sum into a util function.