> Why not just post your work to the list, so it can be reviewed, instead of
> just thinking about adding it?
> You probably will learn better this way. ;)
I need to find my work first ;) It's in a hard drive somewhere.
For now, I will add sltar into sbase, submitting my changes as a patch
later.
Oh, and you should add tar using sltar as a base.
I actually worked on sltar, adding create support. At the
same time, I wrote a cleaner struct-based version, which
I am thinking about adding.
Why not just post your work to the list, so it can be reviewed, instead
of just thinking about adding
> The types array stood out to me as a bit of a code smell.
> After pondering over it for a couple of minutes, I realized
> that you could just do this:
>
> type = argv[1][0] == 'b' ? S_IFBLK : S_IFCHR;
After some thought, I am inclined to agree. This has been
changed.
> Oh, and you should add tar
The types array stood out to me as a bit of a code smell.
After pondering over it for a couple of minutes, I realized
that you could just do this:
type = argv[1][0] == 'b' ? S_IFBLK : S_IFCHR;
-Truls
Quoth Galos, David:
> P.S. As a matter of list etiquette, I'm not sure whether this
> announcement is considered appropriate. I want to give
> folks a chance to comment on my changes, but perhaps
> I am supposed to count on people being subscribed to
> [hackers].
I like reading the code here :)
T
I have just applied the attached patch, adding the mknod(1)
command and manpage to sbase.
Enjoy!
P.S. As a matter of list etiquette, I'm not sure whether this
announcement is considered appropriate. I want to give
folks a chance to comment on my changes, but perhaps
I am supposed to count on peop
