Re: [dev] [sbase] [patch] Add primitive du(1)

2013-10-16 Thread sin
On Wed, Oct 16, 2013 at 07:12:06PM +0200, Roberto E. Vargas Caballero wrote: > > > > Functions push() and pop() seem to only be used once each. > > Would it be too bad to have these few lines directly in the du function? > > I don't agree here, because I think the code is more clear with them.

Re: [dev] [sbase] [patch] Add primitive du(1)

2013-10-16 Thread Roberto E. Vargas Caballero
> Moving main() to the bottom and usage() to the top would eliminate the > need to declare them. I agree here. > > Functions push() and pop() seem to only be used once each. > Would it be too bad to have these few lines directly in the du function? I don't agree here, because I think the code

Re: [dev] [sbase] [patch] Add primitive du(1)

2013-10-16 Thread sin
On Wed, Oct 16, 2013 at 06:47:26PM +0200, Truls Becken wrote: > A few trivial comments: > > Moving main() to the bottom and usage() to the top would eliminate the > need to declare them. Sure. > Functions push() and pop() seem to only be used once each. > Would it be too bad to have these few

Re: [dev] [sbase] [patch] Add primitive du(1)

2013-10-16 Thread Truls Becken
A few trivial comments: Moving main() to the bottom and usage() to the top would eliminate the need to declare them. Functions push() and pop() seem to only be used once each. Would it be too bad to have these few lines directly in the du function? The switch in du would be slightly simpler a

[dev] [sbase] [patch] Add primitive du(1)

2013-10-16 Thread sin
Any comments are highly appreciated :) >From 42074179d48dd9b84c120cb849a6a8e23f96f943 Mon Sep 17 00:00:00 2001 From: sin Date: Wed, 16 Oct 2013 16:58:52 +0100 Subject: [PATCH] Add primitive du(1) Defaults to a 512-byte blocksize. --- Makefile | 1 + du.1 | 18 ++ du.c | 123 ++