Re: [dev] [sbase] [PATCH] Add join utility.

2015-02-16 Thread Jeffrey Picard
Thanks for the comments! I’ll submit an updated patch in a day or two. With regards to the oflag, I just haven’t implemented it yet. I’ll try to include it in the next patch. > On Feb 16, 2015, at 5:27 AM, Dimitris Papastamos wrote: > > Some inline comments below: > > +/* See LICENSE file for

Re: [dev] [sbase] [PATCH] Add join utility.

2015-02-16 Thread Dimitris Papastamos
Some inline comments below: +/* See LICENSE file for copyright and license details. */ +#include +#include +#include +#include Sort these. +static int tflag = 0; +static int aflag = 0; +static int eflag = 0; +/*static int oflag = 0;*/ +static int oneflag = 0; +static int twoflag = 0; oflag

Re: [dev] [sbase] [PATCH] Add join utility.

2015-02-16 Thread Dimitris Papastamos
Hi there, Thanks! Can you also provide the manpage for join? Refer to the existing manpages on how to format it. Cheers, Dimitris

[dev] [sbase] [PATCH] Add join utility.

2015-02-16 Thread Jeffrey Picard
Hey all, I’ve implemented a version of the join utility for sbase. The run times and memory usage are comparable to the gnu join, which I tested against. I’ve attached my testing script along with the patch. So far I have a decent subset of the options (-t,-1,-2,-e,-a). —Jeffrey Picard 0001-