On Sun, Jul 03, 2016 at 06:55:40PM +0200, Markus Teich wrote:
> you should shift the declarations above the updatenumlockmask() call acording
> to
> "Do not mix declarations and code" from http://suckless.org/coding_style. The
> same for the second removed pair of braces.
An updated patch is atta
Eric Pruitt wrote:
> @@ -944,40 +944,36 @@ void
> grabbuttons(Client *c, int focused)
> {
> updatenumlockmask();
> - {
> - unsigned int i, j;
> - unsigned int modifiers[] = { 0, LockMask, numlockmask,
> numlockmask|LockMask };
> …
> + unsigned int i, j;
> +
In dwm, I noticed there are two superfluous scoping blocks in
grabbuttons and grabkeys. I'm assuming they were added because they were
required for C89, but since dwm is compiled with -std=c99 by default, I
don't think they're necessary anymore. I've attached a patch to remove
them.
Eric
>From e3d
