Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-16 Thread Kurt Van Dijck
> > Hi Matthew, > > >I believe that your patches could be useful to a few who also prefer > >the relative to 1CPU point of view. > > Yes, exactly. > > >Though they may not be part of slstatus proper, you could always make > >and maintain the patches for them in the patches directory on the > >s

Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-16 Thread Kurt Van Dijck
> Hi, > > >Why do we need to get the number of cpus in runtime? It's a static value, > >which in worst case changes after a reboot when disabling hyperthreading. > > > >Also, using ncpu for more than one thing (first it's flag, then it's a > >number) is a really bad idea. > > > >I don't think thi

Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-16 Thread Kurt Van Dijck
> Hi Kurt, > > On 09/15/17 14:50, Kurt Van Dijck wrote: > > This runtime probe is only used when cpu usage is reported relative to 1cpu. > > The default case reports cpu usage relative to 100%, and not runtime > > cpu counting is required. > > > > Signed-off-by: Kurt Van Dijck > > --- ... > > S

Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-16 Thread Aaron Marcher
Hi Matthew, I believe that your patches could be useful to a few who also prefer the relative to 1CPU point of view. Yes, exactly. Though they may not be part of slstatus proper, you could always make and maintain the patches for them in the patches directory on the site, as with the other p

Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-16 Thread Matthew Parnell
Hi Kurt, I believe that your patches could be useful to a few who also prefer the relative to 1CPU point of view. Though they may not be part of slstatus proper, you could always make and maintain the patches for them in the patches directory on the site, as with the other projects. Cheers, --

Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-16 Thread Aaron Marcher
Hi, Why do we need to get the number of cpus in runtime? It's a static value, which in worst case changes after a reboot when disabling hyperthreading. Also, using ncpu for more than one thing (first it's flag, then it's a number) is a really bad idea. I don't think this should be merged,

Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-15 Thread Lucas Gabriel Vuotto
Hi Kurt, On 09/15/17 14:50, Kurt Van Dijck wrote: > This runtime probe is only used when cpu usage is reported relative to 1cpu. > The default case reports cpu usage relative to 100%, and not runtime > cpu counting is required. > > Signed-off-by: Kurt Van Dijck > --- > config.def.h | 7 ---

[dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

2017-09-15 Thread Kurt Van Dijck
This runtime probe is only used when cpu usage is reported relative to 1cpu. The default case reports cpu usage relative to 100%, and not runtime cpu counting is required. Signed-off-by: Kurt Van Dijck --- config.def.h | 7 --- slstatus.c | 17 + 2 files changed, 21 insert