Re: [dev] [PATCH] Move default rows, cols to config.def.h

2014-07-04 Thread Alexander S.
2014-06-25 21:00 GMT+04:00 Roberto E. Vargas Caballero : >> > is this really necessary? Default constants don't really mean >> > anything, they persist literally until the window is mapped and the >> > text buffer is resized at >> (apologies for accidentally sending) >> L3726, so if anything, I'd v

Re: [dev] [PATCH] Move default rows, cols to config.def.h

2014-06-25 Thread Roberto E. Vargas Caballero
> > is this really necessary? Default constants don't really mean > > anything, they persist literally until the window is mapped and the > > text buffer is resized at > (apologies for accidentally sending) > L3726, so if anything, I'd vote for their removal, not their > canonicalization through co

Re: [dev] [PATCH] Move default rows, cols to config.def.h

2014-06-24 Thread Alexander S.
2014-06-25 3:42 GMT+04:00 Alexander S. : > 2014-06-25 1:51 GMT+04:00 Anders Eurenius : >> Move default rows, cols to config.def.h >> >> Add default_cols, default_rows as static ints in the config.def.h >> header, instead of using constants directly in the code. >> >> cheers >> aes > Gre

Re: [dev] [PATCH] Move default rows, cols to config.def.h

2014-06-24 Thread Alexander S.
2014-06-25 1:51 GMT+04:00 Anders Eurenius : > Move default rows, cols to config.def.h > > Add default_cols, default_rows as static ints in the config.def.h > header, instead of using constants directly in the code. > > cheers > aes Greetings, is this really necessary? Default constants

[dev] [PATCH] Move default rows, cols to config.def.h

2014-06-24 Thread Anders Eurenius
Move default rows, cols to config.def.h Add default_cols, default_rows as static ints in the config.def.h header, instead of using constants directly in the code. cheers aes From ba8a00c0c2b10b5b3224ce6c9f498e07352cec5d Mon Sep 17 00:00:00 2001 From: Anders Eurenius Date: Sat, 21 Jun