Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-21 Thread Roberto E. Vargas Caballero
> The patch mostly works for me, but it doesn't take into account the > cwscale and chscale character scaling factors, and this leads to a > glitchy moire-ish pattern in certain contexts (see attached > bug-example-1.png and bug-example-2.png). I've adjusted the XCopyArea > call (see attached patch

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-20 Thread Roberto E. Vargas Caballero
I can see the image in my linux laptop, but I cannot see anything in my OpenBSD server. W3mimgdisplay works perfectly in xterm in both machines, so I think there is something we are loosing in this problem. Maybe could be interesting read the mails that Christoph wrote some time ago about this issu

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-20 Thread Otto Modinos
> Have you tried clearing your terminal with ^L or clear first? I did try that and the result was the same. I also tried your iview script and still no picture. I guess there is something wrong with my particular setup, I don't know what though...

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-19 Thread Eric Pruitt
On Sun, Jan 19, 2014 at 07:40:48PM +0200, Otto Modinos wrote: > > Do note that you can't run w3mimgdisplay on its own. It requires some > > formatting options and the image file name to be passed into stdin. > > I know, I think I used the correct incantation (it worked on xterm) > but st showed not

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-19 Thread Otto Modinos
> Do note that you can't run w3mimgdisplay on its own. It requires some > formatting options and the image file name to be passed into stdin. I know, I think I used the correct incantation (it worked on xterm) but st showed nothing, not even the lines you see. Applying your patch I still get noth

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-19 Thread Otto Modinos
It doesn't work for me. When using it through ranger (set preview_images true) I get nothing. When using it on it's own it exits with exit code 1... On 16 January 2014 11:03, Roberto E. Vargas Caballero wrote: >> I changed how height of region to update is being calculated, it should >> work pr

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-16 Thread Roberto E. Vargas Caballero
> I changed how height of region to update is being calculated, it should > work properly now. I'll apply it. Thanks -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-11 Thread Amadeusz Sławiński
On Sat, 11 Jan 2014 12:35:19 +0100 "Roberto E. Vargas Caballero" wrote: > > Before this patch draw() calls drawregion which calls xdraws and > > then updates whole window in one call thus overdrawing anything > > drawn by w3mimgdisplay. After moving XCopyArea to xdraws it only > > updates the reg

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-11 Thread Roberto E. Vargas Caballero
> Before this patch draw() calls drawregion which calls xdraws and then > updates whole window in one call thus overdrawing anything drawn by > w3mimgdisplay. After moving XCopyArea to xdraws it only updates the > regions which are being updated by XftDraw* functions. It may do a few > more calls t

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-11 Thread Amadeusz Sławiński
> I like the idea of having this feature in st, and your patch is simple > because you only move a function from one place to another, but could > you explain a bit why moving the function from draw to xdraws makes > w3mimgdisplay work? Before this patch draw() calls drawregion which calls xdraws

Re: [dev] [PATCH] Make w3mimgdisplay work with st

2014-01-11 Thread Roberto E. Vargas Caballero
I like the idea of having this feature in st, and your patch is simple because you only move a function from one place to another, but could you explain a bit why moving the function from draw to xdraws makes w3mimgdisplay work? Regards, -- Roberto E. Vargas Caballero

[dev] [PATCH] Make w3mimgdisplay work with st

2014-01-10 Thread Amadeusz Sławiński
Signed-off-by: Amadeusz Sławiński --- st.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/st.c b/st.c index 4d543d1..714ce38 100644 --- a/st.c +++ b/st.c @@ -3301,6 +3301,8 @@ xdraws(char *s, Glyph base, int x, int y, int charlen, int bytelen) { XftDrawRe