Re: [dev] [PATCH] [sbase] printf: Avoid casts for better portability

2014-02-01 Thread FRIGN
On Sat, 1 Feb 2014 20:20:51 + sin wrote: > Would be nice! :) I did a raw run on the sbase-code with $grep -ri "printf" *.c but didn't observe more cases at first. However, I'll dig deeper and check other areas as well. Cheers FRIGN -- FRIGN

Re: [dev] [PATCH] [sbase] printf: Avoid casts for better portability

2014-02-01 Thread sin
On Fri, Jan 31, 2014 at 07:04:46PM +0100, FRIGN wrote: > Please let me know if I should check the code for more of those cases. Would be nice! :)

Re: [dev] [PATCH] [sbase] printf: Avoid casts for better portability

2014-02-01 Thread sin
On Fri, Jan 31, 2014 at 07:04:46PM +0100, FRIGN wrote: > On Fri, 31 Jan 2014 18:43:50 +0100 > FRIGN wrote: > > > Using the C99 PRIu32-macro and %zu-format-specifier increase > > portability and avoid these unnecessary casts. > > Argh, I forgot C90 didn't support the z-format-specifier. > So, we

Re: [dev] [PATCH] [sbase] printf: Avoid casts for better portability

2014-01-31 Thread sin
On Fri, Jan 31, 2014 at 07:04:46PM +0100, FRIGN wrote: > On Fri, 31 Jan 2014 18:43:50 +0100 > FRIGN wrote: > > > Using the C99 PRIu32-macro and %zu-format-specifier increase > > portability and avoid these unnecessary casts. > > Argh, I forgot C90 didn't support the z-format-specifier. > So, we

Re: [dev] [PATCH] [sbase] printf: Avoid casts for better portability

2014-01-31 Thread FRIGN
On Fri, 31 Jan 2014 18:43:50 +0100 FRIGN wrote: > Using the C99 PRIu32-macro and %zu-format-specifier increase > portability and avoid these unnecessary casts. Argh, I forgot C90 didn't support the z-format-specifier. So, we won't get around casting len to unsigned long -.-. Please let me know

[dev] [PATCH] [sbase] printf: Avoid casts for better portability

2014-01-31 Thread FRIGN
Using the C99 PRIu32-macro and %zu-format-specifier increase portability and avoid these unnecessary casts. diff --git a/cksum.c b/cksum.c index 25f7274..8633458 100644 --- a/cksum.c +++ b/cksum.c @@ -1,5 +1,6 @@ /* See LICENSE file for copyright and license details. */ #include +#include #in