On Thu, Mar 27, 2014 at 1:29 PM, Damian Okrasa wrote:
> 2014-03-24 9:43 GMT+01:00, Christoph Lohmann <2...@r-36.net>:
>> The naming is wrong. It is just decoding »utf8« and can’t decode
>> »utf16«. So: s,utf,utf8,g
>
> Hey,
>
> I have stripped all '8's, because there is UTF_SIZ instead of
2014-03-24 9:43 GMT+01:00, Christoph Lohmann <2...@r-36.net>:
> The naming is wrong. It is just decoding »utf8« and can’t decode
> »utf16«. So: s,utf,utf8,g
Hey,
I have stripped all '8's, because there is UTF_SIZ instead of UTF8_SIZ.
Regards.
Damian Okrasa
> Find Damian's slightly altered patch below. I hope he is okay with us
> applying this version of his patch.
>
> Just tell me if I should change something.
For me is ok, and again, if nobody complaints about it I will apply it.
Regards,
--
Roberto E. Vargas Caballero
On Mon, Mar 24, 2014 at 03:40:15PM +0100, Roberto E. Vargas Caballero wrote:
> > The new UTF-8 en-/decoder implementation patch is by Damian Okrasa, not by
> > me.
>
> Well, my suggestion was for him (I suck because I didn't explicitily said
> who was the listener).
>
> > If he doesn't mind thou
> The new UTF-8 en-/decoder implementation patch is by Damian Okrasa, not by me.
Well, my suggestion was for him (I suck because I didn't explicitily said
who was the listener).
> If he doesn't mind though, I can update it with the changes Christoph
> and I suggested. It may take me a day or two
On Mon, Mar 24, 2014 at 3:05 PM, Roberto E. Vargas Caballero
wrote:
>> > The naming is wrong. It is just decoding »utf8« and can’t decode
>> > »utf16«. So: s,utf,utf8,g
> ...
>> utf8c is actually a Unicode point and has nothing to do with utf-8 any more.
> ...
>> Same here for u8char.
>
>
> > The naming is wrong. It is just decoding »utf8« and can’t decode
> > »utf16«. So: s,utf,utf8,g
...
> utf8c is actually a Unicode point and has nothing to do with utf-8 any more.
...
> Same here for u8char.
Uh, good points. The names are a bit ambiguous and should be improved.
Coul
On Mon, Mar 24, 2014 at 9:43 AM, Christoph Lohmann <2...@r-36.net> wrote:
> Greetings.
>
> On Mon, 24 Mar 2014 09:43:23 +0100 "Roberto E. Vargas Caballero"
> wrote:
>> > It is number of function calls, on cat dwm
>> >
>> > cat UTF-8-demo yields:
>> > utflen 113
>> > utfencode 8152
>> > utfdecode
Greetings.
On Mon, 24 Mar 2014 09:43:23 +0100 "Roberto E. Vargas Caballero"
wrote:
> > It is number of function calls, on cat dwm
> >
> > cat UTF-8-demo yields:
> > utflen 113
> > utfencode 8152
> > utfdecode 198346
> >
> > So I think only utfdecode need to be optimised if necessary.
>
> I al
> It is number of function calls, on cat dwm
>
> cat UTF-8-demo yields:
> utflen 113
> utfencode 8152
> utfdecode 198346
>
> So I think only utfdecode need to be optimised if necessary.
I also like the patch, so if nobody complaints about it then I will apply next
week.
Regards,
--
Roberto E.
Sorry for previous mail, but i had focus on send, and wanted to insert
new line...
It is number of function calls, on cat dwm
cat UTF-8-demo yields:
utflen 113
utfencode 8152
utfdecode 198346
So I think only utfdecode need to be optimised if necessary.
2014-03-21 19:00 GMT+01:00, Damian Okrasa
utflen 181
utfencode35837
utfdecode 405641
On Fri, 21 Mar 2014 11:09:21 +0100
Silvan Jegen wrote:
> I ran the command only around 5 times so if the suckless community
> thinks performance is critical in this case we would need to do some
> proper benchmarking.
Well, I do prefer slower, but more readable and thus maintainable code
over fa
On Fri, Mar 21, 2014 at 10:39 AM, Silvan Jegen wrote:
> "Benchmarking" the decoder with
>
> time for i in `seq 1`; do cat UTF-8-test.txt; done;
Turns out that was a stupid idea since this approach probably just
measures the time cat needs to start x1.
If I create a file containing the co
Heyho
On Thu, Mar 20, 2014 at 5:39 PM, Damian Okrasa wrote:
> Hey,
>
> this patch replaces current utf decoder with a new one, which is ~50
> lines shorter and should be easier to understand. Parsing 5 and 6
> sequences, if necessary, requires trivial modification of UTF_SIZ
> constant and utfbyt
Hey,
this patch replaces current utf decoder with a new one, which is ~50
lines shorter and should be easier to understand. Parsing 5 and 6
sequences, if necessary, requires trivial modification of UTF_SIZ
constant and utfbyte, utfmask, utfmin, utfmax arrays.
Regards,
Damian Okrasa
st.c | 196 ++
16 matches
Mail list logo
