Re: [dev] [st][PATCH] Add support for utmp in st

2014-10-10 Thread random832
On Tue, Sep 23, 2014, at 01:18, Roberto E. Vargas Caballero wrote: > St runs an interactive shell and not a login shell, and it means > that profile is not loaded. The default terminal configuration > in some system is not the correct for st, but since profile is > not loaded there is no way of get

Re: [dev] [st][PATCH] Add support for utmp in st

2014-10-10 Thread k0ga
>> -setenv("SHELL", sh, 1); >> +setenv("SHELL", args[0], 1); > > I'm not sure whether this is a good idea? The user asked to execute > args[0] instead of the shell, but this doesn't imply that args[0] is > his shell. Yes, you are right, it should be setenv("SHELL", sh, 1); Can you send

Re: [dev] [st][PATCH] Add support for utmp in st

2014-10-10 Thread Marc André Tanner
Hi, On Tue, Sep 23, 2014 at 07:18:32AM +0200, Roberto E. Vargas Caballero wrote: > --- a/st.c > +++ b/st.c > @@ -1153,16 +1153,22 @@ execsh(void) { ... > - setenv("SHELL", sh, 1); > + setenv("SHELL", args[0], 1); I'm not sure whether this is a good idea? The user asked to execute args[0