ii could be called without any argument, using the defaults described in the
manpage.
diff --git a/ii.c b/ii.c
index d93266c..0816009 100644
--- a/ii.c
+++ b/ii.c
@@ -466,7 +466,7 @@ int main(int argc, char *argv[]) {
}
snprintf(nick, sizeof(nick), "%s", spw->pw_name);
snpr
---
st.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/st.c b/st.c
index d0c4595..3f248f3 100644
--- a/st.c
+++ b/st.c
@@ -2305,19 +2305,17 @@ techo(char *buf, int len) {
void
tdeftran(char ascii) {
- char c, (*bp)[2];
- static char tb
On Fri, Apr 25, 2014 at 06:21:10PM +0200, Roberto E. Vargas Caballero wrote:
> It is true that it is ugly to have different styles in fall through,
> but it is also true that we have a lot of fall through where we don't
> put any comment. Put a comment in all these places is a very bad idea,
> but
On Wed, Apr 30, 2014 at 12:23:56AM +0200, Jakob Kramer wrote:
> >From 734e8e4471c808eee52021d10497429ea3fc5269 Mon Sep 17 00:00:00 2001
> From: Jakob Kramer
> Date: Wed, 30 Apr 2014 00:10:40 +0200
> Subject: [PATCH 1/2] su: zero out cryptpass
If we really want to do this, can we at least have a
Zero out the spwd structure and the calculated password. This time
using explicit_bzero.
>From 94c271d60120f398b0d50e3258c50b237c9d6b7b Mon Sep 17 00:00:00 2001
From: Jakob Kramer
Date: Wed, 30 Apr 2014 14:15:26 +0200
Subject: [PATCH] su: zero out encrypted passwords
---
su.c | 2 ++
1 file cha
The patch that I sent before does not check if both passwords are of the
same length, which is bad.
>From a4001bf30fb44245fc7da12b61fcf7df5f762058 Mon Sep 17 00:00:00 2001
From: Jakob Kramer
Date: Wed, 30 Apr 2014 00:20:31 +0200
Subject: [PATCH 2/2] su: use "constant time" memcmp to compare passwo
On Wed, Apr 30, 2014 at 12:23:56AM +0200, Jakob Kramer wrote:
> >From 734e8e4471c808eee52021d10497429ea3fc5269 Mon Sep 17 00:00:00 2001
> From: Jakob Kramer
> Date: Wed, 30 Apr 2014 00:10:40 +0200
> Subject: [PATCH 1/2] su: zero out cryptpass
I am considering to remove the zero-out code entirely
On Wed, Apr 30, 2014 at 12:24:29AM +0200, Jakob Kramer wrote:
> static void
> usage(void)
> @@ -86,7 +87,7 @@ main(int argc, char *argv[])
> if (!cryptpass)
> eprintf("crypt:");
>
> - if (strcmp(cryptpass, spw->sp_pwdp) != 0)
> + if (
