Re: [dev] [st] [patch] multi-line selection causes core dump on OpenBSD

2013-09-23 Thread Roberto E. Vargas Caballero
On Mon, Sep 23, 2013 at 12:07:06PM +0200, Maurice Quennet wrote: > Roberto E. Vargas Caballero wrote: > > If you agree with this small difference I will commit your change. > > I don't mind. Applied. -- Roberto E. Vargas Caballero k...@shike2.com http://www.shike2

Re: [dev] st: bracketed paste mode

2013-09-23 Thread stargrave
Greetings! - User Roberto E. Vargas Caballero on 2013-09-19 11:27:56 wrote: >It seems there are some users that could be interested in this feature, >so I will apply it next week. I have tested the latest master branch of st just to see what this feature is. It is really great! Thanks Egmont f

Re: [dev] [surf] New webkit engine worth keeping an eye on

2013-09-23 Thread Dmitrij D. Czarkoff
On Mon, Sep 23, 2013 at 05:19:44PM +0200, Roberto E. Vargas Caballero wrote: > It would be really good. Using WebKitGtk+ usually means install a lot > of suck software, like for example dbus. This new port of WebKit > can reduce a lot the number of dependencies of surf. Still WebKitNix requires GT

Re: [dev] [surf] New webkit engine worth keeping an eye on

2013-09-23 Thread Roberto E. Vargas Caballero
> There's still plenty of suck, but definitely a good deal less than > WebKitGTK+, and it looks to be getting better. > > It would be lovely to see surf switch to using this port at some > point. Perhaps I will have time to look into doing this, perhaps > not, we'll see. It would be really good.

[dev] [surf] New webkit engine worth keeping an eye on

2013-09-23 Thread Nick
Hi folks, I just found out about a new webkit port called "WebKitNix". It looks like a better alternative to WebKitGTK+, using OpenGL for rendering, and not requiring a UI toolkit. Initial announcement: http://article.gmane.org/gmane.os.opendarwin.webkit.devel/24877/ Website: http://webkitnix.op

Re: [dev] [st] [patch] multi-line selection causes core dump on OpenBSD

2013-09-23 Thread Maurice Quennet
Roberto E. Vargas Caballero wrote: > If you agree with this small difference I will commit your change. I don't mind. Martti Kühne wrote: > logically, wouldn't that be > > if(y < sel.ne.y && (x == 0 || !((gp-1)->mode & ATTR_WRAP))) > > ? > > I think the outcome for x==0 would be different in

Re: [dev] [st] [patch] multi-line selection causes core dump on OpenBSD

2013-09-23 Thread Martti Kühne
Otoh, don't prefix the first line with a newline. I seem to have been early there. :-) cheers! mar77i

Re: [dev] [st] [patch] multi-line selection causes core dump on OpenBSD

2013-09-23 Thread Martti Kühne
On Mon, Sep 23, 2013 at 10:50 AM, Roberto E. Vargas Caballero wrote: >> I'm running OpenBSD 5.3 amd64 release version with the most current st >> version from git and I noticed that st was crashing and dumping core >> when selecting multiple lines whith the cursor. This happens, because >> on lin

Re: [dev] [st] [patch] multi-line selection causes core dump on OpenBSD

2013-09-23 Thread Roberto E. Vargas Caballero
> I'm running OpenBSD 5.3 amd64 release version with the most current st > version from git and I noticed that st was crashing and dumping core > when selecting multiple lines whith the cursor. This happens, because > on line 964 of st.c (gp-1)->mode is accessed, although gp is still Good catch.

Re: [dev] [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

2013-09-23 Thread Roberto E. Vargas Caballero
On Sat, Sep 21, 2013 at 03:41:01PM +0200, Mark Edgar wrote: > This patch avoids a buffer overflow in kpress() if a key-mapped string > longer than 31 characters is given in config.h. It also changes the I think we should only check that the size of the string is the correct, with something like: