Re: [dev] color-scheme

2011-08-01 Thread Suraj N. Kurapati
On Mon 25 Jul 2011 06:22:58 PM PDT, ilf wrote: > What's your favorite color-scheme? I use Vim's xoria256 color scheme[1] in my Xresources[2]. [1] http://www.vim.org/scripts/script.php?script_id=2140 [2] http://snk.tuxfamily.org/log/xoria256-terminal-color-scheme.html -- System going down at 5 t

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread anonymous
On Mon, Aug 01, 2011 at 03:52:37PM +0400, anonymous wrote: > On Mon, Aug 01, 2011 at 03:34:46PM +0400, anonymous wrote: > Patch is attached. Forgot to attach. To make it work, you should reorder TAGKEYS, so masks with more modifiers are matched first. #define TAGKEYS(KEY,TAG) \ { MODKE

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread Aurélien Aptel
On Mon, Aug 1, 2011 at 6:14 PM, anonymous wrote: > With my patch it is matched with any modifier too, because (key & 0) == 0. Yes but it doesn't fix the problem of redefining what XK_Insert sends while keeping shift + insert to paste. I've used it in my patch attached to match XK_ANY_MOD. I'd lik

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread anonymous
On Mon, Aug 01, 2011 at 05:55:25PM +0200, Aurélien Aptel wrote: > On Mon, Aug 1, 2011 at 1:34 PM, anonymous wrote: > > I think my patch is better.  There is no special case for 0 mask and state > > and when we match for Ctrl and Shift it works only when they both are > > pressed.  With your patch

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread Aurélien Aptel
On Mon, Aug 1, 2011 at 5:55 PM, Aurélien Aptel wrote: > When numlock is on, each keypress has a state of 0x10. I suppose > nobody actually use keybindings involving numlock so kmap() could > clear the numlock mask from state before looking for a match in key[]. And handle the special case when ma

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread Aurélien Aptel
On Mon, Aug 1, 2011 at 1:34 PM, anonymous wrote: > I think my patch is better.  There is no special case for 0 mask and state > and when we match for Ctrl and Shift it works only when they both are > pressed.  With your patch it will work for Ctrl only or for Shift only. When a key in config.h ha

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread anonymous
On Mon, Aug 01, 2011 at 01:50:33PM +0100, Ethan Grammatikidis wrote: > On Mon, 1 Aug 2011 15:52:37 +0400 > anonymous wrote: > > > On Mon, Aug 01, 2011 at 03:34:46PM +0400, anonymous wrote: > > > Maybe it can be adopted for dwm so we would be able to remove this > > > CLEANMASK macro. > > > > Pat

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread Ethan Grammatikidis
On Mon, 1 Aug 2011 15:52:37 +0400 anonymous wrote: > On Mon, Aug 01, 2011 at 03:34:46PM +0400, anonymous wrote: > > Maybe it can be adopted for dwm so we would be able to remove this > > CLEANMASK macro. > > Patch is attached. Maybe I missed something because I don't understand > what numlockma

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread anonymous
On Mon, Aug 01, 2011 at 03:34:46PM +0400, anonymous wrote: > Maybe it can be adopted for dwm so we would be able to remove this > CLEANMASK macro. Patch is attached. Maybe I missed something because I don't understand what numlockmask is for. Maybe my patch breaks something or maybe we can remove

Re: [dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread anonymous
I think my patch is better. There is no special case for 0 mask and state and when we match for Ctrl and Shift it works only when they both are pressed. With your patch it will work for Ctrl only or for Shift only. Maybe it can be adopted for dwm so we would be able to remove this CLEANMASK macr

[dev] [st] shift-insert patch (more general: key.mask and state)

2011-08-01 Thread stanio
Hi, I had this issue with shift-insert not working in st which annoyed me a lot again while setting up a new box today, so I looked into it. `kpress` first invokes `kmap` to handle custom keys which override default behaviour. In `kmap` this condition if(key[i].k == k && (key[i].mask ==