[PATCH] possible improvement to svn log with "forward" revision range (issue 3830)

2011-06-02 Thread Dirk Thomas
or "forward" logs where target has been removed before end-of-range. Patch by: Dirk Thomas >>> If the modifications need further polishing please just drop me a note. Dirk Index: tests/cmdline/log_tests.py =

Re: [PATCH] possible improvement to svn log with "forward" revision range (issue 3830)

2011-06-11 Thread Dirk Thomas
on before item is deleted if necessary. * subversion/tests/cmdline/log_tests.py (forward_log): added test for "forward" logs where target has been removed before end-of-range. Patch by: Dirk Thomas >>> Could somebody please take a closer look to the proposed patch. It should i

Re: [PATCH] possible improvement to svn log with "forward" revision range (issue 3830)

2011-06-13 Thread Dirk Thomas
Thank you for your feedback, Philip. I have attached an updated patch. A short comment along the lines 'Sets *REVISION_DELETED ...' I have added a comment for function check_for_deleted_rev. No whitespace before ')'. Split long line before '&& session_opt_revnum' I have updated the for

Re: [PATCH] possible improvement to svn log with "forward" revision range (issue 3830)

2011-06-14 Thread Dirk Thomas
I know everybody is quite busy due to the upcoming release. But is there any chance that this patch - which improves svn log for forward revision ranges - will make it into SVN before this and be part of 1.7.0? Dirk

Problem with svn log for unrelated revisions

2011-06-17 Thread Dirk Thomas
While working on issue 3830 i noticed the following behavior of svn log. In the test repository used in log_tests.py the path "A/D/G/rho" is: - created in revision 1 - deleted in revision 5 - recreated in revision 8 The following commands result in the expected error "Unable to find repository

Re: Problem with svn log for unrelated revisions

2011-06-17 Thread Dirk Thomas
> That does appear to be a bug. I don't see a similar issue in the > tracker; would you mind filing a new issue? No worries if you cannot, > I can do it at some point today. i have created issue #3931. > I'll commit your patch once we have an issue. Prepend: @Issue(3931) before "def log_unre

Re: Problem with svn log for unrelated revisions

2011-06-17 Thread Dirk Thomas
In the test repository used in log_tests.py the path "A/D/G/rho" is: - created in revision 1 - deleted in revision 5 - recreated in revision 8 The following commands result in the expected error "Unable to find repository location for": svn log -r 2:9 path-to-wc/A/D/G/rho@2 svn log -r 9:2 path-to

Re: Problem with svn log for unrelated revisions

2011-06-17 Thread Dirk Thomas
> But ... but ... you said it *did* output an error: > > "... result in the expected error 'Unable to find repository location' ..." > > Did you read my comments and apply them to wrong section of your mail? i apologize, i read your email to fast. Your are right - this is actually the expected

Re: [PATCH] possible improvement to svn log with "forward" revision range (issue 3830)

2011-06-23 Thread Dirk Thomas
Well, since issue 3931 was fixed today ('svn log' is returning log of unrelated path when peg revision is not related to operative revision) i revisited my patch for issue 3830. + /* try fetching ra_session again + * this time with modified revision argument. + * @todo modify already existing

What to expect from svn log?

2011-06-23 Thread Dirk Thomas
I have recently looked into issue 3830 (forward revision range) and thereby found issue 3931 (returning log of unrelated path). While implementing support for forward revision ranges i came across various cases, where i would like to resolve what is actually expected/desired: - what "svn log" cu