brainy commented on PR #33:
URL: https://github.com/apache/subversion/pull/33#issuecomment-3048689336
Yes, yes, the title of the PR is just wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Humbedooh closed pull request #33: Bug: dict.copy() always returns None
URL: https://github.com/apache/subversion/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Humbedooh opened a new pull request, #33:
URL: https://github.com/apache/subversion/pull/33
We need the merged defaults copy returned to us, so the old return is
instead split into three commands:
- copy `defaults`
- update the copy with `match.groupdict()`
- return the updated
brainy commented on PR #33:
URL: https://github.com/apache/subversion/pull/33#issuecomment-3048680996
Eh? `dict.copy()` does not return None. `dict.update()` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
brainy commented on code in PR #33:
URL: https://github.com/apache/subversion/pull/33#discussion_r2192358467
##
tools/hook-scripts/mailer/mailer.py:
##
@@ -1401,7 +1401,9 @@ def repos_params(section_name, defaults):
# Extract key/value pairs from the regex match of
netomi commented on PR #33:
URL: https://github.com/apache/subversion/pull/33#issuecomment-3048687139
the original code returns the result of `update` which is `None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
brainy commented on code in PR #33:
URL: https://github.com/apache/subversion/pull/33#discussion_r2192358467
##
tools/hook-scripts/mailer/mailer.py:
##
@@ -1401,7 +1401,9 @@ def repos_params(section_name, defaults):
# Extract key/value pairs from the regex match of
brainy commented on PR #33:
URL: https://github.com/apache/subversion/pull/33#issuecomment-3048893052
Committed a slightly tweaked patch in r1927075.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gstein commented on PR #33:
URL: https://github.com/apache/subversion/pull/33#issuecomment-3049649409
Re-using the "defaults" variable for other purposes made the code confusing,
especially with the "fall through" to where the comment mentions nothing to add.
I used Daniel's original
gstein commented on code in PR #33:
URL: https://github.com/apache/subversion/pull/33#discussion_r2193004781
##
tools/hook-scripts/mailer/mailer.py:
##
@@ -1401,7 +1401,9 @@ def repos_params(section_name, defaults):
# Extract key/value pairs from the regex match of
On 8. 7. 25 02:18, Branko Čibej wrote:
When Subversion is built with SVN_DEBUG defined, error messages
contain a call trace with absolute paths to the source files. This
potentially exposes sensitive user info, such as project or company
names, when people post error reports to the 'net or e-ma
11 matches
Mail list logo
