[PATCH] svnlook history --limit

2024-07-24 Thread zongganli(李宗淦)
Hello, We found a bug in svnlook history --limit. It can not deal with the illegal input like "-1", as "apr_size_t" could be unsigned. [[[ Fix the command-line option "--limit" in svnlook. *subversion/svnlook/svnlook.c (sub_main): Use a variable of type long to handle the input of "--limit",

Re: [PATCH] svnlook history --limit

2024-07-24 Thread Andreas Stieger
On 2024-07-24 13:35, zongganli(李宗淦) wrote: We found a bug in svnlook history --limit. Can you describe how this bug manifests itself? It can not deal with the illegal input like "-1", as "apr_size_t" could be unsigned. Not having reviewed this in detail, but maybe we should make this sim

Re: [PATCH] svnlook history --limit

2024-07-24 Thread Daniel Sahlberg
Den ons 24 juli 2024 kl 14:06 skrev Andreas Stieger : > > On 2024-07-24 13:35, zongganli(李宗淦) wrote: > > We found a bug in svnlook history --limit. > > > Can you describe how this bug manifests itself? > > It can not deal with the illegal input like "-1", as "apr_size_t" could be > unsigned. > > >

Re: [PATCH] svnlook history --limit

2024-07-24 Thread Daniel Sahlberg
Den ons 24 juli 2024 kl 15:02 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > Den ons 24 juli 2024 kl 14:06 skrev Andreas Stieger < > andreas.stie...@gmx.de>: > >> >> On 2024-07-24 13:35, zongganli(李宗淦) wrote: >> >> We found a bug in svnlook history --limit. >> >> >> Can you describe how t