Re: Move change revision parser to libsvn_subr

On Tue, May 21, 2024 at 10:31 AM Timofey Zhakov wrote: > > Hi, > > When I was fixing a bug related to the change revision argument (-c), > I noticed that the function which parses the change revision argument > is implemented implicitly in the sub_main (in file svn.c) [1], while > other revision p

[PATCH] Add check of the changeno_end variable for zero (was: [PATCH] Check the change argument for a double minus at the start.)

> >>> I found a little bug in parsing a change revision: If the number, > >>> given to the --change argument, starts with a double minus or with > >>> `-r-`, the command aborts. This patch fixes this bug. > >>> [...] > > Thanks! > > Found another similar issue in -c option. > > The following works

Re: [PATCH] Add check of the changeno_end variable for zero (was: [PATCH] Check the change argument for a double minus at the start.)

On Wed, May 22, 2024 at 5:04 PM Timofey Zhakov wrote: > > > >>> I found a little bug in parsing a change revision: If the number, > > >>> given to the --change argument, starts with a double minus or with > > >>> `-r-`, the command aborts. This patch fixes this bug. > > >>> > [...] > > > Thanks! >

Re: Move change revision parser to libsvn_subr

Hi Nathan, On Wed, May 22, 2024 at 4:06 PM Nathan Hartman wrote: > > On Tue, May 21, 2024 at 10:31 AM Timofey Zhakov wrote: [...] > Hi Timofei, > > I haven't looked at the code yet, but I'd like to say that > conceptually a refactor with improved unit testing sounds good. > > It's a shame that m