Re: Python 3 compatibility issue in tools/hook-scripts/mailer/mailer.py

2023-12-16 Thread Yasuhito FUTATSUKI
On 2023/12/11 12:54, Yasuhito FUTATSUKI wrote: > On 2023/12/10 4:22, Yasuhito FUTATSUKI wrote: >> Thank you for the review. However, it turned out that even with this >> patch, mailer.py did not work for post-revprop-change hook. >> It caused exception like >> >> [[[ >> svn: E165001: post-revprop-

Re: Python 3 compatibility issue in tools/hook-scripts/mailer/mailer.py

2023-12-16 Thread Greg Stein
Oh, shoot. And I was trying to be incremental/careful. Thank you for catching that! I also like how you fixed this. The .run() method did need to be removed because of that singular usage. Using the new generate_diff() function is a great solution! (whereas we used to have an object, which made it

Re: svn commit: r1914679 - /subversion/trunk/tools/hook-scripts/mailer/mailer.py

2023-12-16 Thread Greg Stein
On Fri, Dec 15, 2023 at 4:51 AM Yasuhito FUTATSUKI wrote: > Hi, > > On 2023/12/15 18:44, gst...@apache.org wrote: > > Author: gstein > > Date: Fri Dec 15 09:44:03 2023 > > New Revision: 1914679 > > > > URL: http://svn.apache.org/viewvc?rev=1914679&view=rev > > Log: > > class DifflibDiffContent do