Re: Close SVN-1778

2023-10-04 Thread Daniel Sahlberg
Den ons 4 okt. 2023 kl 06:58 skrev Nathan Hartman : > Thanks for the review! Committed in r1912724. More below: > Great! > I see only one issue: FileNotFoundError is new in Python 3, so Python 2 > will fail with a NameError when it sees that. However: On Python 3, > FileNotFoundError inherits f

Re: Close SVN-1778

2023-10-04 Thread Yasuhito FUTATSUKI
Hello, On 2023/10/04 18:02, Daniel Sahlberg wrote: Den ons 4 okt. 2023 kl 06:58 skrev Nathan Hartman : Thanks for the review! Committed in r1912724. More below: Great! I see only one issue: FileNotFoundError is new in Python 3, so Python 2 will fail with a NameError when it sees that.

Re: Close SVN-1778

2023-10-04 Thread Nathan Hartman
On Wed, Oct 4, 2023 at 10:59 AM Yasuhito FUTATSUKI wrote: > Hello, > > On 2023/10/04 18:02, Daniel Sahlberg wrote: > > Den ons 4 okt. 2023 kl 06:58 skrev Nathan Hartman < > hartman.nat...@gmail.com > >> : > > > >> Thanks for the review! Committed in r1912724. More below: > >> > > > > Great! > > >

Re: Close SVN-1778

2023-10-04 Thread Yasuhito FUTATSUKI
On 2023/10/05 5:28, Nathan Hartman wrote: On Wed, Oct 4, 2023 at 10:59 AM Yasuhito FUTATSUKI wrote: Nothing but I don't want that we actively drop Python 2 support, at least SWIG Python bindings even in trunk, at least now. I agree we shouldn't break Python 2 support if it's currently work