Re: Close SVN-1778

2023-10-02 Thread Daniel Sahlberg
Den sön 1 okt. 2023 kl 21:50 skrev Nathan Hartman : > On Sun, Oct 1, 2023 at 9:58 AM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > > > > Hi, > > > > Issue SVN-1778 [1] is about the Python bindings, class FileDiff, where > get_pipe() called an external program diff (under Windows: diff.

Re: svn commit: r1912500 - in /subversion/trunk/subversion/bindings/swig: python/libsvn_swig_py/swigutil_py.c python/libsvn_swig_py/swigutil_py.h python/svn/delta.py python/svn/repos.py svn_delta.i sv

2023-10-02 Thread Yasuhito FUTATSUKI
Hi, Thank you for the review and test. On 2023/10/02 0:43, Daniel Sahlberg wrote: Den sön 24 sep. 2023 kl 12:55 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>: Hi, On 2023/09/24 17:53, Daniel Sahlberg wrote: Den sön 24 sep. 2023 kl 07:06 skrev : Author: futatuki Date: Sun Sep 24 05:0

Re: svn commit: r1912500 - in /subversion/trunk/subversion/bindings/swig: python/libsvn_swig_py/swigutil_py.c python/libsvn_swig_py/swigutil_py.h python/svn/delta.py python/svn/repos.py svn_delta.i sv

2023-10-02 Thread Daniel Sahlberg
mån 2 okt. 2023 kl. 16:54 skrev Yasuhito FUTATSUKI : > > > I've added my vote for the backports, because of my inexperience I've > only > > set +0 but binding fixes should be OK to backport with only one +1 and > one > > +0. Any fixes from [1] can be added to the same backport (as I read it > > do

Re: Close SVN-1778

2023-10-02 Thread Nathan Hartman
On Mon, Oct 2, 2023 at 5:39 AM Daniel Sahlberg wrote: > Den sön 1 okt. 2023 kl 21:50 skrev Nathan Hartman : (snip) >> This (somewhat platform-specific) "gotcha" isn't completely obvious from a >> first glance at the code. >> >> Your explanation above makes the failure mode and its reasons more cl

Re: Close SVN-1778

2023-10-02 Thread Daniel Sahlberg
Den tis 3 okt. 2023 kl 02:44 skrev Nathan Hartman : > On Mon, Oct 2, 2023 at 5:39 AM Daniel Sahlberg > wrote: > > Den sön 1 okt. 2023 kl 21:50 skrev Nathan Hartman < > hartman.nat...@gmail.com>: > (snip) > >> This (somewhat platform-specific) "gotcha" isn't completely obvious > from a first glanc