Julian Foad wrote on Fri, Jan 21, 2022 at 11:15:04 +:
> Scanning with 'stat'
>
> I'm concerned about the implementation scanning the whole subtree,
> calling 'stat' on every file to determine whether the file is "changed"
> (locally modified). This is done in svn_wc__textbase_sync() with its
Look:
1 % ag --py 'run_svn[(](?!None|False|True|0|1|$)'
subversion/tests/cmdline/
2 subversion/tests/cmdline/blame_tests.py:131:
svntest.main.run_svn(binary_mime_type_on_text_file_warning,
3 subversion/tests/cmdline/blame_tests.py:135: exit_code, output, errput
= svntest.m
Daniel Shahaf wrote on Tue, Jan 25, 2022 at 11:31:22 +:
> The problem? run_svn()'s first parameter is a boolean. Passing an
> expected error message or wc_dir to it doesn't have the expected
> results. Most of the above uses are buggy or misleading.
>
> We should audit uses of run_svn() and
dsahlb...@apache.org wrote on Sun, 16 Jan 2022 19:19 +00:00:
> Add a test for issue #4856, "invalid xml file produced by: svn log --xml
> --use-merge-history".
⋮
> * subversion/tests/cmdline/log_tests.py
> (log_xml_with_merge_history): New test.
> (test_list): Run it.
The new test XFails for m
Daniel Shahaf wrote:
> dsahlb...@apache.org wrote on Sun, 16 Jan 2022 19:19 +00:00:
>> Add a test for issue #4856, "invalid xml file produced by: svn log --xml
>> --use-merge-history".
>
> The new test XFails for me over ra_local but XPasses over
> svnserveautocheck and davautocheck.
On the 'pris
On Jan 25 2022, at 1:15 pm, Julian Foad wrote:
> Daniel Shahaf wrote:
>> dsahlb...@apache.org wrote on Sun, 16 Jan 2022 19:19 +00:00:
>>> Add a test for issue #4856, "invalid xml file produced by: svn log --xml
>>> --use-merge-history".
>>
>> The new test XFails for me over ra_local but XPass
Julian Foad wrote:
> I DO confirm
>
> XPASS: log_tests.py 47: log --use-merge-history --xml
>
> with RA-svn/serf on trunk.
(That's today's trunk with your 'str/unicode/...' check line removed.)
Den tis 25 jan. 2022 kl 14:21 skrev Julian Foad :
>
>
> On Jan 25 2022, at 1:15 pm, Julian Foad wrote:
>
> > Daniel Shahaf wrote:
> >> dsahlb...@apache.org wrote on Sun, 16 Jan 2022 19:19 +00:00:
> >>> Add a test for issue #4856, "invalid xml file produced by: svn log
> --xml
> >>> --use-merge-hi
Julian Foad wrote on Tue, 25 Jan 2022 13:15 +00:00:
> On a trunk WC (updated today) I get:
>
> File
> "/home/julianfoad/src/subversion-d/subversion/tests/cmdline/svntest/main.py",
> line 619, in
> assert all(isinstance(arg, (str, unicode, int)) for arg in varargs)
> NameError: name 'unicod
Daniel Sahlberg wrote on Tue, 25 Jan 2022 13:29 +00:00:
> Oh. That is interesting, I never thought about running the checks on svn
> and dav. Is there a way to flag the test as "only xfails on local", and can
> someone help me do this? I'm a bit short on time right now.
r1897457.
Cheers,
Daniel
Den tis 25 jan. 2022 kl 15:40 skrev Daniel Shahaf :
> Daniel Sahlberg wrote on Tue, 25 Jan 2022 13:29 +00:00:
> > Oh. That is interesting, I never thought about running the checks on svn
> > and dav. Is there a way to flag the test as "only xfails on local", and
> can
> > someone help me do this?
Replying to selected points from the last few messages.
Daniel Shahaf wrote:
> Julian Foad wrote on Thu, Jan 20, 2022 at 21:03:02 +:
>> The only case in which a simple per-WC setting might be unsatisfactory
>> is the following combination:
>
> Why would it be the only case?
I assert that pe
On Mon, Jan 24, 2022 at 11:50 AM Karl Fogel wrote:
> On 24 Jan 2022, Daniel Shahaf wrote:
>
> >Which brings me to a less contrived / more general point: What if
> >the user _knows in advance_ they'll need a pristine? Shouldn't
> >there be: — - a way to say "I'm about to change a large,
> >diffa
13 matches
Mail list logo
