Re: 1.9.x release notes, SVN-4722

2019-12-10 Thread Nathan Hartman
On Tue, Dec 10, 2019 at 1:56 AM Daniel Shahaf wrote: > > 1.9 release notes: Document known issue SVN-4722 in 1.9.6 and 1.9.7 > Historically, we've usually used the section's id in the «(symbol name)» > part of the log message. In fact, I'd probably have written this as just: > > (#svn-4722): Ne

Re: Merging branches/swig-py3 to trunk

2019-12-10 Thread Nathan Hartman
On Tue, Dec 3, 2019 at 3:14 PM Nathan Hartman wrote: > I'm placing a reminder to myself to update the 1.14 Release Notes with > a link to this wiki page in "known issues" as discussed previously... Regarding the 1.14 release notes and linking to the Python 3 work in progress / status wiki page, I

Re: Merging branches/swig-py3 to trunk

2019-12-10 Thread Julian Foad
Nathan Hartman wrote: Regarding the 1.14 release notes and linking to the Python 3 work in progress / status wiki page, I'm thinking of something along these lines: [...] Looks good to me. I encourage you to go ahead and commit stuff like this without waiting for pre-commmit review. - Julia

Re: Merging branches/swig-py3 to trunk

2019-12-10 Thread Nathan Hartman
On Tue, Dec 10, 2019 at 11:30 AM Julian Foad wrote: > Nathan Hartman wrote: > > Regarding the 1.14 release notes and linking to the Python 3 work > > in progress / status wiki page, I'm thinking of something along these > > lines: [...] > > Looks good to me. I encourage you to go ahead and commit

Re: [Patch] Rework of r1866425 ('Last-Modified' header)

2019-12-10 Thread Nathan Hartman
On Mon, Dec 9, 2019 at 10:54 AM Sergey Raevskiy wrote: > I've spent some time examining r1866425 [1] ('Last-Modified' header) and I > would like to suggest a patch with some rework related to this code. > > I see two main problems in r1866425: usage of the pointer comparison (which is > hackish an

Re: [Patch] Rework of r1866425 ('Last-Modified' header)

2019-12-10 Thread Johan Corveleyn
On Tue, Dec 10, 2019 at 6:35 PM Nathan Hartman wrote: > On Mon, Dec 9, 2019 at 10:54 AM Sergey Raevskiy > wrote: > > I've spent some time examining r1866425 [1] ('Last-Modified' header) and I > > would like to suggest a patch with some rework related to this code. > > > > I see two main problems

Wiki editing

2019-12-10 Thread Daniel Shahaf
I wanted to update the Python 3 page on the wiki, but I'm given a choice between a in-browser WYSIWYG editor and editing raw HTML. Neither of these is very user-friendly to me (the default editor doesn't even render correctly; the raw HTML editor puts the whole list of bullets in one long source l

Escape filename for conflict merge

2019-12-10 Thread James McCoy
When a text conflict occurs during a merge, the user is given the option to resolve the conflict and we spawn their editor for them. In svn_cmdline__edit_file_externally, we explicitly use the shell to invoke the editor, so that $SVN_EDITOR can be a command with arguments rather than just a binary

Re: Wiki editing

2019-12-10 Thread Nathan Hartman
On Tue, Dec 10, 2019 at 9:22 PM Daniel Shahaf wrote: > I wanted to update the Python 3 page on the wiki, but I'm given a choice > between a in-browser WYSIWYG editor and editing raw HTML. Neither of > these is very user-friendly to me (the default editor doesn't even > render correctly; the raw

Re: Wiki editing

2019-12-10 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 11 Dec 2019 04:44 +00:00: > On Tue, Dec 10, 2019 at 9:22 PM Daniel Shahaf wrote: > > I wanted to update the Python 3 page on the wiki, but I'm given a choice > > between a in-browser WYSIWYG editor and editing raw HTML. Neither of > > these is very user-friendly to m