Re: rep-cache sanity checks Re: Script to obliterate the most recent revision(s)

2018-03-26 Thread Julian Foad
Daniel Shahaf wrote: Julian Foad wrote on Fri, Mar 23, 2018 at 17:30:14 +: Nathan Hartman wrote: It just occurred to me that because correct operation of the rep- cache is so crucial to the reliability of the system, perhaps it would be a good idea to make sure the rep-cache does not contai

Shelving: documenting the storage location [was: svn commit: r1825045 ...]

2018-03-26 Thread Julian Foad
Daniel Shahaf wrote: julianf...@apache.org wrote on Thu, 22 Feb 2018 11:02 +: +++ subversion/trunk/subversion/svn/svn.c Thu Feb 22 11:02:02 2018 + " Shelved changes are stored in /.svn/shelves/\n" I noticed this line while reviewing the backport and wanted to ask, why do we document t

Re: Rolling 1.10.0-rc2

2018-03-26 Thread Julian Foad
Julian Foad wrote: Can anyone volunteer to review this important block-read fix? (adding to CC: some people who might) Thanks for your review, stefan2! We now need one more review. - Julian Philip Martin wrote: Julian Foad writes: How do you feel about the amount of test coverage we are

Re: rep-cache sanity checks Re: Script to obliterate the most recent revision(s)

2018-03-26 Thread Philip Martin
Daniel Shahaf writes: > While we're at it, do we check, before using a rep-cache reference, that the > revision:offset coordinates we obtained do in fact refer to a representation? The SHA1 collision detection code means Subversion now does very exact verification of rep-cache references. Subve

Re: Rolling 1.10.0-rc2

2018-03-26 Thread Julian Foad
Julian Foad wrote: We now need one more review. Thanks, Bert! Looks like we're "green" again: the other nominations in the 'STATUS' file are only "nice to have" in my opinion. So I'll plan to roll RC2 ASAP -- which means around mid-week. - Julian