Troy Curtis Jr wrote on Sun, 11 Feb 2018 03:36 +:
> I believe that Subversion has an internal diff generation utility, could
> someone point me in the right direction?
tools/diff/diff
svn_diff_diff_2()
> I think just changing the implementation to using an internal diff
> would make this mor
Troy Curtis Jr wrote on Sun, 11 Feb 2018 02:28 +:
> I committed the fix to the bindings in
> https://svn.apache.org/viewvc?view=revision&revision=1823802 . In addition
> to Kenneth's suggestion of opening in binary mode, I switched the imports
> so that the python2-future's implementation woul
On Sun, Feb 11, 2018 at 2:38 AM Daniel Shahaf
wrote:
> Troy Curtis Jr wrote on Sun, 11 Feb 2018 02:28 +:
> > I committed the fix to the bindings in
> > https://svn.apache.org/viewvc?view=revision&revision=1823802 . In
> addition
> > to Kenneth's suggestion of opening in binary mode, I switch
In parallel to the other discussion on import order of svn.fs.FileDiff, I'd
like some comments on the attached patch. Mostly, this is to address the
failing tests on Windows [0], since there isn't a 'diff' executable
necessarily available. The attached patch uses the internal Subversion
diff impl
Troy Curtis Jr wrote on Sun, 11 Feb 2018 14:27 +:
> All this being said, I'm fine reverting the import swap if that is what is
> desired, as all indications are that it works either way now. I simply
> liked the communication of intent better with this order.
I think the primary reason for th
Troy Curtis Jr wrote on Sun, 11 Feb 2018 16:10 +:
> I'm asking for comments because the actual diff output given when
> 'diffoptions' is None, is changed.
...
> Thoughts?
1. We have two consumers of FileDiff in tools/. Check whether they are
affected?
2. We might include the change in an a
6 matches
Mail list logo
