1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Julian Foad
About this new-for-1.10 API: [[[ /** Reads a string from stdin until a newline or EOF is found * * @since New in 1.10. */ svn_error_t * svn_io_stdin_readline(const char **result, apr_pool_t *result_pool, apr_pool_t *scratch_pool); ]]] Compare with sv

Re: Reviewing 1.10 APIs & compatibility

2018-01-15 Thread Julian Foad
Julian Foad wrote: Any volunteers? I have added this task to the pre-release check-list in http://subversion.apache.org/docs/community-guide/releasing.html#release-branches Filed as https://issues.apache.org/jira/browse/SVN-4716 If anyone has done or is doing any review please could you me

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Stefan Sperling
On Mon, Jan 15, 2018 at 04:42:02PM +, Julian Foad wrote: > About this new-for-1.10 API: > [[[ > /** Reads a string from stdin until a newline or EOF is found > * > * @since New in 1.10. > */ > svn_error_t * > svn_io_stdin_readline(const char **result, > apr_pool_t *resu

Re: Reviewing 1.10 APIs & compatibility

2018-01-15 Thread Philip Martin
Julian Foad writes: > Julian Foad wrote: >> Another possible approach is to look for compatibility breakage by >> running the 1.9 client and test suite against the 1.10 libraries, >> and indeed different client/server version combinations. I did this recently. 1.9 against a 1.10 server

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Nathan Hartman
> On Jan 15, 2018, at 11:42 AM, Julian Foad wrote: > > About this new-for-1.10 API: > [[[ > /** Reads a string from stdin until a newline or EOF is found > * > * @since New in 1.10. > */ > svn_error_t * > svn_io_stdin_readline(const char **result, > apr_pool_t *result_pool, >

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Branko Čibej
On 16.01.2018 03:42, Nathan Hartman wrote: >> On Jan 15, 2018, at 11:42 AM, Julian Foad wrote: >> >> About this new-for-1.10 API: >> [[[ >> /** Reads a string from stdin until a newline or EOF is found >> * >> * @since New in 1.10. >> */ >> svn_error_t * >> svn_io_stdin_readline(const char **resul

Re: 1.10 API review - svn_io_stdin_readline()

2018-01-15 Thread Branko Čibej
On 15.01.2018 22:22, Stefan Sperling wrote: > On Mon, Jan 15, 2018 at 04:42:02PM +, Julian Foad wrote: >> About this new-for-1.10 API: >> [[[ >> /** Reads a string from stdin until a newline or EOF is found >> * >> * @since New in 1.10. >> */ >> svn_error_t * >> svn_io_stdin_readline(const c