Re: Remaining suggested API changes for 1.9

2015-04-13 Thread Philip Martin
Branko Čibej writes: > If it's declared in a public header, then it's a public API regardless > of how many consecutive underscores there are in the name. We can't > remove it. We moved svn_sort__hash from the public header in 1.8 to the private header in 1.9. That might have been a mistake. I

Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

2015-04-13 Thread Ivan Zhakov
On 13 April 2015 at 15:23, wrote: > Author: rhuijben > Date: Mon Apr 13 12:23:20 2015 > New Revision: 1673170 > > URL: http://svn.apache.org/r1673170 > Log: > Add an fs layer api that allows obtaining just a boolean indicating whether > properties exist on a node, instead of always obtaining the

RE: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

2015-04-13 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: maandag 13 april 2015 14:53 > To: dev@subversion.apache.org; Bert Huijben > Subject: Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ > libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ li

Re: svn commit: r1673202 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c

2015-04-13 Thread Ivan Zhakov
On 13 April 2015 at 17:22, wrote: > Author: rhuijben > Date: Mon Apr 13 14:22:33 2015 > New Revision: 1673202 > > URL: http://svn.apache.org/r1673202 > Log: > Following up on r1673197, use another optimization suggested by stefan2. > > * subversion/libsvn_fs_fs/dag.c > (svn_fs_fs__dag_has_props

Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

2015-04-13 Thread Ivan Zhakov
On 13 April 2015 at 17:41, Bert Huijben wrote: >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: maandag 13 april 2015 14:53 >> To: dev@subversion.apache.org; Bert Huijben >> Subject: Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ >> libs

RE: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

2015-04-13 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: maandag 13 april 2015 17:13 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ > libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_

Issue #4554, Wrong file length with PLAIN representations in FSFS

2015-04-13 Thread Julian Foad
r1654932 introduced into svn_fs_fs__file_length(): if data_rep->expanded_size is 0: /* ... A plain representation may specify its EXPANDED LENGTH as "0" in which case, the SIZE value is what we want. Because EXPANDED_LENGTH will also be 0 for empty files, while SI

Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

2015-04-13 Thread Ivan Zhakov
On 13 April 2015 at 19:05, Bert Huijben wrote: >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: maandag 13 april 2015 17:13 >> To: Bert Huijben >> Cc: dev@subversion.apache.org >> Subject: Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ >

Re: Issue #4554, Wrong file length with PLAIN representations in FSFS

2015-04-13 Thread Stefan Fuhrmann
On Mon, Apr 13, 2015 at 6:07 PM, Julian Foad wrote: > r1654932 introduced into svn_fs_fs__file_length(): > > if data_rep->expanded_size is 0: > /* ... A plain representation may specify its EXPANDED LENGTH as "0" > in which case, the SIZE value is what we want. > > Because

Re: svn commit: r1673202 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c

2015-04-13 Thread Stefan Fuhrmann
On Mon, Apr 13, 2015 at 5:01 PM, Ivan Zhakov wrote: > On 13 April 2015 at 17:22, wrote: > > Author: rhuijben > > Date: Mon Apr 13 14:22:33 2015 > > New Revision: 1673202 > > > > URL: http://svn.apache.org/r1673202 > > Log: > > Following up on r1673197, use another optimization suggested by stef

Re: Remaining suggested API changes for 1.9

2015-04-13 Thread Stefan Fuhrmann
On Fri, Apr 10, 2015 at 1:16 AM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > > * svn_relpath_limit > This is a useful API and it is simple enough that support > in future releases should not be a problem. So, keep it > in the public API. However, it should be renamed to > svn_

Re: svn commit: r1673202 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c

2015-04-13 Thread Ivan Zhakov
On 13 April 2015 at 20:13, Stefan Fuhrmann wrote: > On Mon, Apr 13, 2015 at 5:01 PM, Ivan Zhakov wrote: >> >> On 13 April 2015 at 17:22, wrote: >> > Author: rhuijben >> > Date: Mon Apr 13 14:22:33 2015 >> > New Revision: 1673202 >> > >> > URL: http://svn.apache.org/r1673202 >> > Log: >> > Follo

Re: Remaining suggested API changes for 1.9

2015-04-13 Thread Branko Čibej
On 13.04.2015 12:23, Stefan Fuhrmann wrote: > On Fri, Apr 10, 2015 at 1:16 AM, Stefan Fuhrmann > mailto:stefan.fuhrm...@wandisco.com>> > wrote: > > > * svn_relpath_limit > This is a useful API and it is simple enough that support > in future releases should not be a problem. So, kee

RE: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

2015-04-13 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: maandag 13 april 2015 18:55 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ > libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_

Re: Remaining suggested API changes for 1.9

2015-04-13 Thread Stefan Fuhrmann
On Mon, Apr 13, 2015 at 7:33 PM, Branko Čibej wrote: > On 13.04.2015 12:23, Stefan Fuhrmann wrote: > > On Fri, Apr 10, 2015 at 1:16 AM, Stefan Fuhrmann > > mailto:stefan.fuhrm...@wandisco.com>> > > wrote: > > > > > > * svn_relpath_limit > > This is a useful API and it is simple enough t

Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

2015-04-13 Thread Daniel Shahaf
Bert Huijben wrote on Mon, Apr 13, 2015 at 21:53:55 +0200: > Do you know where we document these properties? > (Or have a suggestion on where we should document them) I think historically our DAV protocol docs live in: notes/http-and-webdav/ (which is unlike FSFS, BDB, and svnserve, all of which

Re: svn commit: r1673204 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c

2015-04-13 Thread Daniel Shahaf
rhuij...@apache.org wrote on Mon, Apr 13, 2015 at 14:28:39 -: > - *has_props = (noderev->prop_rep->expanded_size > 4); > + *has_props = (noderev->prop_rep->expanded_size > 4 > +|| (noderev->prop_rep->expanded_size == 0 > +&& noderev->prop_re

Re: svn commit: r1673197 - in /subversion/trunk/subversion/libsvn_fs_fs: cached_data.h dag.c dag.h tree.c

2015-04-13 Thread Daniel Shahaf
rhuij...@apache.org wrote on Mon, Apr 13, 2015 at 13:58:29 -: > * subversion/libsvn_fs_fs/cached_data.h > (svn_fs_fs__has_props): New function. There is no matching definition anywhere. Remove the declaration?

Making EXPANDED_SIZE reliable in FSFS [was: svn commit: r1673204 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c]

2015-04-13 Thread Stefan Fuhrmann
On Mon, Apr 13, 2015 at 11:20 PM, Daniel Shahaf wrote: > rhuij...@apache.org wrote on Mon, Apr 13, 2015 at 14:28:39 -: > > - *has_props = (noderev->prop_rep->expanded_size > 4); > > + *has_props = (noderev->prop_rep->expanded_size > 4 > > +|| (noderev->prop_rep->

Re: Making EXPANDED_SIZE reliable in FSFS [was: svn commit: r1673204 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c]

2015-04-13 Thread Branko Čibej
On 13.04.2015 18:04, Stefan Fuhrmann wrote: > On Mon, Apr 13, 2015 at 11:20 PM, Daniel Shahaf > mailto:d...@daniel.shahaf.name>> wrote: > > rhuij...@apache.org wrote on Mon, Apr > 13, 2015 at 14:28:39 -: > > - *has_props = (noderev->prop_rep->expand

[l10n] Translation status report for trunk r1673353

2015-04-13 Thread Subversion Translation Status
Translation status report for trunk@r1673353 lang trans untrans fuzzy obs -- de2931 0 0 504 ++o es2284 647 856 530 ++U~~~ fr2590 341