Re: svn commit: r1634875 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2014-10-29 Thread Branko Čibej
On 28.10.2014 14:19, stef...@apache.org wrote: > Author: stefan2 > Date: Tue Oct 28 13:19:30 2014 > New Revision: 1634875 > > URL: http://svn.apache.org/r1634875 > Log: > Speed up packed revprop access by tuning the manifest file parser. [...] > +/* Return the minimum length of any packed revprop

Re: svn commit: r1634875 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2014-10-29 Thread Stefan Fuhrmann
On Wed, Oct 29, 2014 at 9:44 AM, Branko Čibej wrote: > On 28.10.2014 14:19, stef...@apache.org wrote: > > Author: stefan2 > > Date: Tue Oct 28 13:19:30 2014 > > New Revision: 1634875 > > > > URL: http://svn.apache.org/r1634875 > > Log: > > Speed up packed revprop access by tuning the manifest fil

Don't reject arguments of the form ".@PEG"

2014-10-29 Thread Julian Foad
An 'svn' command-line argument of the form ".@PEG" raises the error   svn: E125001: '@PEG' is just a peg revision. Maybe try '@PEG@' instead? That error is annoying to me, and unnecessary. This happens for pretty much any 'svn' command, with any path that is converted to "" on canonicalization

Re: svn commit: r1634875 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2014-10-29 Thread Branko Čibej
On 29.10.2014 12:21, Stefan Fuhrmann wrote: > > > On Wed, Oct 29, 2014 at 9:44 AM, Branko Čibej > wrote: > > On 28.10.2014 14:19, stef...@apache.org > wrote: > > Author: stefan2 > > Date: Tue Oct 28 13:19:30 2014 > > New Re

Re: Don't reject arguments of the form ".@PEG"

2014-10-29 Thread Julian Foad
I (Julian Foad) wrote: > An 'svn' command-line argument of the form ".@PEG" raises the error > >   svn: E125001: '@PEG' is just a peg revision. Maybe try '@PEG@' instead? [...] > I intend to correct this, to make arguments of the form ".@PEG" > syntactically acceptable. Committed r1635118. - Ju

Re: Don't reject arguments of the form ".@PEG"

2014-10-29 Thread Stefan Sperling
On Wed, Oct 29, 2014 at 12:22:50PM +, Julian Foad wrote: > An 'svn' command-line argument of the form ".@PEG" raises the error > >   svn: E125001: '@PEG' is just a peg revision. Maybe try '@PEG@' instead? > > That error is annoying to me, and unnecessary. > > This happens for pretty much any

Re: Don't reject arguments of the form ".@PEG"

2014-10-29 Thread Stefan Sperling
On Wed, Oct 29, 2014 at 01:04:21PM +, Julian Foad wrote: > I (Julian Foad) wrote: > > An 'svn' command-line argument of the form ".@PEG" raises the error > > > >   svn: E125001: '@PEG' is just a peg revision. Maybe try '@PEG@' instead? > [...] > > I intend to correct this, to make arguments of

Re: Don't reject arguments of the form ".@PEG"

2014-10-29 Thread Julian Foad
Stefan Sperling wrote: > On Wed, Oct 29, 2014 at 01:04:21PM +, Julian Foad wrote: >> I (Julian Foad) wrote: >>> An 'svn' command-line argument of the form ".@PEG" raises the error >>> >>>   svn: E125001: '@PEG' is just a peg revision. Maybe try '@PEG@' instead? >> [...] >>> I intend to correct

Re: Don't reject arguments of the form ".@PEG"

2014-10-29 Thread Stefan Sperling
On Wed, Oct 29, 2014 at 01:26:26PM +, Julian Foad wrote: > The change to svn_client_args_to_target_array2 is relaxing an error behaviour > that it didn't document in the first place. All usage that worked (didn't > error) before will still work. It seems unlikely that anything is relying on

Re: Don't reject arguments of the form ".@PEG"

2014-10-29 Thread Julian Foad
I (Julian Foad) wrote: >> Don't you think we should bump the API for this? > > The change to svn_client_args_to_target_array2 is relaxing an error behaviour > that it didn't document in the first place. All usage that worked > (didn't error) before will still work. It seems unlikely that anythin

Re: Some x509 branch review points

2014-10-29 Thread Ben Reser
On 10/15/14 3:15 AM, Philip Martin wrote: > 1) > > In x509parse.c:x509_get_version: > > err = asn1_get_tag(p, end, &len, > ASN1_CONTEXT_SPECIFIC | ASN1_CONSTRUCTED | 0); > > Why the "| 0"? It doesn't do anything. The 0 is there to say that the context specific value is 0

Re: svn commit: r1634906 - in /subversion/branches/svn-auth-x509/subversion: include/svn_x509.h libsvn_subr/x509.h libsvn_subr/x509info.c libsvn_subr/x509parse.c svn/auth-cmd.c tests/libsvn_subr/x509-

2014-10-29 Thread Ben Reser
On 10/28/14 9:26 AM, Branko Čibej wrote: > Indentation is wrong. Whoops, somehow my code style setting got disabled when I wrote this and didn't notice it. Fixed in r1635359. > And I suggest using svn_iter_apr_array here. > ... and svn_iter_apr_hash here. Unless it's a big deal to you I'm not i

Re: svn commit: r1634906 - in /subversion/branches/svn-auth-x509/subversion: include/svn_x509.h libsvn_subr/x509.h libsvn_subr/x509info.c libsvn_subr/x509parse.c svn/auth-cmd.c tests/libsvn_subr/x509-

2014-10-29 Thread Branko Čibej
On 30.10.2014 02:00, Ben Reser wrote: > On 10/28/14 9:26 AM, Branko Čibej wrote: >> Indentation is wrong. > Whoops, somehow my code style setting got disabled when I wrote this and > didn't > notice it. Fixed in r1635359. > >> And I suggest using svn_iter_apr_array here. >> ... and svn_iter_apr_h

Re: svn:mime-type arbitrary parameters

2014-10-29 Thread Sean Leonard
On Oct 26, 2014, at 11:35 AM, Branko Čibej wrote: > On 26.10.2014 16:06, Sean Leonard wrote: >> On 10/26/2014 3:21 AM, Branko Čibej wrote: >>> On 26.10.2014 05:49, Sean Leonard wrote: On 10/25/2014 5:59 PM, Branko Čibej wrote: > On 25.10.2014 20:53, Sean Leonard wrote: >> It appears