Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

On 2 August 2014 18:45, Branko Čibej wrote: > On 02.08.2014 15:20, Alan Barrett wrote: > > On Tue, 29 Jul 2014, C. Michael Pilato wrote: > > This leaves open the possibility of a future additional match mode for > regular expressions (using the '^:' magic prefix) should we seek to "go > there". >

Re: [PATCH] remove svn__strtol() and svn__strtoul()

On 6 August 2014 19:57, Stefan Sperling wrote: > On Wed, Aug 06, 2014 at 07:31:04PM +0400, Ivan Zhakov wrote: >> apr_get_os_error() uses GetLastError() on Windows, while strtol() uses >> standard errno for error code. > > So you're saying code like this works on Windows, and I shouldn't > be using

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 6 August 2014 09:49, Ben Reser wrote: > I believe the svn-auth-x509 branch is ready to be merged to trunk. There is > no > BRANCH-README so I'll briefly explain the purpose of the branch. > > Currently on trunk we have the `svn auth` command that can list out the > contents of the auth store.

Re: [PATCH] remove svn__strtol() and svn__strtoul()

On 07.08.2014 08:52, Stefan Sperling wrote: > On Thu, Aug 07, 2014 at 01:34:40AM +0200, Branko Čibej wrote: >> On 06.08.2014 23:23, Stefan Sperling wrote: >>> How about I commit my patch, and then someone else (you? Bert?) tunes >>> the implementations of svn_cstring_atoi*, perhaps reusing code fro

Re: [PATCH] remove svn__strtol() and svn__strtoul()

On Thu, Aug 07, 2014 at 02:27:15PM +0200, Branko Čibej wrote: > On 07.08.2014 08:52, Stefan Sperling wrote: > > On Thu, Aug 07, 2014 at 01:34:40AM +0200, Branko Čibej wrote: > >> On 06.08.2014 23:23, Stefan Sperling wrote: > >>> How about I commit my patch, and then someone else (you? Bert?) tunes

Re: svn commit: r1614080 - in /subversion/branches/authzperf: BRANCH-README subversion/libsvn_repos/authz.c subversion/libsvn_subr/config.c subversion/libsvn_subr/config_impl.h

On 07.08.2014 10:30, Ivan Zhakov wrote: > On 2 August 2014 18:45, Branko Čibej wrote: >> On 02.08.2014 15:20, Alan Barrett wrote: >> >> On Tue, 29 Jul 2014, C. Michael Pilato wrote: >> >> This leaves open the possibility of a future additional match mode for >> regular expressions (using the '^:'

Re: 1.8.10 up for testing/signing

On 2 August 2014 05:33, Ben Reser wrote: > The 1.8.10 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on August 11th so > please try and get you

Re: [PATCH] remove svn__strtol() and svn__strtoul()

On 07.08.2014 14:35, Stefan Sperling wrote: > On Thu, Aug 07, 2014 at 02:27:15PM +0200, Branko Čibej wrote: >> On 07.08.2014 08:52, Stefan Sperling wrote: >>> On Thu, Aug 07, 2014 at 01:34:40AM +0200, Branko Čibej wrote: On 06.08.2014 23:23, Stefan Sperling wrote: > How about I commit my p

Re: 1.7.18 up for testing/signing

Summary: +1 to release Platform: Linux (Debian/wheezy) 64-bit Tested: (local, svn, svn/sasl, neon, serf, serf/v1) x (fsfs, fsfs/pack/shard, bdb) swig-pl, swig-py, swig-rb, ctypes-python javahl x (fsfs, bdb) Results: All tests successful apart from known failures in the Ruby tests

Re: 1.8.10 up for testing/signing

On 8/1/14 6:33 PM, Ben Reser wrote: > The 1.8.10 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on August 11th so > please try and get your vote

Re: 1.8.10 up for testing/signing

On 07.08.2014 16:55, Ben Reser wrote: > On 8/1/14 6:33 PM, Ben Reser wrote: >> The 1.8.10 release artifacts are now available for testing/signing. >> Please get the tarballs from >> https://dist.apache.org/repos/dist/dev/subversion >> and add your signatures there. I plan to try and release on A

Re: 1.8.10 up for testing/signing

On Thu, Aug 7, 2014 at 10:55 AM, Ben Reser wrote: > On 8/1/14 6:33 PM, Ben Reser wrote: >> The 1.8.10 release artifacts are now available for testing/signing. >> Please get the tarballs from >> https://dist.apache.org/repos/dist/dev/subversion >> and add your signatures there. I plan to try and

Re: 1.7.18 up for testing/signing

On 8/1/14 6:32 PM, Ben Reser wrote: > The 1.7.18 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on August 11th so > please try and get your vote

Re: 1.7.18 up for testing/signing

On 2 August 2014 05:32, Ben Reser wrote: > The 1.7.18 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on August 11th so > please try and get you

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 8/6/14 2:09 PM, Stefan Fuhrmann wrote: > What would a worst-case failure scenario look like? Could a faulty > parser result in the auth store reporting keys that the user does not > want to trust (e.g. by stitching together random portions of the file)? I'll go ahead and answer the question I t

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 8/7/14 4:10 AM, Ivan Zhakov wrote: > Several comments on branch code itself: > 1. Probably it makes sense to do not deprecate > svn_checksum_to_cstring_display() or have local x509 implementation > for fingerprint formatting because we use > svn_checksum_to_cstring_display() as canonical represe

Re: 1.8.10 up for testing/signing

On 8/7/14 8:05 AM, Paul Burba wrote: > I'll have windows test results incoming at some point today. Same for 1.7.18. Thanks Paul, it's greatly appreciated.

RE: 1.7.18 up for testing/signing

> -Original Message- > From: Ben Reser [mailto:b...@reser.org] > Sent: donderdag 7 augustus 2014 17:07 > To: Subversion Development > Subject: Re: 1.7.18 up for testing/signing > > On 8/1/14 6:32 PM, Ben Reser wrote: > > The 1.7.18 release artifacts are now available for testing/signing.

RE: 1.8.10 up for testing/signing

> -Original Message- > From: Ben Reser [mailto:b...@reser.org] > Sent: donderdag 7 augustus 2014 16:55 > To: Subversion Development > Subject: Re: 1.8.10 up for testing/signing > > On 8/1/14 6:33 PM, Ben Reser wrote: > > The 1.8.10 release artifacts are now available for testing/signing.

Re: 1.8.10 up for testing/signing

On Fri, Aug 1, 2014 at 9:33 PM, Ben Reser wrote: > The 1.8.10 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on August 11th so > please try and

Re: 1.7.18 up for testing/signing

On Fri, Aug 1, 2014 at 9:32 PM, Ben Reser wrote: > The 1.7.18 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on August 11th so > please try and

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 07.08.2014 19:03, Ben Reser wrote: > This appears to be because pointers are unsigned and apr_size_t is signed. You mean the other way around, surely. > Guess we can just cast the pointer arithmetic to apr_size_t. So they end up > looking like this respectively: > > if (*len > (apr_size_t)(en

Re: svn commit: r1616600 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_fs_x/pack.c libsvn_fs_x/reps.c libsvn_fs_x/reps.h tests/libsvn_fs_x/fs-x-pack-test.c

On 07.08.2014 23:35, stef...@apache.org wrote: > Author: stefan2 > Date: Thu Aug 7 21:35:01 2014 > New Revision: 1616600 > > URL: http://svn.apache.org/r1616600 > Log: > Explicitly limit the dimensions of a star delta container which allows us > to cast sizes to 32 bits. Can we explicitly use 32-

Re: svn commit: r1616600 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_fs_x/pack.c libsvn_fs_x/reps.c libsvn_fs_x/reps.h tests/libsvn_fs_x/fs-x-pack-test.c

On Thu, Aug 7, 2014 at 11:49 PM, Branko Čibej wrote: > On 07.08.2014 23:35, stef...@apache.org wrote: > > Author: stefan2 > Date: Thu Aug 7 21:35:01 2014 > New Revision: 1616600 > > URL: http://svn.apache.org/r1616600 > Log: > Explicitly limit the dimensions of a star delta container which allo

Re: svn commit: r1616600 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_fs_x/pack.c libsvn_fs_x/reps.c libsvn_fs_x/reps.h tests/libsvn_fs_x/fs-x-pack-test.c

On 08.08.2014 00:05, Stefan Fuhrmann wrote: > > > > On Thu, Aug 7, 2014 at 11:49 PM, Branko Čibej > wrote: > > On 07.08.2014 23:35, stef...@apache.org > wrote: >> Author: stefan2 >> Date: Thu Aug 7 21:35:01 2014 >> New Rev

Re: fsfs block size and page size config parameters

On Mon, Jun 30, 2014 at 6:33 PM, Julian Foad wrote: > Hi Stefan. > > fs_fs.c: > > "### When a specific piece of information needs to be read from disk, > a"NL > > "### data block is being read at once and its contents are being > cached."NL > > "### ... > > "### block-size is 64 kBytes by

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 8/7/14 12:16 PM, Branko Čibej wrote: > On 07.08.2014 19:03, Ben Reser wrote: >> This appears to be because pointers are unsigned and apr_size_t is signed. > > You mean the other way around, surely. Yes, thinko. >> Guess we can just cast the pointer arithmetic to apr_size_t. So they end up >>

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 8/7/14 4:34 PM, Ben Reser wrote: > I expected that change would just shift the warnings around but it removes the > warnings entirely. I'm still not sure it's right. We're setting a ptrdiff_t > with the value from an apr_size_t. Shouldn't that result in a possible loss > of > data since we'r

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 8/5/14 10:49 PM, Ben Reser wrote: > I believe the svn-auth-x509 branch is ready to be merged to trunk. There is > no > BRANCH-README so I'll briefly explain the purpose of the branch. Cleaned up several warnings based on feedback from Ivan and things I found while looking at that as of r16166

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 08.08.2014 01:34, Ben Reser wrote: > On 8/7/14 12:16 PM, Branko Čibej wrote: >> On 07.08.2014 19:03, Ben Reser wrote: >>> This appears to be because pointers are unsigned and apr_size_t is signed. >> You mean the other way around, surely. > Yes, thinko. > >>> Guess we can just cast the pointer a

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 8/7/14 5:58 PM, Branko Čibej wrote: > I've seen platforms where size_t was smaller than ptrdiff_t; but usually > they're the same size. The rules of type promotion in C state that an a value > of a signed type can be promoted to a value of the same-sized unsigned type > without truncation, where

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

On 08.08.2014 03:43, Ben Reser wrote: > On 8/7/14 5:58 PM, Branko Čibej wrote: >> I've seen platforms where size_t was smaller than ptrdiff_t; but usually >> they're the same size. The rules of type promotion in C state that an a value >> of a signed type can be promoted to a value of the same-size