Re: Log-addressing branch ready for review

2013-12-02 Thread Stefan Fuhrmann
On Wed, Nov 27, 2013 at 6:55 PM, Julian Foad wrote: > Stefan Fuhrmann wrote: > > As of r1516665, work on this branch has been completed. > > Please review. See the BRANCH-README for the list of > > major changes. > > I have not reviewed, but looked at how to review it. > > First I am l

Re: Specifying commit timestamps over RA

2013-12-02 Thread Philip Martin
Daniel Shahaf writes: > Stefan Fuhrmann wrote on Thu, Nov 28, 2013 at 08:02:49 +0100: >> On Wed, Nov 27, 2013 at 11:34 PM, Philip Martin >> wrote: >> >> I'm a bit relucant to use them because I'm not altogether happy with the >> > way they are removed from the transaction before we know whether

Re: Specifying commit timestamps over RA

2013-12-02 Thread Philip Martin
Julian Foad writes: > Philip Martin wrote: >> We need some indication that the client has explicitly set svn:date, >> including deleting it to indicate a revision with no date. > > How would a client indicate that it wants the commit to have no date > property at all? At the FS level no date is

Re: Specifying commit timestamps over RA

2013-12-02 Thread Philip Martin
Ivan Zhakov writes: > While I added svn_fs_commit_txn2() function I think it should not be > exposed through svn_repos_* and RA layer. Is there a reason this was implemented as svn_fs_commit_txn2 rather than as another flag passed to svn_fs_begin_txn2? They seem to be equivalent but the flags m

Re: Log-addressing branch ready for review

2013-12-02 Thread Julian Foad
Stefan Fuhrmann wrote: > On Wed, Nov 27, 2013 at 6:55 PM, Julian Foad wrote: >> Stefan Fuhrmann wrote: >>> As of r1516665, work on this branch has been completed. >>> Please review. See the BRANCH-README for the list of >>> major changes. >> >> First I am looking for an overall descrip

[PATCH] Fix broken 'svnadmin create --pre-1.x-compatible'

2013-12-02 Thread Evgeny Kotkov
Hi, I've noticed that running 'svnadmin create --pre-1.4-compatible REPOS_NAME' around trunk@r1546963 incorrectly errors out: [[[ svnadmin: E200037: Failed to parse version number string '1.3.0(null)' svnadmin: E24: Could not convert '0(null)' into a number ]]] This error happens with every -

Re: [PATCH] Fix broken 'svnadmin create --pre-1.x-compatible'

2013-12-02 Thread Philip Martin
Evgeny Kotkov writes: > This error happens with every --pre-1.x-compatible option and is a regression > against 1.8.x introduced in r1509915 [1]. I've attached a patch to fix this > problem. Applied. Thanks! -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: Specifying commit timestamps over RA

2013-12-02 Thread C. Michael Pilato
On 12/02/2013 04:32 AM, Philip Martin wrote: > Daniel Shahaf writes: > >> Stefan Fuhrmann wrote on Thu, Nov 28, 2013 at 08:02:49 +0100: >>> On Wed, Nov 27, 2013 at 11:34 PM, Philip Martin >>> wrote: >>> >>> I'm a bit relucant to use them because I'm not altogether happy with the way they are

Re: svn commit: r1547045 [1/4] - in /subversion/trunk: ./ subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/ subversion/tests/libsvn_fs_fs/ tools/server-side/

2013-12-02 Thread Ivan Zhakov
On 2 December 2013 18:55, wrote: > Author: stefan2 > Date: Mon Dec 2 14:55:20 2013 > New Revision: 1547045 > > URL: http://svn.apache.org/r1547045 > Log: > Merge FSFS format 7 into /trunk, i.e. everything from the > fsfs-improvements branch. There were no conflicts. Hi Stefan, Could you please

Re: svn commit: r1547045 [1/4] - in /subversion/trunk: ./ subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/ subversion/tests/libsvn_fs_fs/ tools/server-side/

2013-12-02 Thread Stefan Fuhrmann
On Mon, Dec 2, 2013 at 4:22 PM, Ivan Zhakov wrote: > On 2 December 2013 18:55, wrote: > > Author: stefan2 > > Date: Mon Dec 2 14:55:20 2013 > > New Revision: 1547045 > > > > URL: http://svn.apache.org/r1547045 > > Log: > > Merge FSFS format 7 into /trunk, i.e. everything from the > > fsfs-impr

Re: svn commit: r1547045 [1/4] - in /subversion/trunk: ./ subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/ subversion/tests/libsvn_fs_fs/ tools/server-side/

2013-12-02 Thread Ivan Zhakov
On 2 December 2013 19:37, Stefan Fuhrmann wrote: > On Mon, Dec 2, 2013 at 4:22 PM, Ivan Zhakov wrote: >> >> On 2 December 2013 18:55, wrote: >> > Author: stefan2 >> > Date: Mon Dec 2 14:55:20 2013 >> > New Revision: 1547045 >> > >> > URL: http://svn.apache.org/r1547045 >> > Log: >> > Merge FSF

Re: svn commit: r1547045 [1/4] - in /subversion/trunk: ./ subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/ subversion/tests/libsvn_fs_fs/ tools/server-side/

2013-12-02 Thread Julian Foad
Ivan Zhakov wrote: > On 2 December 2013 19:37, Stefan Fuhrmann wrote: >> On Mon, Dec 2, 2013 at 4:22 PM, Ivan Zhakov wrote: URL: http://svn.apache.org/r1547045 Log: Merge FSFS format 7 into /trunk, i.e. everything from the fsfs-improvements branch. There were no conflicts. >>>

Re: svn commit: r1547045 [1/4] - in /subversion/trunk: ./ subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/ subversion/tests/libsvn_fs_fs/ tools/server-side/

2013-12-02 Thread Stefan Fuhrmann
On Mon, Dec 2, 2013 at 5:55 PM, Julian Foad wrote: > Ivan Zhakov wrote: > > > On 2 December 2013 19:37, Stefan Fuhrmann wrote: > >> On Mon, Dec 2, 2013 at 4:22 PM, Ivan Zhakov wrote: > URL: http://svn.apache.org/r1547045 > Log: > Merge FSFS format 7 into /trunk, i.e. everything fro