Re: svn commit: r1101635 - /subversion/trunk/subversion/libsvn_client/merge.c

2011-05-11 Thread Greg Stein
On Tue, May 10, 2011 at 16:31, wrote: >... > +++ subversion/trunk/subversion/libsvn_client/merge.c Tue May 10 20:31:32 2011 >... > @@ -4619,9 +4626,10 @@ record_skips(const char *mergeinfo_path, >            ### skipped? */ >         ; >     } > +  svn_pool_destroy(iterpool); >   SVN_ERR(update_w

Re: svn commit: r1101578 [2/2] - /subversion/trunk/subversion/libsvn_client/merge.c

2011-05-11 Thread Greg Stein
On Tue, May 10, 2011 at 14:14, wrote: >... > +++ subversion/trunk/subversion/libsvn_client/merge.c Tue May 10 18:14:22 2011 >... > @@ -2989,14 +2997,15 @@ fix_deleted_subtree_ranges(const char *u >                            svn_ra_session_t *ra_session, >                            notification_

WC-NG, externals and fast properties

2011-05-11 Thread Hans-Emil Skogh
Hi all! I noticed recently that the behavior when working with externals have changed in SVN 1.7. Local changes to the svn:externals property in the working copy is by default not honored during an update, before a commit. I think this is quite unfortunate.* As I understand these changes were

RE: WC-NG, externals and fast properties

2011-05-11 Thread Bert Huijben
> -Original Message- > From: Hans-Emil Skogh [mailto:hans-emil.sk...@tritech.se] > Sent: woensdag 11 mei 2011 10:03 > To: dev@subversion.apache.org > Subject: WC-NG, externals and fast properties > > Hi all! > > I noticed recently that the behavior when working with externals have > cha

Re: svn commit: r1101091 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

2011-05-11 Thread Julian Foad
On Tue, 2011-05-10, Stefan Fuhrmann wrote: > So, I found out what happened: The *IDE* (editor) complained > about the assignment and thus I "fixed" it without checking the > compiler log. > > The compiler is happy without the cast and r1101616. Thanks Stefan. - Julian

Re: AW: Python bindings: Use of svn_swig_py_make_stream() - avoiding leaking fds

2011-05-11 Thread Nick Piper
On 10/05/11 16:08, Bert Huijben wrote: > The python bindings need it, so I would say: Add it there. The attached patch fixes the FD leak entirely within the Python bindings. > (And maybe make it easier to use from other bindings when it proves useful. > That is why I suggested adding the func

RE: svn commit: r1101833 - in /subversion/trunk/subversion/tests/cmdline: revert_tests.py svntest/actions.py

2011-05-11 Thread Bert Huijben
> -Original Message- > From: sbut...@apache.org [mailto:sbut...@apache.org] > Sent: woensdag 11 mei 2011 12:59 > To: comm...@subversion.apache.org > Subject: svn commit: r1101833 - in > /subversion/trunk/subversion/tests/cmdline: revert_tests.py > svntest/actions.py > > Author: sbutler >

RE: [svnbench] Revision: 1101392 compiled May 10 2011, 10:07:15

2011-05-11 Thread Neels Hofmeyr
On Wed, 2011-05-11 at 02:02 +0200, Bert Huijben wrote: > > > -Original Message- > > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > > Are you sure? The script's output seems a little bit too consistent: > > > > ne...@apache.org wrote on Tue, May 10, 2011 at 11:57:35 +: > > > (

Re: svn commit: r1101848 - in /subversion/trunk/subversion/libsvn_wc: cleanup.c wc-queries.sql wc_db.c wc_db.h

2011-05-11 Thread Greg Stein
Need to clear iterpool... On May 11, 2011 7:58 AM, wrote: > Author: julianfoad > Date: Wed May 11 11:58:11 2011 > New Revision: 1101848 > > URL: http://svn.apache.org/viewvc?rev=1101848&view=rev > Log: > Implement some (initially very simplistic) verification of the WC metadata > in the DB. When c

Re: svn commit: r1101848 - in /subversion/trunk/subversion/libsvn_wc: cleanup.c wc-queries.sql wc_db.c wc_db.h

2011-05-11 Thread Julian Foad
Greg Stein wrote: > Need to clear iterpool... r1101857. Thanks, - Julian

Re: [svnbench] Revision: 1101392 compiled May 10 2011, 10:07:15

2011-05-11 Thread Daniel Shahaf
Neels Hofmeyr wrote on Wed, May 11, 2011 at 14:01:08 +0200: > On Wed, 2011-05-11 at 02:02 +0200, Bert Huijben wrote: > > > > > -Original Message- > > > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > > > Are you sure? The script's output seems a little bit too consistent: > > > >

Re: svn commit: r1101836 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-05-11 Thread C. Michael Pilato
On 05/11/2011 07:25 AM, phi...@apache.org wrote: > Author: philip > Date: Wed May 11 11:25:06 2011 > New Revision: 1101836 > > URL: http://svn.apache.org/viewvc?rev=1101836&view=rev > Log: > Remove the now-badly-named scan_upwards_for_repos function and > call the general base_get_info instead. >

RE: WC-NG, externals and fast properties

2011-05-11 Thread Hans-Emil Skogh
Thanks for your quick and detailed response! >> I noticed recently that the behavior when working with externals have >> changed in SVN 1.7. Local changes to the svn:externals property in the >> working copy is by default not honored during an update, before a commit. > There are fundamental probl

RE: WC-NG, externals and fast properties

2011-05-11 Thread Bert Huijben
> -Original Message- > From: Hans-Emil Skogh [mailto:hans-emil.sk...@tritech.se] > Sent: woensdag 11 mei 2011 15:48 > To: dev@subversion.apache.org > Subject: RE: WC-NG, externals and fast properties > > Thanks for your quick and detailed response! > > >> I noticed recently that the beh

Our issue tracker -- a plea

2011-05-11 Thread C. Michael Pilato
Lately, I've been concerned that we as a community have forgotten how powerful a collaboration tool our issue tracker is. This is my earnest request for all of us to return our tracker to a more central position in our day-to-day routines. Now, we've been doing a little better lately about our mi

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Daniel Shahaf
cmpil...@apache.org wrote on Wed, May 11, 2011 at 15:20:46 -: > Author: cmpilato > Date: Wed May 11 15:20:46 2011 > New Revision: 1101918 > > URL: http://svn.apache.org/viewvc?rev=1101918&view=rev > Log: > Fix issue #3874 ("Unhandled serf_bucket_response_status errors"). > > * subversion/libs

Re: svn commit: r1101578 [2/2] - /subversion/trunk/subversion/libsvn_client/merge.c

2011-05-11 Thread Paul Burba
On Wed, May 11, 2011 at 3:25 AM, Greg Stein wrote: > On Tue, May 10, 2011 at 14:14,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_client/merge.c Tue May 10 18:14:22 >> 2011 >>... >> @@ -2989,14 +2997,15 @@ fix_deleted_subtree_ranges(const char *u >>                            svn_ra_se

Re: svn commit: r1101635 - /subversion/trunk/subversion/libsvn_client/merge.c

2011-05-11 Thread Paul Burba
On Wed, May 11, 2011 at 3:01 AM, Greg Stein wrote: > On Tue, May 10, 2011 at 16:31,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_client/merge.c Tue May 10 20:31:32 >> 2011 >>... >> @@ -4619,9 +4626,10 @@ record_skips(const char *mergeinfo_path, >>            ### skipped? */ >>        

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread C. Michael Pilato
On 05/11/2011 12:00 PM, Daniel Shahaf wrote: > cmpil...@apache.org wrote on Wed, May 11, 2011 at 15:20:46 -: >> Author: cmpilato >> Date: Wed May 11 15:20:46 2011 >> New Revision: 1101918 >> >> URL: http://svn.apache.org/viewvc?rev=1101918&view=rev >> Log: >> Fix issue #3874 ("Unhandled serf_bu

Re: svn commit: r1101578 [2/2] - /subversion/trunk/subversion/libsvn_client/merge.c

2011-05-11 Thread Greg Stein
On May 11, 2011 12:33 PM, "Paul Burba" wrote: > > On Wed, May 11, 2011 at 3:25 AM, Greg Stein wrote: > > On Tue, May 10, 2011 at 14:14, wrote: > >>... > >> +++ subversion/trunk/subversion/libsvn_client/merge.c Tue May 10 18:14:22 2011 > >>... > >> @@ -2989,14 +2997,15 @@ fix_deleted_subtree_ran

RE: WC-NG, externals and fast properties

2011-05-11 Thread Greg Stein
Bert: this design was not clear to me until you explained it below. Hyrum has already asked for something in notes/ to help the rest of us out. Could you do that? On May 11, 2011 10:52 AM, "Bert Huijben" wrote: > > >> -Original Message- >> From: Hans-Emil Skogh [mailto:hans-emil.sk...@tri

Re: svn commit: r1101868 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

2011-05-11 Thread Greg Stein
On May 11, 2011 9:24 AM, wrote: >... > +++ subversion/trunk/subversion/libsvn_subr/cache-membuffer.c Wed May 11 13:23:47 2011 > @@ -881,7 +881,7 @@ static void* secure_aligned_alloc(apr_po > void* memory = apr_palloc(pool, size + ITEM_ALIGNMENT); I know this wasn't part of your change, Philip,

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Greg Stein
On May 11, 2011 2:05 PM, "C. Michael Pilato" wrote: > > On 05/11/2011 12:00 PM, Daniel Shahaf wrote: >... > > > > When wrapping apr_status_t's returned by serf, shouldn't we decorate > > them in some way so that code that interprets them knows to look them up > > in serf.h:SERF_ERROR_* rather than

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Daniel Shahaf
I can look into the svn parts once you deal with the serf parts. Greg Stein wrote on Wed, May 11, 2011 at 15:35:19 -0400: > On May 11, 2011 2:05 PM, "C. Michael Pilato" wrote: > > > > On 05/11/2011 12:00 PM, Daniel Shahaf wrote: > >... > > > > > > When wrapping apr_status_t's returned by serf, sh

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Daniel Shahaf
Greg Stein wrote on Wed, May 11, 2011 at 15:35:19 -0400: > On May 11, 2011 2:05 PM, "C. Michael Pilato" wrote: > > > > On 05/11/2011 12:00 PM, Daniel Shahaf wrote: > >... > > > > > > When wrapping apr_status_t's returned by serf, shouldn't we decorate > > > them in some way so that code that inter

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Branko Čibej
On 11.05.2011 22:11, Daniel Shahaf wrote: > Greg Stein wrote on Wed, May 11, 2011 at 15:35:19 -0400: >> On May 11, 2011 2:05 PM, "C. Michael Pilato" wrote: >>> On 05/11/2011 12:00 PM, Daniel Shahaf wrote: >>> ... When wrapping apr_status_t's returned by serf, shouldn't we decorate them i

Re: WC-NG, externals and fast properties

2011-05-11 Thread Daniel Becroft
On Thu, May 12, 2011 at 12:12 AM, Bert Huijben wrote: > > > > -Original Message- > > From: Hans-Emil Skogh [mailto:hans-emil.sk...@tritech.se] > > Sent: woensdag 11 mei 2011 15:48 > > To: dev@subversion.apache.org > > Subject: RE: WC-NG, externals and fast properties > > > > Thanks for yo

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Daniel Shahaf
Branko Čibej wrote on Wed, May 11, 2011 at 22:15:58 +0200: > On 11.05.2011 22:11, Daniel Shahaf wrote: > > Greg Stein wrote on Wed, May 11, 2011 at 15:35:19 -0400: > >> On May 11, 2011 2:05 PM, "C. Michael Pilato" wrote: > >>> On 05/11/2011 12:00 PM, Daniel Shahaf wrote: > >>> ... > When wrap

RE: WC-NG, externals and fast properties

2011-05-11 Thread Bert Huijben
If you have the A->B->C path then that external to ^/tags/release-1.1.1 would be removed for you and a new external svn://server2/repos2/tags.1.2.2 would be checked out in its place. (Assuming that there are no changes in that external, no user action required. Otherwise you would have some unvers

RE: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: woensdag 11 mei 2011 22:41 > To: Branko Čibej > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1101918 - in > /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c > > Branko Čib

Re: Do we better tolerate obstructed updates?

2011-05-11 Thread Paul Burba
On Tue, May 10, 2011 at 5:34 AM, Neels Hofmeyr wrote: > I'd like to drop a hint at > >  notes/tree-conflicts/all-add-vs-add-tree-conflicts.txt > > where I tabled up the TC cases that I changed. AFAIR it wasn't quite > where I wanted it when my activity faded, so unless others have covered > the ':

1.7 Performance via HTTP

2011-05-11 Thread Mark Phippard
I ran the benchmark tests again using latest trunk for server and client. The numbers are interesting. See them here so you can see table formatting: https://ctf.open.collab.net/sf/wiki/do/viewPage/projects.csvn/wiki/HTTPv2 Using Neon, performance is improved across the board. In some cases, s

Re: svn commit: r1101918 - in /subversion/trunk/subversion/libsvn_ra_serf: locks.c update.c util.c

2011-05-11 Thread Greg Stein
On Wed, May 11, 2011 at 17:20, Bert Huijben wrote: > > >> -Original Message- >> From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] >> Sent: woensdag 11 mei 2011 22:41 >> To: Branko Čibej >> Cc: dev@subversion.apache.org >> Subject: Re: svn commit: r1101918 - in >> /subversion/trunk/subve

Re: svn commit: r1102060 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c

2011-05-11 Thread Daniel Shahaf
julianf...@apache.org wrote on Wed, May 11, 2011 at 20:11:52 -: > Author: julianfoad > Date: Wed May 11 20:11:51 2011 > New Revision: 1102060 > > URL: http://svn.apache.org/viewvc?rev=1102060&view=rev > Log: > Code simplification. > > * /home/julianfoad/src/subversion-d/subversion/libsvn_ra_s

Re: 1.7 Performance via HTTP

2011-05-11 Thread Ivan Zhakov
On Thu, May 12, 2011 at 03:40, Mark Phippard wrote: > I ran the benchmark tests again using latest trunk for server and > client.  The numbers are interesting.  See them here so you can see > table formatting: > > https://ctf.open.collab.net/sf/wiki/do/viewPage/projects.csvn/wiki/HTTPv2 > > Using

Re: 1.7 Performance via HTTP

2011-05-11 Thread Justin Erenkrantz
On Wed, May 11, 2011 at 4:40 PM, Mark Phippard wrote: > The story using Serf is not as good.  There are a few places where it > is fastest, namely merge.  But there are other cases where it is > dramatically slower.  The number of HTTP requests with Serf is 80,990. >  Looking at the numbers, it se

Re: svn commit: r1102173 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2011-05-11 Thread Ivan Zhakov
On Thu, May 12, 2011 at 09:54, wrote: > Author: jerenkrantz > Date: Thu May 12 05:54:46 2011 > New Revision: 1102173 > > URL: http://svn.apache.org/viewvc?rev=1102173&view=rev > Log: > ra_serf: Tell the server it is okay to gzip the REPORT response. > > For a simple checkout (notes dir in SVN), t

Re: svn commit: r1102173 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2011-05-11 Thread Justin Erenkrantz
On Wed, May 11, 2011 at 11:13 PM, Ivan Zhakov wrote: > There is configuration option in servers file. ra_serf should enable > compression only if option is enabled. r1102178. Thanks! -- justin