[PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Arwin Arni
Hi All, This patch adds a test case to subversion/tests/cmdline/dav-mirror-autocheck.sh to showcase the following bug. In a master/slave repositories setup where writes are proxied to the master and reads are handles by the slave repository, if the slave repository is behind the master by o

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Daniel Shahaf
On Mon, 18 Apr 2011 16:05 +0530, "Arwin Arni" wrote: > Hi All, > > This patch adds a test case to > subversion/tests/cmdline/dav-mirror-autocheck.sh to showcase the > following bug. > > In a master/slave repositories setup where writes are proxied to the > master and reads are handles by the

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Daniel Shahaf
On Mon, 18 Apr 2011 13:51 +0300, "Daniel Shahaf" wrote: > On Mon, 18 Apr 2011 16:05 +0530, "Arwin Arni" wrote: > > Hi All, > > > > This patch adds a test case to > > subversion/tests/cmdline/dav-mirror-autocheck.sh to showcase the > > following bug. > > > > In a master/slave repositories set

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Mark Phippard
On Mon, Apr 18, 2011 at 6:51 AM, Daniel Shahaf wrote: > On Mon, 18 Apr 2011 16:05 +0530, "Arwin Arni" wrote: >> Hi All, >> >> This patch adds a test case to >> subversion/tests/cmdline/dav-mirror-autocheck.sh to showcase the >> following bug. >> >> In a master/slave repositories setup where write

[PATCH] to help benchmark.py run on windows

2011-04-18 Thread Alan Wood
Hi devs, I have just been looking at running the benchmarks and have got to the stage where I can run it on windows. This attached patch fixes three issues with the script: 1) use of file:// when I'm sure that file:/// is correct from previous discussions on this list 2) make sure no \ end u

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Daniel Shahaf
On Mon, 18 Apr 2011 07:08 -0400, "Mark Phippard" wrote: > I know why it fails, but I would not expect it to fail as a user, even > with a proxy. I did not look at Arwin's test but it does not require > a WC to show the failure. This also fails: > > $ svn mkdir url://branches/branch1 > $ svn mkd

RE: Bug in svnrdump (trunk@1085375) -- malformed dump file with multiple properties

2011-04-18 Thread neil.winton
> I committed a patch which fixes issue #3847 in r1092783. Neil, if you > want to get this revision to validate the fix in your environment, I'd > be much obliged. I've tested this out locally with dumps/restores from a number of our repositories and it all looks good. Thanks guys! Neil

Re: [svnbench] Revision: 1091976 compiled Apr 14 2011, 00:21:28

2011-04-18 Thread Neels Hofmeyr
On Fri, 2011-04-15 at 03:18 -0400, Greg Stein wrote: > On Fri, Apr 15, 2011 at 00:13, Daniel Shahaf wrote: > > Just add them to public version control? > > Already done. See tools/dev/benchmarks/suite1/ > > Looking at the scripts (along with a bit of work that I did), it seems > quite easy to in

[svnbench] Revision: 1094215 compiled Apr 18 2011

2011-04-18 Thread Neels Hofmeyr
This week's benchmarks. From: ne...@svn-qavm.apache.org Date: Mon, 18 Apr 2011 02:06:07 + (04/18/2011 04:06:07 AM) /home/neels/svnbench/20110418-002438 Started at Mon Apr 18 00:24:38 UTC 2011 - Results for dir l

Re: [svnbench] Revision: 1091976 compiled Apr 14 2011, 00:21:28

2011-04-18 Thread Greg Stein
On Mon, Apr 18, 2011 at 10:50, Neels Hofmeyr wrote: > On Fri, 2011-04-15 at 03:18 -0400, Greg Stein wrote: >> On Fri, Apr 15, 2011 at 00:13, Daniel Shahaf wrote: >> > Just add them to public version control? >> >> Already done. See tools/dev/benchmarks/suite1/ >> >> Looking at the scripts (along

Re: [svnbench] Revision: 1091976 compiled Apr 14 2011, 00:21:28

2011-04-18 Thread Hyrum K Wright
On Mon, Apr 18, 2011 at 9:50 AM, Neels Hofmeyr wrote: > On Fri, 2011-04-15 at 03:18 -0400, Greg Stein wrote: >> On Fri, Apr 15, 2011 at 00:13, Daniel Shahaf wrote: >> > Just add them to public version control? >> >> Already done. See tools/dev/benchmarks/suite1/ >> >> Looking at the scripts (alon

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-18 Thread Johan Corveleyn
On Sat, Apr 16, 2011 at 10:17 AM, Johan Corveleyn wrote: > Hi, > > Following discussion in [1], I tried to write a patch for issue #3702 > ("svn ren TODO todo" not work on windows). As mentioned by Bert in > comment to the issue [2], we need to avoid letting 'svn move' convert > the destination pa

Changelists on directories

2011-04-18 Thread Hyrum K Wright
Issue #3310 is about adding directory support for changelists. As I work through updating the way that changelists are set and unset in wc-ng, it seems like more work to *not* allow changelists on directories. The issue is a bit sparse on details, so before I go changing this behavior, I'd like t

RE: Changelists on directories

2011-04-18 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: maandag 18 april 2011 20:06 > To: Subversion Development > Subject: Changelists on directories > > Issue #3310 is about adding directory support for changelists. As I > work through updating the way that

Re: Changelists on directories

2011-04-18 Thread C. Michael Pilato
On 04/18/2011 02:05 PM, Hyrum K Wright wrote: > The issue is a bit sparse on details, so before I go changing this > behavior, I'd like to have a bit more information. Other than simple > storage mechanisms, what other considerations came into the decision > not to allow changelists on directories

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Peter Samuelson
[Daniel Shahaf] > when the slave hasn't synced up yet, I assume (not knowing the proxy > code) that the editor would be opened against a revision N1, such > that on master branches/ has been touched in some revision N2 > N1. > Therefore, as far as master is concerned, the error is proper. > (consi

Re: Changelists on directories

2011-04-18 Thread Hyrum K Wright
On Mon, Apr 18, 2011 at 1:15 PM, C. Michael Pilato wrote: > On 04/18/2011 02:05 PM, Hyrum K Wright wrote: >> The issue is a bit sparse on details, so before I go changing this >> behavior, I'd like to have a bit more information.  Other than simple >> storage mechanisms, what other considerations

Re: Changelists on directories

2011-04-18 Thread Greg Stein
On Mon, Apr 18, 2011 at 14:37, Hyrum K Wright wrote: >... > But this could just be my simplistic, cli-centric, anglophile brain > talking here.  If there is a simple solution, let's do it.  If we need > to make a relatively simple decision, let'd make it.  If we need to > debate it for a while (wh

Re: Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-18 Thread C. Michael Pilato
On 04/16/2011 08:40 AM, Stefan Fuhrmann wrote: > On 14.04.2011 22:32, Branko Čibej wrote: >> On 14.04.2011 21:03, Daniel Shahaf wrote: >>> On Thu, 14 Apr 2011 14:43 -0400, "C. Michael Pilato" >>> wrote: I'm honestly not quite sure exactly where the right place is. I don't really see wh

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-18 Thread Branko Čibej
On 18.04.2011 20:01, Johan Corveleyn wrote: > BUT it raises some additional questions/issues: > > - How to commit such a move? Committing the parent directory > recursively works fine, but if you try to specify only the move > targets (src and dst paths), commit runs into the same problem as what >

Re: svn commit: r1094707 - in /subversion/trunk/subversion: libsvn_wc/ tests/libsvn_wc/

2011-04-18 Thread Greg Stein
On Mon, Apr 18, 2011 at 15:41, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc-queries.sql Mon Apr 18 19:41:26 > 2011 > @@ -603,6 +603,11 @@ SELECT md5_checksum >  FROM pristine >  WHERE checksum = ?1 > > +-- STMT_SELECT_PRISTINE_SIZE > +SELECT size > +FROM pristine > +WHERE checksum

Re: svn commit: r1094733 - /subversion/trunk/subversion/libsvn_wc/questions.c

2011-04-18 Thread Greg Stein
On Mon, Apr 18, 2011 at 16:35, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/questions.c Mon Apr 18 20:35:14 2011 >... > @@ -146,8 +156,22 @@ compare_and_verify(svn_boolean_t *modifi >       return svn_error_return(svn_stream_close(pristine_stream)); >     } > > -  /* Can a file be

Re: [PATCH] to help benchmark.py run on windows

2011-04-18 Thread Gavin Baumanis
Hi Alan, Thanks for your patch. Not too sure if you have been following the dev list discussions or not; but just in case you haven't been; http://svn.haxx.se/dev/archive-2011-04/0243.shtml Which would seem that Greg has been working on the same thing, making changes to the script to allow it

Re: [PATCH] to help benchmark.py run on windows

2011-04-18 Thread Greg Stein
On Mon, Apr 18, 2011 at 07:04, Alan Wood wrote: > Hi devs, >  I have just been looking at running the benchmarks and have got to the stage > where I can > run it on windows. > > This attached patch fixes three issues with the script: >  1) use of file:// when I'm sure that file:/// is correct fro

Re: [PATCH] to help benchmark.py run on windows

2011-04-18 Thread Greg Stein
Applied in r1094816. On Mon, Apr 18, 2011 at 18:44, Greg Stein wrote: > On Mon, Apr 18, 2011 at 07:04, Alan Wood wrote: >> Hi devs, >>  I have just been looking at running the benchmarks and have got to the >> stage where I can >> run it on windows. >> >> This attached patch fixes three issues

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Mark Phippard
On Mon, Apr 18, 2011 at 7:41 AM, Daniel Shahaf wrote: > On Mon, 18 Apr 2011 07:08 -0400, "Mark Phippard" wrote: >> I know why it fails, but I would not expect it to fail as a user, even >> with a proxy.  I did not look at Arwin's test but it does not require >> a WC to show the failure.  This als

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Daniel Shahaf
On Mon, 18 Apr 2011 22:14 -0400, "Mark Phippard" wrote: > On Mon, Apr 18, 2011 at 7:41 AM, Daniel Shahaf > wrote: > > I agree it would be nice if this worked, but given that we have to remain > > sane to people who open an RA session to the slave before it has > > synced up I'm afraid it might b

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-18 Thread Arwin Arni
On Monday 18 April 2011 04:05 PM, Arwin Arni wrote: I'll shortly file an issue in the tigris tracker for this. Filed Issue #3860 and set the target milestone to 1.7-consider Regards, Arwin Arni