Re: svn commit: r1081892 - in /subversion/trunk/subversion: include/private/svn_io_private.h libsvn_subr/io.c libsvn_wc/adm_ops.c libsvn_wc/questions.c libsvn_wc/wc.h tests/cmdline/revert_tests.py

2011-03-16 Thread Julian Foad
On Tue, 2011-03-15, Philip Martin wrote: > > URL: http://svn.apache.org/viewvc?rev=1081892&view=rev > > Log: > > Make revert change file permissions on the basis of the current magic > > properties and the current permissions, rather than on any change in > > the magic permissions. This means file

Re: [PATCH] Fix for issue 3787

2011-03-16 Thread Julian Foad
On Mon, 2011-03-14 at 16:02 +0100, Stefan Sperling wrote: > On Thu, Mar 10, 2011 at 04:49:32PM +0530, Noorul Islam K M wrote: > > > > >From issue tracker > > (http://subversion.tigris.org/issues/show_bug.cgi?id=3787) > > > > It would be ever-so-helpful to folks looking to capture and replicate a

Re: svn commit: r1081892 - in /subversion/trunk/subversion: include/private/svn_io_private.h libsvn_subr/io.c libsvn_wc/adm_ops.c libsvn_wc/questions.c libsvn_wc/wc.h tests/cmdline/revert_tests.py

2011-03-16 Thread Philip Martin
Julian Foad writes: > Would I be right in guessing you made this change not from an intent to > change the behaviour, but because you needed to re-implement part of > 'revert' for other reasons and this behaviour was the obvious behaviour > to implement, the old behaviour being the anomaly? Yes,

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-16 Thread Stefan Sperling
On Wed, Mar 16, 2011 at 12:15:05PM +0530, Arwin Arni wrote: > On Tuesday 15 March 2011 08:34 PM, Julian Foad wrote: > >I see that '--parents' and '--set-depth' are not allowed in dry-run > >mode. What is the reason behind that? Is it because they seem to be > >difficult to implement, or you think

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-16 Thread Julian Foad
Arwin Arni wrote: > On Tuesday 15 March 2011 08:34 PM, Julian Foad wrote: > > On Wed, 2011-03-02, Arwin Arni wrote: > >> In my effort to understand the delta editor API, I took it upon myself > >> to try and implement the --dry-run flag for "svn update". > > > >> http://subversion.tigris.org/issues

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-16 Thread Mark Phippard
On Wed, Mar 16, 2011 at 2:45 AM, Arwin Arni wrote: > Well, the reason is that both --parents and --set-depth make permanent > changes to the WC which will not be reported in the output at all.. If the > user is passing these parameters, he has a fair idea of what these > "invisible" changes are,

Re: [Noorul Islam K M] Re: [PATCH] Fix for issue 3826

2011-03-16 Thread C. Michael Pilato
On 03/15/2011 10:15 PM, Noorul Islam K M wrote: > > I wonder, why this patch was not considered for fixing issue 3826. I > could see a fix 1081799 which I see very similar to what I have > done. Did I miss anything here? No, I simply overlooked your patch by accident. Of course, that was easy to

Re: [Noorul Islam K M] Re: [PATCH] Fix for issue 3826

2011-03-16 Thread Julian Foad
C. Michael Pilato wrote: > On 03/15/2011 10:15 PM, Noorul Islam K M wrote: > > > > I wonder, why this patch was not considered for fixing issue 3826. I > > could see a fix 1081799 which I see very similar to what I have > > done. Did I miss anything here? > > No, I simply overlooked your patch by

Property storage / modification in WC-NG

2011-03-16 Thread C. Michael Pilato
[Begging your pardon for not being able to speak with confident accuracy about the inner workings of WC-NG.] Today, while trying to get an overview of the various ways in which svn_wc__node_walk_children() was used, I found some patterns that seem, to me at least, to cry out for better database sc

Re: Property storage / modification in WC-NG

2011-03-16 Thread Greg Stein
On Wed, Mar 16, 2011 at 12:59, C. Michael Pilato wrote: >... > to manage at least the "read" subset of these operations.  But I find myself > wondering if we wouldn't be better served by having a properties table with > rows for, I dunno:  wc_id, local_relpath, property_name, property_value. >...

Re: Property storage / modification in WC-NG

2011-03-16 Thread C. Michael Pilato
On 03/16/2011 01:17 PM, Greg Stein wrote: > On Wed, Mar 16, 2011 at 12:59, C. Michael Pilato wrote: >> ... >> to manage at least the "read" subset of these operations. But I find myself >> wondering if we wouldn't be better served by having a properties table with >> rows for, I dunno: wc_id, lo

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-16 Thread Arwin Arni
Arwin Arni wrote: On Tuesday 15 March 2011 08:34 PM, Julian Foad wrote: On Wed, 2011-03-02, Arwin Arni wrote: In my effort to understand the delta editor API, I took it upon myself to try and implement the --dry-run flag for "svn update". http://subversion.tigris.org/issues/show_bug.cgi?id=2491