crash in serf on windows

2011-01-25 Thread Marc Haesen
I have seen a crash (null pointer access) during svn merge using serf. The same command using neon was successful. I am using a trunk compiled version of svn (revision 1061787) on windows together with a trunk version of serf (revision 1421) compiled with visual studio 2010 The reason is th

Re: crash in serf on windows

2011-01-25 Thread Justin Erenkrantz
On Tue, Jan 25, 2011 at 12:02 AM, Marc Haesen wrote: > I have seen a crash (null pointer access) during svn merge using serf. The > same command using neon was successful. > > > > I am using a trunk compiled version of svn (revision 1061787) on windows > together with a trunk version of serf (revi

Re: [PATCH] extend svn_subst_translate_string2() with a REPAIR parameter

2011-01-25 Thread Julian Foad
On Fri, 2011-01-14, Danny Trebbien wrote: > On Fri, Jan 14, 2011 at 12:32 PM, Danny Trebbien wrote: > > Attached are a patch and log message to extend > > svn_subst_translate_string2() with a new parameter, REPAIR. This > > allows the caller to customize whether the translation repairs line > > en

Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Hyrum K Wright
Johan (and other interested parties), I've been following some of the commits to the diff-optimizations-branch with interest.  While I've not reviewed them for technical merit, it appears that others have, and that there is good work going on in the branch.  I'm wondering what the potential for mer

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 4)

2011-01-25 Thread Julian Foad
On Fri, 2011-01-14, Danny Trebbien wrote: > Attached are version 4 of the patch and log message. Also attached are > two TGZ archives containing the six DUMP files that the new svnsync > and svnrdump tests depend upon. These TGZ archives can be extracted > directly into your working copy of trunk.

Re: [PATCH] Server fix for issue #3657 - Any mod_dav_svn experts out there? (was Re: svn commit: r966822)

2011-01-25 Thread Paul Burba
On Mon, Jan 24, 2011 at 5:01 PM, Paul Burba wrote: > On Wed, Jan 19, 2011 at 10:23 AM, C. Michael Pilato > wrote: >> Hey, Paul.  Overall, I think the change makes sense.  I've given some inline >> review below.  (This is based mostly on a reading of the patch itself, not a >> reading of the patc

Re: [PATCH] extend svn_subst_translate_string2() with a REPAIR parameter

2011-01-25 Thread Danny Trebbien
> I made one tweak: in the test for detecting an error, after detecting > the error, we need to clear the error, otherwise the test harness > reports success on the individual test but reports a problem at the end > of the test run: > >  PASS:  lt-subst_translate-test 1: test svn_subst_translate_st

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 4)

2011-01-25 Thread Danny Trebbien
> Hi Danny. > > I committed the patch you refer to, on which this one depends, in > r1063320.  However, I'm not likely to get around to reviewing this patch > any time soon.  It would be great if someone else could take it. > > - Julian Okay. That's fine. Thank you for the update.

Re: [PATCH] Server fix for issue #3657 - Any mod_dav_svn experts out there? (was Re: svn commit: r966822)

2011-01-25 Thread Paul Burba
On Mon, Jan 24, 2011 at 5:01 PM, Paul Burba wrote: > On Wed, Jan 19, 2011 at 10:23 AM, C. Michael Pilato > wrote: >> Hey, Paul.  Overall, I think the change makes sense.  I've given some inline >> review below.  (This is based mostly on a reading of the patch itself, not a >> reading of the patc

Re: [PATCH] extend svn_subst_translate_string2() with a REPAIR parameter

2011-01-25 Thread Julian Foad
On Tue, 2011-01-25 at 08:28 -0800, Danny Trebbien wrote: > > I made one tweak: in the test for detecting an error, after detecting > > the error, we need to clear the error, otherwise the test harness > > reports success on the individual test but reports a problem at the end > > of the test run: >

Re: [PATCH] extend svn_subst_translate_string2() with a REPAIR parameter

2011-01-25 Thread Philip Martin
Julian Foad writes: > On Tue, 2011-01-25 at 08:28 -0800, Danny Trebbien wrote: >> > I made one tweak: in the test for detecting an error, after detecting >> > the error, we need to clear the error, otherwise the test harness >> > reports success on the individual test but reports a problem at the

Re: [PATCH] extend svn_subst_translate_string2() with a REPAIR parameter

2011-01-25 Thread Daniel Shahaf
Philip Martin wrote on Tue, Jan 25, 2011 at 17:02:18 +: > Julian Foad writes: > > > On Tue, 2011-01-25 at 08:28 -0800, Danny Trebbien wrote: > >> > I made one tweak: in the test for detecting an error, after detecting > >> > the error, we need to clear the error, otherwise the test harness >

Re: [PATCH] Server fix for issue #3657 - Any mod_dav_svn experts out there? (was Re: svn commit: r966822)

2011-01-25 Thread Paul Burba
On Tue, Jan 25, 2011 at 11:27 AM, Paul Burba wrote: > On Mon, Jan 24, 2011 at 5:01 PM, Paul Burba wrote: >> On Wed, Jan 19, 2011 at 10:23 AM, C. Michael Pilato >> wrote: >>> Hey, Paul.  Overall, I think the change makes sense.  I've given some inline >>> review below.  (This is based mostly on

Re: Document return codes of 'svn ls'

2011-01-25 Thread Daniel Shahaf
anatoly techtonik wrote on Fri, Jan 21, 2011 at 13:42:51 +0200: > No. Internet connection may be down during this specific request. How can I > distinguish these two errors? How about something like this: % svn $subcommand --options --output-apr_err-to-stderr 2>&1 >/dev/null | tail -n1 apr_err=2

log -g regression in r1028108

2011-01-25 Thread Kevin Radke
(I'm moving this conversation from users to dev, since I have convinced myself a regression was introduced in r1028108) See: http://svn.haxx.se/users/archive-2010-12/0265.shtml log -v -g --xml http://server/repo/path commands will now fail for "complex" histories that contain file renames. The cl

Re: log -g regression in r1028108

2011-01-25 Thread Stefan Sperling
On Tue, Jan 25, 2011 at 10:34:43AM -0600, Kevin Radke wrote: > (I'm moving this conversation from users to dev, since I have > convinced myself a regression was introduced in r1028108) > See: http://svn.haxx.se/users/archive-2010-12/0265.shtml > > log -v -g --xml http://server/repo/path commands w

Re: log -g regression in r1028108

2011-01-25 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 1:14 PM, Stefan Sperling wrote: > On Tue, Jan 25, 2011 at 10:34:43AM -0600, Kevin Radke wrote: >> (I'm moving this conversation from users to dev, since I have >> convinced myself a regression was introduced in r1028108) >> See: http://svn.haxx.se/users/archive-2010-12/0265

Re: Document return codes of 'svn ls'

2011-01-25 Thread anatoly techtonik
On Tue, Jan 25, 2011 at 8:47 PM, Daniel Shahaf wrote: > anatoly techtonik wrote on Fri, Jan 21, 2011 at 13:42:51 +0200: >> No. Internet connection may be down during this specific request. How can I >> distinguish these two errors? > > How about something like this: > > % svn $subcommand --options

Re: Document return codes of 'svn ls'

2011-01-25 Thread Daniel Shahaf
I was suggesting a syntax we might want to implement in the future.

Re: svn commit: r1058503, 1058515

2011-01-25 Thread Daniel Shahaf
Got it done before the release: r1063420. Stefan Sperling wrote on Thu, Jan 13, 2011 at 15:39:05 +: > On Thu, Jan 13, 2011 at 05:27:52PM +0200, Daniel Shahaf wrote: > > s...@apache.org wrote on Thu, Jan 13, 2011 at 11:07:27 -: > > > -With a 1.7 server, it is possible to fix the svnsync rac

Re: Document return codes of 'svn ls'

2011-01-25 Thread anatoly techtonik
On Tue, Jan 25, 2011 at 9:35 PM, Daniel Shahaf wrote: > I was suggesting a syntax we might want to implement in the future. So, you basically agree that there is no way to see if a path is absent at specified revision in repository. Should I create an issue? -- anatoly t.

Re: Document return codes of 'svn ls'

2011-01-25 Thread Daniel Shahaf
anatoly techtonik wrote on Tue, Jan 25, 2011 at 22:53:05 +0200: > So, you basically agree that there is no way to see if a path is > absent at specified revision in repository. I did not express an opinion on the specific issue you raised in this thread.

Re: Document return codes of 'svn ls'

2011-01-25 Thread C. Michael Pilato
On 01/25/2011 03:53 PM, anatoly techtonik wrote: > On Tue, Jan 25, 2011 at 9:35 PM, Daniel Shahaf > wrote: >> I was suggesting a syntax we might want to implement in the future. > > So, you basically agree that there is no way to see if a path is > absent at specified revision in repository. > S

Re: log -g regression in r1028108

2011-01-25 Thread Kevin Radke
On Tue, Jan 25, 2011 at 1:23 PM, Hyrum K Wright wrote: > On Tue, Jan 25, 2011 at 1:14 PM, Stefan Sperling wrote: >> On Tue, Jan 25, 2011 at 10:34:43AM -0600, Kevin Radke wrote: >>> (I'm moving this conversation from users to dev, since I have >>> convinced myself a regression was introduced in r1

Re: Document return codes of 'svn ls'

2011-01-25 Thread anatoly techtonik
On Tue, Jan 25, 2011 at 11:30 PM, C. Michael Pilato wrote: > On 01/25/2011 03:53 PM, anatoly techtonik wrote: >> On Tue, Jan 25, 2011 at 9:35 PM, Daniel Shahaf >> wrote: >>> I was suggesting a syntax we might want to implement in the future. >> >> So, you basically agree that there is no way to

Re: My take on the diff-optimizations-bytes branch

2011-01-25 Thread Johan Corveleyn
On Tue, Jan 25, 2011 at 1:37 AM, Stefan Fuhrmann wrote: [ ... snip ...] > And, as promised, here some ideas how to get more > speed from the generic code. Your latest commit: > > +#if SVN_UNALIGNED_ACCESS_IS_OK > + > +      /* Skip quickly over the stuff between EOLs. */ > +      for (i = 0, can_r

Re: Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Johan Corveleyn
On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright wrote: > Johan (and other interested parties), > I've been following some of the commits to the > diff-optimizations-branch with interest.  While I've not reviewed them > for technical merit, it appears that others have, and that there is > good work

'svnrdump load' tests unmirrored

2011-01-25 Thread Daniel Shahaf
In svnrdump_tests.py, nearly all tests are paired --- dump test and corresponding load test --- except a handful (basic_dump, only_trunk_dump, only_trunk_A_with_changes_dump, copy_bad_line_endings_dump). Is there any particular reason that these don't have corresponding _load tests? Thanks, Dani

[PATCH] Re: Incorporate svn 1.7 changes to vc-svn.el

2011-01-25 Thread Noorul Islam K M
Noorul Islam K M writes: > After migrating working copy to 1.7, vc-svn.el is not functioning > properly. This is because .svn/entries file does not exist. I think we > no longer need to check existence of this file. Since .svn exists at the > root of the working copy we no longer be able to assum

Re: [PATCH] svn command - cat - Multiple targets

2011-01-25 Thread Noorul Islam K M
Noorul Islam K M writes: > This patch is a followup of the following thread. All tests pass with > this patch. > > http://svn.haxx.se/dev/archive-2011-01/0210.shtml > > Log > > [[[ > > Make svn 'cat' command to return 1 when one or more targets fails. Also > print error message at the end. This a

Re: Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: > On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright wrote: > > Johan (and other interested parties), > > I've been following some of the commits to the > > diff-optimizations-branch with interest.  While I've not reviewed them > > for tec

Re: Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: > Revving svn_diff_fns_t: what do you mean with parallelizing it? I must > admit that I don't really know (yet) how to go about that. Very early > during the branch work, danielsh pointed out that I modified this > public struct (vtable

Re: [PATCH] Re: Incorporate svn 1.7 changes to vc-svn.el

2011-01-25 Thread Daniel Shahaf
This looks correct, perhaps someone with $EDITOR != vim can apply it? Noorul Islam K M wrote on Wed, Jan 26, 2011 at 10:35:02 +0530: > Noorul Islam K M writes: > > > After migrating working copy to 1.7, vc-svn.el is not functioning > > properly. This is because .svn/entries file does not exist.

EDEADLK in svn_repos_fs_begin_txn_for_commit2

2011-01-25 Thread Blair Zajac
We're seeing deadlocks in our Subversion multithreaded server when two distinct processes try to fcntl(F_SETLKW) on two fsfs repositories' db/txn-current-lock, when the processes begin transactions in reverse order. Process 1 Process 2 -

[PATCH] New XFail test case for issue 3013

2011-01-25 Thread Noorul Islam K M
Attached is the python test for issue 3013. This incorporates the steps from the shell script attached in the tracker. Log [[[ New XFail test for issue 3013. * subversion/tests/cmdline/update_tests.py (update_after_switching_to_deleted_path, test_list): New XFail test Patch by: Noorul Islam