Re: Some performance data

2011-01-18 Thread Philip Martin
Hyrum K Wright writes: > I've been looking at which bugs can be closed by the pending > completion of wc-ng. In particular, I've been looking at issue #1284: > http://subversion.tigris.org/issues/show_bug.cgi?id=1284 > > The issue is essentially a complaint about the performance of 'svn mv > som

Re: Coding goals / requirements.

2011-01-18 Thread Johan Corveleyn
Hi, As the guy responsible for the quote that started this thread ([1]): > Actually, what's a little bit troubling is that there are currently > only 3 possible "file_len's", of which only 2 are used in practice: > diff2 and diff3 (diff4 is not used in svn core, only in > tools/diff/diff4). So, i

Re: svn command line client's inconsistent behavior in handling multiple targets.

2011-01-18 Thread Noorul Islam K M
Julian Foad writes: > On Fri, 2011-01-14 at 17:50 +0530, Noorul Islam K M wrote: > >> Stefan Sperling writes: >> >> > On Thu, Jan 13, 2011 at 03:31:11PM +0530, Noorul Islam K M wrote: >> > >> >> | Command| Return Code | Continue | >> >> |+-+--| >> >> | add

Re: My take on the diff-optimizations-bytes branch

2011-01-18 Thread Johan Corveleyn
On Mon, Jan 17, 2011 at 3:12 AM, Johan Corveleyn wrote: > On Sat, Jan 8, 2011 at 6:50 AM, Stefan Fuhrmann > wrote: [ ... snip ... ] >> But I think, the stack variable is certainly helpful >> and easy to do. Ok, I've done this (locally, still have to clean up a little and then commit). It gives

Re: NFS and fsfs: slow commit performance

2011-01-18 Thread Florian Weimer
* Blair Zajac: > Attempting to perform high commit rates into an fsfs repository on NFS > with two or more Linux boxes, one of the processes can get stuck in > fcntl() for over 30 seconds: > > open("repo/db/write-lock", O_RDWR) = 4 > fcntl(4, F_SETLKW, {type=F_WRLCK, whence=SEEK_SET, start=0,

Re: Ref-counting for pristine texts

2011-01-18 Thread Julian Foad
Can anyone spare a bit of time to take this forward? I'll tell you what I'm planning to do next. Maybe someone can get to this before I can. The first thing I want to do is add a DB index on the 'refcount' column of the 'pristine' table. I'm convinced that will be necessary for adequate perform

Re: NFS and fsfs: slow commit performance

2011-01-18 Thread Blair Zajac
On Jan 18, 2011, at 6:49 AM, Florian Weimer wrote: > * Blair Zajac: > >> Attempting to perform high commit rates into an fsfs repository on NFS >> with two or more Linux boxes, one of the processes can get stuck in >> fcntl() for over 30 seconds: >> >> open("repo/db/write-lock", O_RDWR) =

Re: [PATCH] Add regression test for issue #3686:executable flag not correctly set on merge

2011-01-18 Thread Daniel Shahaf
Daniel Becroft wrote on Tue, Jan 18, 2011 at 07:13:12 +1000: > Hi guys, > > I was looking through the "Getting Involved" section of the Subversion > website, and decided to start by writing a regression test for an > issue, starting with 3686 (executable flag not correctly set on > merge). This is

Re: NFS and fsfs: slow commit performance

2011-01-18 Thread Blair Zajac
On Jan 18, 2011, at 1:49 AM, Bolstridge, Andrew wrote: > Hi. > > Just a quick question/suggestion: > > If the exponential sleep can be a maximum of 25ms, and the random one > between 0 and 100ms, what is the performance like if you just sleep for > 25ms - without any randomness, or doubling of

Re: [PATCH] Add regression test for issue #3686:executable flag not correctly set on merge

2011-01-18 Thread Daniel Becroft
On Wed, Jan 19, 2011 at 3:08 AM, Daniel Shahaf wrote: > Daniel Becroft wrote on Tue, Jan 18, 2011 at 07:13:12 +1000: > > Hi guys, > > > > I was looking through the "Getting Involved" section of the Subversion > > website, and decided to start by writing a regression test for an > > issue, starting

Re: [PATCH] Add regression test for issue #3686:executable flag not correctly set on merge

2011-01-18 Thread Daniel Shahaf
Daniel Becroft wrote on Wed, Jan 19, 2011 at 07:27:15 +1000: > On Wed, Jan 19, 2011 at 3:08 AM, Daniel Shahaf wrote: > > Daniel Becroft wrote on Tue, Jan 18, 2011 at 07:13:12 +1000: > > > 2) The problem also exists under the '--reintegrate' scenario, even > > > after a subsequent commit. Would it b

[PATCH] Server fix for issue #3657 - Any mod_dav_svn experts out there? (was Re: svn commit: r966822)

2011-01-18 Thread Paul Burba
> On Fri, Jan 7, 2011 at 7:08 PM, Paul Burba wrote: >> Mike suggested to me that the fix for this problem can be made in >> mod_dav_svn, since the update reporter already knows which properties >> have changed, *regardless* of the send-all mode, but it discards this >> information if send-all=FAL

Re: Ref-counting for pristine texts

2011-01-18 Thread Branko Čibej
On 18.01.2011 16:58, Julian Foad wrote: > On Thu, 2011-01-13, Branko Čibej wrote: >> This would indicate that the reference counting happens too soon ... in >> other words, that a pristine can be dereferenced whilst some part of the >> code (or database) still refers to it. That breaks database con

Re: My take on the diff-optimizations-bytes branch

2011-01-18 Thread Stefan Fuhrmann
On 18.01.2011 12:56, Johan Corveleyn wrote: On Mon, Jan 17, 2011 at 3:12 AM, Johan Corveleyn wrote: On Sat, Jan 8, 2011 at 6:50 AM, Stefan Fuhrmann wrote: [ ... snip ... ] But I think, the stack variable is certainly helpful and easy to do. Ok, I've done this (locally, still have to clean

Re: Coding goals / requirements.

2011-01-18 Thread Gavin Beau Baumanis
Hi Johan, I hope it wasn't inferred in any part of my email that "I" was trying to tell you what to do it in any specific manner. And although I was prompted by your thread, it was completely unrelated. In my "day" job - I always strive for the simplest solution possible. If the requirements of