On 1/8/11 2:44 PM, Stefan Sperling wrote:
On Sun, Jan 09, 2011 at 09:34:01AM +1100, Gavin Beau Baumanis wrote:
Hi Daniel,
Being a non SVN dev I am certainly not in a position to review your patch..
But being a developer, none the less, that prescribes to Test Driven
Development I have to say,
> Sounds great.
>
> Should the Subversion project plan to write and publish advisories for
> these CVEs, or has the requester already done so?
I'm not affiliated with subversion so it's up to them (I assume they
won't since they didn't do so originally).
> -Hyrum
--
Kurt Seifried
k...@seifried.
Hi Daniel,
Daniel Shahaf writes:
> If you send another patch that indents/dedents a block, could you please
> attach a 'svn diff -x-w' version of the patch too? It would make
> reviewing easier.
Sure. Here's the (hopefully) final patch. Sorry about the slopiness
earlier -- I was in a hurry to g
Hi Stefan,
Stefan Sperling writes:
> LD_LIBRARY_PATH in the Makefile is only used by targets that are supposed
> to run the executables compiled by the Makefile, and need to *dynamically*
> load some libraries at run time (e.g. bindings) via dlopen().
>
> This doesn't affect the checkout/export s
I'm seeing the following reproducible crash on Mac OS X for x86_64 using svn
1.6.15.
This is crash does not happen using 1.6.12.
It seems to be the call to apr_psprintf that is not right.
Here is the bt:
#0 0x7fff82ac8160 in strlen ()
#1 0x0001015190c7 in apr_vformatter (flush_func=0x
Wanted to confirm a reading of fs_serialized_init() in libsvn_fs_fs/fs.c in a
persistent, multithreaded server.
It appears that if fs_serialized_init() is called at the same time by two or
more threads, then you would have a race on apr_pool_userdata_get() and
apr_pool_userdata_set().
It loo
On 09.01.2011 21:09, Blair Zajac wrote:
> Wanted to confirm a reading of fs_serialized_init() in
> libsvn_fs_fs/fs.c in a persistent, multithreaded server.
>
> It appears that if fs_serialized_init() is called at the same time by
> two or more threads, then you would have a race on
> apr_pool_userd
Blair Zajac wrote on Sun, Jan 09, 2011 at 01:15:52 -0800:
> On 1/8/11 2:44 PM, Stefan Sperling wrote:
>> On Sun, Jan 09, 2011 at 09:34:01AM +1100, Gavin Beau Baumanis wrote:
>>> Hi Daniel,
>>> Being a non SVN dev I am certainly not in a position to review your patch..
>>> But being a developer, non
Are the typedefs for SVN_FILESIZE_T_FMT and APR_OFF_T_FMT correct?
Blair Zajac wrote on Sun, Jan 09, 2011 at 12:09:34 -0800:
> Wanted to confirm a reading of fs_serialized_init() in libsvn_fs_fs/fs.c
> in a persistent, multithreaded server.
>
> It appears that if fs_serialized_init() is called at the same time by two
> or more threads,
Can this happen?
fs_seri
Danny Trebbien wrote on Fri, Jan 07, 2011 at 13:03:18 -0800:
> > Refresh my memory please: did we decide in some thread that the
> > recodings should be counted too?
>
> At one point Stefan asked me if I was interested:
> http://article.gmane.org/gmane.comp.version-control.subversion.devel/122540
I looked at this patch, I'm not happy with it, but my issues are so
specific (eg: variable's initialization has problem) that
I feel I'd be *dictating* a rewrite of the patch if I reviewed it.
And that is bad form, so I'm not going to do that...
Sorry,
Daniel
Ramkumar Ramachandra wrote on S
12 matches
Mail list logo
