Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Branko Čibej
On 28.12.2010 23:13, Peter Samuelson wrote: > [C. Michael Pilato] >>> svn_fspath__is_canonical >>> svn_fspath__dirname >>> svn_fspath__basename >>> svn_fspath__split >>> svn_fspath__join >>> svn_fspath__is_child >>> svn_fspath__skip_ancestor >>> svn_fspath__is_ancestor >>> svn_fspath__get_longest_a

Re: [PATCH] Make error messages visible to translator

2010-12-29 Thread Branko Čibej
On 29.12.2010 07:58, vijay wrote: > I could see the error messages in mod_dav_svn are not prefixed by an > underscore, may be the subsequent layers will handle the errors and > translate it? How will a server component select a translation appropriate for the client's language environment? (Yes,

Re: New VM for committers

2010-12-29 Thread Ramkumar Ramachandra
Hi Lieven, Lieven Govaerts writes: > Yes, what will you be using it for? Any specific ideas? I originally requested it to run callgraph and heap profilers on svnrdump. I suppose others can use it to plug leaks and tune the performance of several other Subversion components. -- Ram

Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Branko Čibej
On 29.12.2010 09:43, Branko Čibej wrote: > On 28.12.2010 23:13, Peter Samuelson wrote: >> [C. Michael Pilato] svn_fspath__is_canonical svn_fspath__dirname svn_fspath__basename svn_fspath__split svn_fspath__join svn_fspath__is_child svn_fspath__skip_ancestor s

Re: [PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-29 Thread Erik Johansson
On Mon, Dec 13, 2010 at 21:35, Erik Johansson wrote: > An attempt to untangle the mess discussed in > http://svn.haxx.se/dev/archive-2010-12/0258.shtml Take 2. I have tried to update the documentation according to the comments to the previous patch. Please let me know what you think. // Erik [[

[PATCH] Remove redundant member skip_descendants from libsvn_wc/update_editor.c

2010-12-29 Thread Arwin Arni
Hi All, In my pursuit to understand libsvn_wc/update_editor.c I came across an unnecessary member (skip_descendants) in the dir_baton. skip_descendants and skip_this are being set at the same time and have identical values at all times. I have removed one of these (skip_descendants) and the *

Re: How is mixed authentication/anonymous access implemented

2010-12-29 Thread Avalon
I think you're looking for this: http://blogs.open.collab.net/svn/2007/03/authz_and_anon_.html These are actually all only work-arounds. I am aware of these and especially mentioned that i do not want to use them. Also, I didn't quite understand your post, but unless it's about the development

RE: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Kamesh Jayachandran
>> Now I'm really mystified. When I added those location-tracing functions >> and macros, they were only ever enabled with SVN_DEBUG turned on (i.e., >> in maintainer-mode). Now I see that those #ifdef wrappers are gone, and >> can't recall an explanation as to why that's a good thing. >> >> Can an

Re: [Be|Na]gging for review

2010-12-29 Thread Stefan Fuhrmann
On 29.12.2010 08:23, Blair Zajac wrote: On 12/28/2010 6:28 PM, Stefan Fuhrmann wrote: On 29.12.2010 01:33, Stefan Fuhrmann wrote: Hi devs, I would really like the core improvement of my work on SVN performance to become part of 1.7: the in-process fulltext cache. While the risk is low (we alr

RE: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Kamesh Jayachandran
>> While we've mandated that "__" must be used for semi-public >> functions, we've never said that it can't be used for private ones. >Kamesh is talking about public, not private, functions. I.e., ones >where we actually do have an ABI promise to keep. >I looked at svn_error__locate last week.

Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Peter Samuelson
[Branko Cibej] > Found it, r843793 and I agree with the change. So, effectively, > svn_error__locate has been public since then, and r1053469 should be > reverted anyway because it breaks the ABI. It doesn't break the ABI. I kept the function itself. Whether it is useful to populate ->file and

Re: FSFS format 6

2010-12-29 Thread Stefan Fuhrmann
On 29.12.2010 01:58, Johan Corveleyn wrote: On Sun, Dec 12, 2010 at 4:23 PM, Stefan Fuhrmann wrote: On 19.10.2010 15:10, Daniel Shahaf wrote: Greg Stein wrote on Tue, Oct 19, 2010 at 04:31:42 -0400: Personally, I see [FSv2] as a broad swath of API changes to align our needs with the underlyi

Re: svn commit: r1053645 - /subversion/trunk/tools/po/l10n-report.py

2010-12-29 Thread Peter Samuelson
[hwri...@apache.org] > * tools/po/l10n-report.py > (main): Use the smtp library for sending mail, rather than shelling out > to 'sendmail'. I know this is a specialty script only run by certain people, but on the whole, I think the existence of a working 'sendmail -t' is more common than th

Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Branko Čibej
On 29.12.2010 20:10, Kamesh Jayachandran wrote: > > >> Now I'm really mystified. When I added those location-tracing functions > >> and macros, they were only ever enabled with SVN_DEBUG turned on (i.e., > >> in maintainer-mode). Now I see that those #ifdef wrappers are gone, and > >> can't recall

Re: svn commit: r1053645 - /subversion/trunk/tools/po/l10n-report.py

2010-12-29 Thread Hyrum K Wright
On Wed, Dec 29, 2010 at 3:02 PM, Peter Samuelson wrote: > > [hwri...@apache.org] >> * tools/po/l10n-report.py >>   (main): Use the smtp library for sending mail, rather than shelling out >>     to 'sendmail'. > > I know this is a specialty script only run by certain people, but on > the whole, I t

Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Branko Čibej
On 29.12.2010 20:50, Peter Samuelson wrote: > [Branko Cibej] >> Found it, r843793 and I agree with the change. So, effectively, >> svn_error__locate has been public since then, and r1053469 should be >> reverted anyway because it breaks the ABI. > It doesn't break the ABI. I kept the function itse

[PATCH] Remove unused parameters in libsvn_wc/update_editor.c:accumulate_last_change()

2010-12-29 Thread Arwin Arni
Hi All, This patch removes some unused parameters in the function accumulate_last_change() inside libsvn_wc/update-editor.c There were two parameters ( svn_wc__db_t *db, const char *local_abspath ) that were not being used. I have removed them and fixed the function calls. I have attached