Re: [PATCH] support printing changed properties in svnlook

2010-12-14 Thread Daniel Shahaf
Erik Johansson wrote on Mon, Dec 13, 2010 at 22:27:04 +0100: > On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf wrote: > > Could you untangle this mess around driving the editor?  (I might be > > able to look into this later, but not right now) > > See attempt in other thread. > Saw the thread, mar

[PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Martin Furter
Hello I again fell over transform_libtool_scripts.sh on solaris. Here's a version in python which reads all the needed information from build.conf instead of searching the filesystem. I ran "make check" but it stopped at authz_tests: [[[ ... Running tests in authz_tests.py [36/87][SKIPPED] Py

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Stefan Sperling
On Tue, Dec 14, 2010 at 11:09:34AM +0100, Martin Furter wrote: > Replace a disgusting shell script by nice python code. > transform_libtool_scripts.py is more portable and also reads build.conf. While python is required to create buidscripts for a subversion distribution tarball, we do not require

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Peter Samuelson
[Martin Furter] > I again fell over transform_libtool_scripts.sh on solaris. Would this patch help on Solaris? I believe autoconf goes to some effort to find a reasonable shell, in /usr/xpg4 or whatever. [[[ * Makefile.in (transform-libtool-scripts): Run with $(SHELL) rather than /bin/sh,

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Martin Furter
On Tue, 14 Dec 2010, Stefan Sperling wrote: On Tue, Dec 14, 2010 at 11:09:34AM +0100, Martin Furter wrote: Replace a disgusting shell script by nice python code. transform_libtool_scripts.py is more portable and also reads build.conf. While python is required to create buidscripts for a sub

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Martin Furter
On Tue, 14 Dec 2010, Peter Samuelson wrote: [Martin Furter] I again fell over transform_libtool_scripts.sh on solaris. Would this patch help on Solaris? I believe autoconf goes to some effort to find a reasonable shell, in /usr/xpg4 or whatever. [[[ * Makefile.in (transform-libtool-scri

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Peter Samuelson
[Martin Furter] > Configure has set SHELL=/bin/bash in Makefile. So this would solve > one of the problems of that script. r1049057. > The other problem is that it does not read build.conf so always when > anyone changes build.conf he has to remember that he may have update > transform_libtool_s

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Stefan Sperling
On Tue, Dec 14, 2010 at 06:12:54AM -0600, Peter Samuelson wrote: > > [Martin Furter] > > Configure has set SHELL=/bin/bash in Makefile. So this would solve > > one of the problems of that script. > > r1049057. > > > The other problem is that it does not read build.conf so always when > > anyone

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Martin Furter
On Tue, 14 Dec 2010, Stefan Sperling wrote: On Tue, Dec 14, 2010 at 06:12:54AM -0600, Peter Samuelson wrote: [Martin Furter] Configure has set SHELL=/bin/bash in Makefile. So this would solve one of the problems of that script. r1049057. The other problem is that it does not read build.

Re: [PATCH]: transform_libtool_scripts.py

2010-12-14 Thread Philip Martin
Martin Furter writes: > The generated script then has to be included into the tarball. I > believe to remember that there's a script which creates the > tarball. Can anyone give me a pointer where I can find it? tools/dist/dist.sh The tarball is created after autogen.sh has been run; autogen.sh

Testing help/advice needed.

2010-12-14 Thread C. Michael Pilato
I've got a patch readied for issue #3755 ("svnadmin and svnrdump should error on non-UTF8 log messages, authors, etc."), but it currently fails three tests: FAIL: svnlook_tests.py 4: svnlook info must allow inconsistent newlines FAIL: svnrdump_tests.py 32: dump: inconsistent line endings in svn:

Re: [PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-14 Thread Julian Foad
Hi Erik. The attachment didn't reach the mailing list. This is probably because the mailing list strips off attachments that aren't marked as plain text. Please could you try again, maybe changing the patch's name to '*.txt' or trying some other trick to encourage your client software to mark it

Re: [PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-14 Thread Erik Johansson
On Tue, Dec 14, 2010 at 18:17, Julian Foad wrote: > Hi Erik.  The attachment didn't reach the mailing list.  This is > probably because the mailing list strips off attachments that aren't > marked as plain text.  Please could you try again, maybe changing the > patch's name to '*.txt' or trying so

Re: Testing help/advice needed.

2010-12-14 Thread Daniel Shahaf
C. Michael Pilato wrote on Tue, Dec 14, 2010 at 12:14:00 -0500: > I've got a patch readied for issue #3755 ("svnadmin and svnrdump should > error on non-UTF8 log messages, authors, etc."), but it currently fails > three tests: > > FAIL: svnlook_tests.py 4: svnlook info must allow inconsistent new

Re: [PATCH] support printing changed properties in svnlook

2010-12-14 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Dec 14, 2010 at 10:05:35 +0200: > Erik Johansson wrote on Mon, Dec 13, 2010 at 22:27:04 +0100: > > On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf > > wrote: > > > Could you untangle this mess around driving the editor?  (I might be > > > able to look into this later, but

Re: Testing help/advice needed.

2010-12-14 Thread C. Michael Pilato
On 12/14/2010 01:47 PM, Daniel Shahaf wrote: > C. Michael Pilato wrote on Tue, Dec 14, 2010 at 12:14:00 -0500: >> Is there a case to be made for allowing 'svnadmin load' to, upon specific >> request by the user (via a new --disable-prop-validation flag or something), > > Yes. > > We've had many r

Re: Testing help/advice needed.

2010-12-14 Thread Stefan Sperling
On Tue, Dec 14, 2010 at 03:57:37PM -0500, C. Michael Pilato wrote: > On 12/14/2010 01:47 PM, Daniel Shahaf wrote: > > C. Michael Pilato wrote on Tue, Dec 14, 2010 at 12:14:00 -0500: > >> Is there a case to be made for allowing 'svnadmin load' to, upon specific > >> request by the user (via a new --

[RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-14 Thread Johan Corveleyn
Hi all, On the diff-optimizations-bytes branch, in diff_file.c, there are two functions which are called for every byte of the identical prefix and suffix: increment_pointers and decrement_pointers. These functions are actually equivalents of curp++ or curp--, reading the next/previous byte, but t

Re: Testing help/advice needed.

2010-12-14 Thread Peter Samuelson
[C. Michael Pilato] > It's not just revprops that are being validated by the 'svnadmin load' > process now -- it's node properties (svn:ignore, etc.), too. I can > certainly see the case for allowing a *technically* sane dump to be loaded > without error, even if some of the contents thereof aren

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-14 Thread Peter Samuelson
[Johan Corveleyn] > As an experiment I changed these functions into macro's, eliminating > the function calls. This makes the diff algorithm another 10% - 15% > faster (granted, this was measured with my "extreme" testcase of a > 1,5 Mb file (6 lines), of which most lines are identical > prefi

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-14 Thread Stefan Fuhrmann
On 14.12.2010 23:35, Johan Corveleyn wrote: Hi all, Hi Johan ;) On the diff-optimizations-bytes branch, in diff_file.c, there are two functions which are called for every byte of the identical prefix and suffix: increment_pointers and decrement_pointers. These functions are actually equivalents

Re: svn commit: r1044833 - /subversion/trunk/notes/fsfs-improvements.txt

2010-12-14 Thread Stefan Fuhrmann
On 13.12.2010 16:13, Hyrum K. Wright wrote: On Sun, Dec 12, 2010 at 9:23 AM, wrote: Author: stefan2 Date: Sun Dec 12 15:23:18 2010 New Revision: 1044833 URL: http://svn.apache.org/viewvc?rev=1044833&view=rev Log: Get some ideas for FSFS format improvements written down. * notes/fsfs-improveme

Move contrib/ to apache-extras.org

2010-12-14 Thread Hyrum K. Wright
I'd like to move everything in our contrib/ directory to the new Apache Extras hosting. As many might know, I've been on a personal crusade to stop the Subversion project from being a source code hosting system. In the early days, when it was useful for people to have a collection of Subversion-r

Re: Move contrib/ to apache-extras.org

2010-12-14 Thread Eric Raymond
Hyrum K. Wright : > I'd like to move everything in our contrib/ directory to the new > Apache Extras hosting. > > Thoughts? Am a contributor. Am not opposed. -- http://www.catb.org/~esr/";>Eric S. Raymond

Re: svn commit: r1049414 - /subversion/trunk/subversion/tests/svn_test_main.c

2010-12-14 Thread Blair Zajac
On 12/14/10 8:21 PM, hwri...@apache.org wrote: Author: hwright Date: Wed Dec 15 04:21:23 2010 New Revision: 1049414 URL: http://svn.apache.org/viewvc?rev=1049414&view=rev Log: Allow tests which cause segfaults to not disrupt the other tests in the C testsuite. This becomes useful when committin

Re: Move contrib/ to apache-extras.org

2010-12-14 Thread Blair Zajac
On 12/14/10 8:28 PM, Hyrum K. Wright wrote: I'd like to move everything in our contrib/ directory to the new Apache Extras hosting. As many might know, I've been on a personal crusade to stop the Subversion project from being a source code hosting system. In the early days, when it was useful f

Re: Input validation observations

2010-12-14 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Julian Foad writes: >> > Thank you for the updated patch. Even though this is a very >> > simple-looking patch, I need a bit more information to help me review >> > it. >> > >> > Do you think both of the options I suggested are possible solutio