Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Daniel Shahaf
CC += dev@ Daniel Näslund wrote on Mon, Dec 06, 2010 at 21:32:39 +0100: > On Mon, Dec 06, 2010 at 01:44:23PM -0600, David Dyer-Bennet wrote: > > Subversion 1.6.12 running on Centos 5.5 > > > > If the value of the environment variable VISUAL contains a space, > > subversion fails when attempting t

Re: svn commit: r1040832 - Port a fix for a FSFS packing race

2010-12-07 Thread Julian Foad
On Mon, 2010-12-06 at 18:44 +, Philip Martin wrote: > Julian Foad writes: > > > I'm going to drop this "Remove the re-try logic from > > svn_fs_fs__path_rev_absolute()" follow-up patch, as I don't want to get > > into checking or messing with the txn-correctness of FSFS now. If > > Daniel or

Re: svn commit: r1040832 - Port a fix for a FSFS packing race

2010-12-07 Thread Philip Martin
Julian Foad writes: > On Mon, 2010-12-06 at 18:44 +, Philip Martin wrote: >> Julian Foad writes: >> >> > I'm going to drop this "Remove the re-try logic from >> > svn_fs_fs__path_rev_absolute()" follow-up patch, as I don't want to get >> > into checking or messing with the txn-correctness o

[PATCH] Follow-up to r879452.

2010-12-07 Thread Noorul Islam K M
Log [[[ Follow-up to r879452. * subversion/libsvn_ra_local/ra_plugin.c (svn_ra_local__obliterate_path_rev): Replace call to svn_path_join() with svn_dirent_join() function. Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: subversion/libsvn_ra_local/ra_plugin.c ==

Re: svn commit: r1040832 - Port a fix for a FSFS packing race

2010-12-07 Thread Daniel Shahaf
Julian Foad wrote on Tue, Dec 07, 2010 at 09:40:07 +: > On Mon, 2010-12-06 at 18:44 +, Philip Martin wrote: > > Julian Foad writes: > > > > > I'm going to drop this "Remove the re-try logic from > > > svn_fs_fs__path_rev_absolute()" follow-up patch, as I don't want to get > > > into check

Re: svn commit: r1040832 - Port a fix for a FSFS packing race

2010-12-07 Thread Daniel Shahaf
Philip Martin wrote on Tue, Dec 07, 2010 at 09:49:40 +: > Julian Foad writes: > > > On Mon, 2010-12-06 at 18:44 +, Philip Martin wrote: > >> Julian Foad writes: > >> > >> > I'm going to drop this "Remove the re-try logic from > >> > svn_fs_fs__path_rev_absolute()" follow-up patch, as I

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Julian Foad
On Tue, 2010-12-07, Daniel Shahaf wrote: > CC += dev@ > > Daniel Näslund wrote on Mon, Dec 06, 2010 at 21:32:39 +0100: > > On Mon, Dec 06, 2010 at 01:44:23PM -0600, David Dyer-Bennet wrote: > > > Subversion 1.6.12 running on Centos 5.5 > > > > > > If the value of the environment variable VISUAL c

Re: [PATCH] Follow-up to r879452.

2010-12-07 Thread Julian Foad
Noorul Islam K M wrote: > Log > [[[ > Follow-up to r879452. > > * subversion/libsvn_ra_local/ra_plugin.c > (svn_ra_local__obliterate_path_rev): Replace call to svn_path_join() > with svn_dirent_join() function. Hi Noorul. Why? Please explain. - Julian > Patch by: Noorul Islam K M > ]]

Re: [PATCH] Follow-up to r879452.

2010-12-07 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Log >> [[[ >> Follow-up to r879452. >> >> * subversion/libsvn_ra_local/ra_plugin.c >> (svn_ra_local__obliterate_path_rev): Replace call to svn_path_join() >> with svn_dirent_join() function. > > Hi Noorul. > > Why? Please explain. > Beca

Re: [PATCH] Follow-up to r879452.

2010-12-07 Thread Julian Foad
On Tue, 2010-12-07 at 16:06 +0530, Noorul Islam K M wrote: > Julian Foad writes: > > > Noorul Islam K M wrote: > > > >> Log > >> [[[ > >> Follow-up to r879452. > >> > >> * subversion/libsvn_ra_local/ra_plugin.c > >> (svn_ra_local__obliterate_path_rev): Replace call to svn_path_join() > >>

SVN_WC__OP_DEPTH format bump soon

2010-12-07 Thread Philip Martin
The current wcng code, format 22, puts all working nodes at op-depth=2. The full op-depth code is enabled by defining SVN_WC__OP_DEPTH and, although no schema changes are involved, the way the database is used makes in incompatible with format 22 clients if working nodes are present. So SVN_WC__OP

Re: SVN_WC__OP_DEPTH format bump soon

2010-12-07 Thread Julian Foad
On Tue, 2010-12-07 at 14:29 +, Philip Martin wrote: > The current wcng code, format 22, puts all working nodes at op-depth=2. > The full op-depth code is enabled by defining SVN_WC__OP_DEPTH and, > although no schema changes are involved, the way the database is used > makes in incompatible wit

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread David Dyer-Bennet
On Tue, December 7, 2010 04:18, Julian Foad wrote: > On Tue, 2010-12-07, Daniel Shahaf wrote: > I confirmed that there was a bug in that report, but that was on Windows > and the evidence there was that the arguments were not being parsed > correctly even when the space was escaped with the "^" c

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Daniel Shahaf
David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600: > On Tue, December 7, 2010 04:18, Julian Foad wrote: > > On Tue, 2010-12-07, Daniel Shahaf wrote: > >> I suppose setting VISUAL="\"/path with spaces/to/editor/binary\"" is the > >> easiest solution --- it requires no code changes so it

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Peter Samuelson
[David Dyer-Bennet] > >> I suppose setting VISUAL="\"/path with spaces/to/editor/binary\"" is the > >> easiest solution --- it requires no code changes so it will work with > >> any svn binary out there. > > > > Yes, I think that's the best solution. > > And, in any case, VISUAL is a public inter

Re: svn commit: r1040832 - Port a fix for a FSFS packing race

2010-12-07 Thread Julian Foad
(Quoting and replying to two emails at once.) First: I'm assuming that no process will ever do packing without getting the exclusive write lock. Can you confirm that for me? If that's false, all my reasoning would be bogus. On Tue, 2010-12-07 at 12:13 +0200, Daniel Shahaf wrote: > Philip Marti

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread David Dyer-Bennet
On Tue, December 7, 2010 09:03, Daniel Shahaf wrote: > David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600: >> On Tue, December 7, 2010 04:18, Julian Foad wrote: >> > On Tue, 2010-12-07, Daniel Shahaf wrote: >> >> I suppose setting VISUAL="\"/path with spaces/to/editor/binary\"" is >> t

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Daniel Shahaf
David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 09:30:45 -0600: > On Tue, December 7, 2010 09:03, Daniel Shahaf wrote: > > David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600: > >> And, in any case, VISUAL is a public interface, and I wonder how many > >> other applications would break i

Re: Input validation observations

2010-12-07 Thread Julian Foad
On Sat, 2010-12-04, Noorul Islam K M wrote: > Julian Foad writes: > > On Fri, 2010-12-03, Noorul Islam K M wrote: > >> Julian Foad writes: > >> > I think we should change this behaviour and make "svn update" throw an > >> > error if any target is a URL. > >> > >> Attached is the patch for same.

Re: Input validation observations

2010-12-07 Thread Noorul Islam K M
Julian Foad writes: > On Sat, 2010-12-04, Noorul Islam K M wrote: > >> Julian Foad writes: >> > On Fri, 2010-12-03, Noorul Islam K M wrote: >> >> Julian Foad writes: >> >> > I think we should change this behaviour and make "svn update" throw an >> >> > error if any target is a URL. >> >> >> >>

Re: [PATCH] Follow-up to r879452.

2010-12-07 Thread Noorul Islam K M
Julian Foad writes: > On Tue, 2010-12-07 at 16:06 +0530, Noorul Islam K M wrote: > >> Julian Foad writes: >> >> > Noorul Islam K M wrote: >> > >> >> Log >> >> [[[ >> >> Follow-up to r879452. >> >> >> >> * subversion/libsvn_ra_local/ra_plugin.c >> >> (svn_ra_local__obliterate_path_rev): Repla

Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

2010-12-07 Thread Peter Samuelson
[David Dyer-Bennet] > as I said in my initial post, I first discovered this on Windows > under Cygwin. Avoiding "c:/Program Files" and "c:/Documents and > Settings/david.dyer-bennet/My Documents" involves contortions and > leaves you putting things in unusual places. Well, or calling them C:/PRO

Re: svn commit: r1040832 - Port a fix for a FSFS packing race

2010-12-07 Thread Daniel Shahaf
Julian Foad wrote on Tue, Dec 07, 2010 at 15:27:05 +: > (Quoting and replying to two emails at once.) > > First: I'm assuming that no process will ever do packing without getting > the exclusive write lock. Can you confirm that for me? If that's > false, all my reasoning would be bogus. >

Re: 1.5.9 up for testing/signing

2010-12-07 Thread Hyrum K. Wright
Quick reminder that we are still lacking one Unix sig and one Windows sig for this release. -Hyrum On Thu, Dec 2, 2010 at 3:55 PM, Hyrum K. Wright wrote: > 1.5.9 tarballs are up for testing and signing.  The magic revision is > r1041577: > http://people.apache.org/~hwright/svn/1.5.9/ > > To sig

Re: svn commit: r1040832 - Port a fix for a FSFS packing race

2010-12-07 Thread Julian Foad
On Tue, 2010-12-07, Daniel Shahaf wrote: > Julian Foad wrote on Tue, Dec 07, 2010 at 15:27:05 +: > > (Quoting and replying to two emails at once.) > > > > First: I'm assuming that no process will ever do packing without getting > > the exclusive write lock. Can you confirm that for me? If th

Re: Input validation observations

2010-12-07 Thread Noorul Islam K M
Noorul Islam K M writes: > Julian Foad writes: > >> On Sat, 2010-12-04, Noorul Islam K M wrote: >> >>> Julian Foad writes: >>> > On Fri, 2010-12-03, Noorul Islam K M wrote: >>> >> Julian Foad writes: >>> >> > I think we should change this behaviour and make "svn update" throw an >>> >> > error