RE: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Bert Huijben
> -Original Message- > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > Sent: donderdag 4 november 2010 0:21 > To: Subversion Development > Subject: [Patch] Make svn_tristate_t compatible with svn_boolean_t > > Hi there, > > after stumbling twice over this issue, I ran grep

[PATCH] Canonicalize path/URL inside svn_opt__split_arg_at_peg_revision

2010-11-04 Thread Noorul Islam K M
Log [[[ Since svn_opt__split_arg_at_peg_revision() is called from two major wrappers svn_opt__args_to_target_array() and svn_opt_parse_path(), move canonicalize code into svn_opt__split_arg_at_peg_revision(). * subversion/libsvn_subr/opt.c (svn_opt__split_arg_at_peg_revision): Canonicalize p

Re: Canonicalize path/URL inside svn_opt__split_arg_at_peg_revision

2010-11-04 Thread Noorul Islam K M
Noorul Islam K M writes: > Log > > [[[ > > Since svn_opt__split_arg_at_peg_revision() is called from two major > wrappers svn_opt__args_to_target_array() and svn_opt_parse_path(), move > canonicalize code into svn_opt__split_arg_at_peg_revision(). > > * subversion/libsvn_subr/opt.c > (svn_opt_

RE: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
Bert Huijben wrote: > > -Original Message- > > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > > after stumbling twice over this issue, I ran grep > > and found that the current usage of svn_tristate_t > > does not depend on the actual numerical values > > used for its states.

Re: Upgrading partially relocated working copies

2010-11-04 Thread Philip Martin
"C. Michael Pilato" writes: > On 10/19/2010 10:59 AM, Philip Martin wrote: >> In 1.7 we insist that "switch --relocate" only acts on a whole working >> copy. In 1.6 we allow parts of the working copy to be relocated. >> What should 1.7 do when upgrading a partially switched working copy? >> >>

Potential bugs: NULL strings from svn_tristate_to_word()

2010-11-04 Thread Julian Foad
In svn/log-cmd.c:log_entry_receiver_xml(), svn_xml_make_open_tag() is called with attribute values from tristate_to_word that may be NULL, and this is not documented as acceptable. In mod_dav_svn/reports/log.c:log_receiver(), dav_svn__brigade_printf() is called with "%s" arguments from tristate_to

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
On Thu, 2010-11-04, Stefan Fuhrmann wrote: > Hi there, > > after stumbling twice over this issue, I ran grep > and found that the current usage of svn_tristate_t > does not depend on the actual numerical values > used for its states. > > Therefore, I propose to define svn_tristate_false > equal t

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
On Thu, 2010-11-04 at 11:51 +, Julian Foad wrote: > On Thu, 2010-11-04, Stefan Fuhrmann wrote: > > Hi there, > > > > after stumbling twice over this issue, I ran grep > > and found that the current usage of svn_tristate_t > > does not depend on the actual numerical values > > used for its stat

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Hyrum K. Wright
On Thu, Nov 4, 2010 at 7:43 AM, Julian Foad wrote: > On Thu, 2010-11-04 at 11:51 +, Julian Foad wrote: >> On Thu, 2010-11-04, Stefan Fuhrmann wrote: >> > Hi there, >> > >> > after stumbling twice over this issue, I ran grep >> > and found that the current usage of svn_tristate_t >> > does not

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Hyrum K. Wright
On Thu, Nov 4, 2010 at 6:51 AM, Julian Foad wrote: > On Thu, 2010-11-04, Stefan Fuhrmann wrote: >> Hi there, >> >> after stumbling twice over this issue, I ran grep >> and found that the current usage of svn_tristate_t >> does not depend on the actual numerical values >> used for its states. >> >>

RE: svn commit: r1030912 - in /subversion/trunk/subversion/libsvn_wc: adm_crawler.c update_editor.c

2010-11-04 Thread Bert Huijben
> -Original Message- > From: cmpil...@apache.org [mailto:cmpil...@apache.org] > Sent: donderdag 4 november 2010 13:46 > To: comm...@subversion.apache.org > Subject: svn commit: r1030912 - in > /subversion/trunk/subversion/libsvn_wc: adm_crawler.c update_editor.c > > Author: cmpilato > Da

Re: svn commit: r1030912 - in /subversion/trunk/subversion/libsvn_wc: adm_crawler.c update_editor.c

2010-11-04 Thread C. Michael Pilato
On 11/04/2010 09:07 AM, Bert Huijben wrote: > Some time ago I hinted about creating a special wc-ng status for 'pinned' > nodes. > > This would introduce a well defined foundation in wc-ng that we can use > for both file-externals (now) and viewspecs (later). I brought up a similar idea many year

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-04 Thread Julian Foad
On Thu, 2010-11-04 at 07:45 -0500, Hyrum K. Wright wrote: > On Thu, Nov 4, 2010 at 7:43 AM, Julian Foad wrote: > > On Thu, 2010-11-04 at 11:51 +, Julian Foad wrote: > >> On Thu, 2010-11-04, Stefan Fuhrmann wrote: > >> > Hi there, > >> > > >> > after stumbling twice over this issue, I ran grep

RE: svn commit: r1031035 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-11-04 Thread Bert Huijben
> -Original Message- > From: hwri...@apache.org [mailto:hwri...@apache.org] > Sent: donderdag 4 november 2010 16:31 > To: comm...@subversion.apache.org > Subject: svn commit: r1031035 - > /subversion/trunk/subversion/libsvn_wc/wc_db.c > > Author: hwright > Date: Thu Nov 4 15:31:14 2010

Re: svn commit: r1031035 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-11-04 Thread Hyrum K. Wright
On Thu, Nov 4, 2010 at 10:54 AM, Bert Huijben wrote: > > >> -Original Message- >> From: hwri...@apache.org [mailto:hwri...@apache.org] >> Sent: donderdag 4 november 2010 16:31 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1031035 - >> /subversion/trunk/subversion/libsvn_wc/

Re: svn commit: r1031114 - /subversion/trunk/subversion/include/svn_client.h

2010-11-04 Thread Hyrum K. Wright
On Thu, Nov 4, 2010 at 1:05 PM, wrote: > Author: cmpilato > Date: Thu Nov  4 18:05:41 2010 > New Revision: 1031114 > > URL: http://svn.apache.org/viewvc?rev=1031114&view=rev > Log: > Avoid 'swig-py' build warnings of this variety: > >    'from' is a python keyword, renaming to '_from' > > * subve

Re: svn commit: r1031140 - in /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp src/org/apache/subversion/javahl/Info2.java

2010-11-04 Thread Blair Zajac
On 11/04/2010 11:40 AM, hwri...@apache.org wrote: Author: hwright Date: Thu Nov 4 18:40:18 2010 New Revision: 1031140 URL: http://svn.apache.org/viewvc?rev=1031140&view=rev Log: JavaHL: Include the working copy root in the Info2 struct. /** + * return the workgin copy root s/wor

Re: Fix for issue 3620 - status command

2010-11-04 Thread Stefan Sperling
On Thu, Nov 04, 2010 at 09:56:39AM +0530, Noorul Islam K M wrote: > Make 'svn status' verify that none of its targets are URLs. Thank you, r1031160.

Re: svn commit: r1031265 - /subversion/branches/py-tests-as-modules/subversion/tests/cmdline/svntest/main.py

2010-11-04 Thread Hyrum Wright
Bert, If you get a minute, could you try this branch on Windows and see if the tests are still broken there? I've no way of testing this locally, and would like to get it merged back to trunk at some point. Thanks, -Hyrum On Thu, Nov 4, 2010 at 4:34 PM, wrote: > Author: hwright > Date: Thu Nov

Re: svn commit: r1031114 - /subversion/trunk/subversion/include/svn_client.h

2010-11-04 Thread C. Michael Pilato
On 11/04/2010 02:11 PM, Hyrum K. Wright wrote: > On Thu, Nov 4, 2010 at 1:05 PM, wrote: >> Author: cmpilato >> Date: Thu Nov 4 18:05:41 2010 >> New Revision: 1031114 >> >> URL: http://svn.apache.org/viewvc?rev=1031114&view=rev >> Log: >> Avoid 'swig-py' build warnings of this variety: >> >>'

Re: Upgrading partially relocated working copies

2010-11-04 Thread C. Michael Pilato
On 11/04/2010 07:23 AM, Philip Martin wrote: > I don't think it makes sense for upgrade to preserve the > mixed-location-ness as the user could not use 1.7 to convert such a > working copy to single-location. The only sensible options are either > to detect the mixed-location-ness and abort the up

"svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-04 Thread Chris Tashjian
I posted this on the users list, but I'm confident that this is a bug. Background: For a while now (off and on for over a year, but more frequently in the last 6+ months) we've been having problems with svn "crashing", yet there's no error in the log file. In talking to someone the users list

Error copying repo file over deleted WC dir: no write-lock in parent

2010-11-04 Thread Julian Foad
Can I have a second pair of eyes on this please? When copy_tests.py 94 deletes a WC directory 'A/B' and tries to copy the repos file 'iota' to WC path 'A/B', it the svn_wc_add_repos_file4() call fails with: .../libsvn_client/copy.c:1570: (apr_err=155005) .../libsvn_wc/update_editor.c:5572: (a